diff options
| author | Nick Brassel <nick@tzarc.org> | 2020-08-07 06:16:14 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-07 06:16:14 +1000 |
| commit | 8dc2502177ea24b31190b073f4a0fdef92d73bff (patch) | |
| tree | 7c01cb0bcf6a9d5fb25693f9ad7e150a6676adb1 /.github/PULL_REQUEST_TEMPLATE.md | |
| parent | 547410b65514b14acb37496c89d68618d20d16a6 (diff) | |
| download | qmk_firmware-8dc2502177ea24b31190b073f4a0fdef92d73bff.tar.gz qmk_firmware-8dc2502177ea24b31190b073f4a0fdef92d73bff.zip | |
Add PR checklist document. (#9913)
* Add PR checklist document.
* Update docs/pr_checklist.md
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Ryan <fauxpark@gmail.com>
* Reword the lower/raise/adjust suggestion somewhat for clarity.
* Add suggestion from @Didel for coding conventions.
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Diffstat (limited to '.github/PULL_REQUEST_TEMPLATE.md')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cbc018ea0..d402488d4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md | |||
| @@ -26,7 +26,8 @@ | |||
| 26 | 26 | ||
| 27 | <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | 27 | <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> |
| 28 | <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> | 28 | <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> |
| 29 | - [ ] My code follows the code style of this project. | 29 | - [ ] My code follows the code style of this project: [**C**](https://docs.qmk.fm/#/coding_conventions_c), [**Python**](https://docs.qmk.fm/#/coding_conventions_python) |
| 30 | - [ ] I have read the [**PR Checklist** document](https://docs.qmk.fm/#/pr_checklist) and have made the appropriate changes. | ||
| 30 | - [ ] My change requires a change to the documentation. | 31 | - [ ] My change requires a change to the documentation. |
| 31 | - [ ] I have updated the documentation accordingly. | 32 | - [ ] I have updated the documentation accordingly. |
| 32 | - [ ] I have read the [**CONTRIBUTING** document](https://docs.qmk.fm/#/contributing). | 33 | - [ ] I have read the [**CONTRIBUTING** document](https://docs.qmk.fm/#/contributing). |