diff options
| author | QMK Bot <hello@qmk.fm> | 2021-06-23 00:45:47 +0000 |
|---|---|---|
| committer | QMK Bot <hello@qmk.fm> | 2021-06-23 00:45:47 +0000 |
| commit | 973a006c4561218eef365733558c1c31e2abdb49 (patch) | |
| tree | 92ab666a139efd58ce07af65b5dee0b26c54d87e | |
| parent | 791363a6806d575e767ccf1de5bedb6224e39f97 (diff) | |
| parent | 268d0efa7e3c600f5749670f51199c3f12022730 (diff) | |
| download | qmk_firmware-973a006c4561218eef365733558c1c31e2abdb49.tar.gz qmk_firmware-973a006c4561218eef365733558c1c31e2abdb49.zip | |
Merge remote-tracking branch 'origin/master' into develop
| -rw-r--r-- | docs/pr_checklist.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index 58df15303..9bfa79403 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md | |||
| @@ -68,7 +68,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard | |||
| 68 | - bare minimum required code for a board to boot into QMK should be present | 68 | - bare minimum required code for a board to boot into QMK should be present |
| 69 | - initialisation code for the matrix and critical devices | 69 | - initialisation code for the matrix and critical devices |
| 70 | - mirroring existing functionality of a commercial board (like custom keycodes and special animations etc.) should be handled through non-`default` keymaps | 70 | - mirroring existing functionality of a commercial board (like custom keycodes and special animations etc.) should be handled through non-`default` keymaps |
| 71 | - VIAL-related files or changes will not be accepted, as they are not used by QMK firmware (no VIAL-specific core code has been submitted or merged) | 71 | - Vial-related files or changes will not be accepted, as they are not used by QMK firmware (no Vial-specific core code has been submitted or merged) |
| 72 | - `keyboard.c` | 72 | - `keyboard.c` |
| 73 | - empty `xxxx_xxxx_kb()` or other weak-defined default implemented functions removed | 73 | - empty `xxxx_xxxx_kb()` or other weak-defined default implemented functions removed |
| 74 | - commented-out functions removed too | 74 | - commented-out functions removed too |