diff options
author | fauxpark <fauxpark@gmail.com> | 2020-01-24 14:24:10 +1100 |
---|---|---|
committer | James Young <18669334+noroadsleft@users.noreply.github.com> | 2020-01-23 19:24:10 -0800 |
commit | b56899976924043a9563c12987218abd78baf13d (patch) | |
tree | 10751dc02dd9fef177a1a4a57eda533a3f551b08 | |
parent | fe50883c1568b1914fcadbe0c7f029c3f9fd99f4 (diff) | |
download | qmk_firmware-b56899976924043a9563c12987218abd78baf13d.tar.gz qmk_firmware-b56899976924043a9563c12987218abd78baf13d.zip |
Fix LED configuration for PS2AVRGB boards (#7989)
* Fix LED configuration for PS2AVRGB boards
* Undo backlight on state changes
38 files changed, 71 insertions, 102 deletions
diff --git a/keyboards/ares/ares.c b/keyboards/ares/ares.c index e6379cb18..95d4b878f 100644 --- a/keyboards/ares/ares.c +++ b/keyboards/ares/ares.c | |||
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { | |||
24 | 24 | ||
25 | void led_init_ports(void) { | 25 | void led_init_ports(void) { |
26 | setPinOutput(D1); | 26 | setPinOutput(D1); |
27 | writePinHigh(D1); | ||
28 | } | 27 | } |
29 | 28 | ||
30 | bool led_update_kb(led_t led_state) { | 29 | bool led_update_kb(led_t led_state) { |
31 | if (led_update_user(led_state)) { | 30 | if (led_update_user(led_state)) { |
32 | writePin(D1, !led_state.caps_lock); | 31 | writePin(D1, led_state.caps_lock); |
33 | } | 32 | } |
34 | return true; | 33 | return true; |
35 | } | 34 | } |
diff --git a/keyboards/ares/config.h b/keyboards/ares/config.h index c50587db9..e298dfc95 100644 --- a/keyboards/ares/config.h +++ b/keyboards/ares/config.h | |||
@@ -39,6 +39,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
39 | 39 | ||
40 | #define BACKLIGHT_PIN D4 | 40 | #define BACKLIGHT_PIN D4 |
41 | #define BACKLIGHT_LEVELS 3 | 41 | #define BACKLIGHT_LEVELS 3 |
42 | |||
42 | #define RGBLIGHT_ANIMATIONS | 43 | #define RGBLIGHT_ANIMATIONS |
43 | 44 | ||
44 | #define NO_UART 1 | 45 | #define NO_UART 1 |
diff --git a/keyboards/bfake/bfake.c b/keyboards/bfake/bfake.c index eb328ba83..6d0c92746 100644 --- a/keyboards/bfake/bfake.c +++ b/keyboards/bfake/bfake.c | |||
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { | |||
24 | 24 | ||
25 | void led_init_ports(void) { | 25 | void led_init_ports(void) { |
26 | setPinOutput(D1); | 26 | setPinOutput(D1); |
27 | writePinHigh(D1); | ||
28 | } | 27 | } |
29 | 28 | ||
30 | bool led_update_kb(led_t led_state) { | 29 | bool led_update_kb(led_t led_state) { |
31 | if (led_update_user(led_state)) { | 30 | if (led_update_user(led_state)) { |
32 | writePin(D1, !led_state.caps_lock); | 31 | writePin(D1, led_state.caps_lock); |
33 | } | 32 | } |
34 | return true; | 33 | return true; |
35 | } | 34 | } |
diff --git a/keyboards/bfake/config.h b/keyboards/bfake/config.h index 7c814ccc9..ef7a866d3 100644 --- a/keyboards/bfake/config.h +++ b/keyboards/bfake/config.h | |||
@@ -39,6 +39,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
39 | 39 | ||
40 | #define BACKLIGHT_PIN D4 | 40 | #define BACKLIGHT_PIN D4 |
41 | #define BACKLIGHT_LEVELS 3 | 41 | #define BACKLIGHT_LEVELS 3 |
42 | |||
42 | #define RGBLIGHT_ANIMATIONS | 43 | #define RGBLIGHT_ANIMATIONS |
43 | 44 | ||
44 | #define NO_UART 1 | 45 | #define NO_UART 1 |
diff --git a/keyboards/db/db63/config.h b/keyboards/db/db63/config.h index 488409e3a..3183201c1 100644 --- a/keyboards/db/db63/config.h +++ b/keyboards/db/db63/config.h | |||
@@ -41,4 +41,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
41 | 41 | ||
42 | #define BACKLIGHT_PIN D4 | 42 | #define BACKLIGHT_PIN D4 |
43 | #define BACKLIGHT_LEVELS 3 | 43 | #define BACKLIGHT_LEVELS 3 |
44 | |||
diff --git a/keyboards/donutcables/budget96/budget96.c b/keyboards/donutcables/budget96/budget96.c index 7317e24e2..5f3436dc6 100644 --- a/keyboards/donutcables/budget96/budget96.c +++ b/keyboards/donutcables/budget96/budget96.c | |||
@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) { | |||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D0); | 25 | setPinOutput(D0); |
26 | setPinOutput(D1); | 26 | setPinOutput(D1); |
27 | writePinHigh(D0); | ||
28 | writePinHigh(D1); | ||
29 | } | 27 | } |
30 | 28 | ||
31 | bool led_update_kb(led_t led_state) { | 29 | bool led_update_kb(led_t led_state) { |
32 | if (led_update_user(led_state)) { | 30 | if (led_update_user(led_state)) { |
33 | writePin(D0, !led_state.num_lock); | 31 | writePin(D0, led_state.num_lock); |
34 | writePin(D1, !led_state.caps_lock); | 32 | writePin(D1, led_state.caps_lock); |
35 | } | 33 | } |
36 | return true; | 34 | return true; |
37 | } | 35 | } |
diff --git a/keyboards/donutcables/budget96/config.h b/keyboards/donutcables/budget96/config.h index dddc8075b..0e05bb76f 100644 --- a/keyboards/donutcables/budget96/config.h +++ b/keyboards/donutcables/budget96/config.h | |||
@@ -39,4 +39,5 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
39 | 39 | ||
40 | #define BACKLIGHT_PIN D4 | 40 | #define BACKLIGHT_PIN D4 |
41 | #define BACKLIGHT_LEVELS 3 | 41 | #define BACKLIGHT_LEVELS 3 |
42 | |||
42 | #define RGBLIGHT_ANIMATIONS | 43 | #define RGBLIGHT_ANIMATIONS |
diff --git a/keyboards/eve/meteor/meteor.c b/keyboards/eve/meteor/meteor.c index ac1ca5d64..1d080b389 100644 --- a/keyboards/eve/meteor/meteor.c +++ b/keyboards/eve/meteor/meteor.c | |||
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { | |||
23 | 23 | ||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | writePinHigh(D1); | ||
27 | } | 26 | } |
28 | 27 | ||
29 | bool led_update_kb(led_t led_state) { | 28 | bool led_update_kb(led_t led_state) { |
30 | if (led_update_user(led_state)) { | 29 | if (led_update_user(led_state)) { |
31 | writePin(D1, !led_state.caps_lock); | 30 | writePin(D1, led_state.caps_lock); |
32 | } | 31 | } |
33 | return true; | 32 | return true; |
34 | } | 33 | } |
diff --git a/keyboards/exclusive/e6v2/le_bmc/le_bmc.c b/keyboards/exclusive/e6v2/le_bmc/le_bmc.c index b09e58879..df79cc5dc 100644 --- a/keyboards/exclusive/e6v2/le_bmc/le_bmc.c +++ b/keyboards/exclusive/e6v2/le_bmc/le_bmc.c | |||
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { | |||
23 | 23 | ||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | writePinHigh(D1); | ||
27 | } | 26 | } |
28 | 27 | ||
29 | bool led_update_kb(led_t led_state) { | 28 | bool led_update_kb(led_t led_state) { |
30 | if (led_update_user(led_state)) { | 29 | if (led_update_user(led_state)) { |
31 | writePin(D1, !led_state.caps_lock); | 30 | writePin(D1, led_state.caps_lock); |
32 | } | 31 | } |
33 | return true; | 32 | return true; |
34 | } | 33 | } |
diff --git a/keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c b/keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c index a0a6c579b..ea74d87cb 100644 --- a/keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c +++ b/keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c | |||
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { | |||
23 | 23 | ||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | writePinHigh(D1); | ||
27 | } | 26 | } |
28 | 27 | ||
29 | bool led_update_kb(led_t led_state) { | 28 | bool led_update_kb(led_t led_state) { |
30 | if (led_update_user(led_state)) { | 29 | if (led_update_user(led_state)) { |
31 | writePin(D1, !led_state.caps_lock); | 30 | writePin(D1, led_state.caps_lock); |
32 | } | 31 | } |
33 | return true; | 32 | return true; |
34 | } | 33 | } |
diff --git a/keyboards/exent/config.h b/keyboards/exent/config.h index 4921746c1..48aee2206 100644 --- a/keyboards/exent/config.h +++ b/keyboards/exent/config.h | |||
@@ -41,6 +41,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
41 | 41 | ||
42 | #define BACKLIGHT_PIN D4 | 42 | #define BACKLIGHT_PIN D4 |
43 | #define BACKLIGHT_LEVELS 3 | 43 | #define BACKLIGHT_LEVELS 3 |
44 | |||
44 | #define RGBLIGHT_ANIMATIONS | 45 | #define RGBLIGHT_ANIMATIONS |
45 | 46 | ||
46 | #define NO_UART 1 | 47 | #define NO_UART 1 |
diff --git a/keyboards/exent/exent.c b/keyboards/exent/exent.c index c6870f2c7..a935e9e67 100644 --- a/keyboards/exent/exent.c +++ b/keyboards/exent/exent.c | |||
@@ -25,16 +25,13 @@ void led_init_ports(void) { | |||
25 | setPinOutput(D0); | 25 | setPinOutput(D0); |
26 | setPinOutput(D1); | 26 | setPinOutput(D1); |
27 | setPinOutput(D6); | 27 | setPinOutput(D6); |
28 | writePinHigh(D0); | ||
29 | writePinHigh(D1); | ||
30 | writePinHigh(D6); | ||
31 | } | 28 | } |
32 | 29 | ||
33 | bool led_update_kb(led_t led_state) { | 30 | bool led_update_kb(led_t led_state) { |
34 | if (led_update_user(led_state)) { | 31 | if (led_update_user(led_state)) { |
35 | writePin(D0, !led_state.num_lock); | 32 | writePin(D0, led_state.num_lock); |
36 | writePin(D1, !led_state.caps_lock); | 33 | writePin(D1, led_state.caps_lock); |
37 | writePin(D6, !led_state.scroll_lock); | 34 | writePin(D6, led_state.scroll_lock); |
38 | } | 35 | } |
39 | return true; | 36 | return true; |
40 | } | 37 | } |
diff --git a/keyboards/facew/config.h b/keyboards/facew/config.h index 0dc35e625..be442548d 100644 --- a/keyboards/facew/config.h +++ b/keyboards/facew/config.h | |||
@@ -39,4 +39,5 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
39 | 39 | ||
40 | #define BACKLIGHT_PIN D4 | 40 | #define BACKLIGHT_PIN D4 |
41 | #define BACKLIGHT_LEVELS 3 | 41 | #define BACKLIGHT_LEVELS 3 |
42 | |||
42 | #define RGBLIGHT_ANIMATIONS | 43 | #define RGBLIGHT_ANIMATIONS |
diff --git a/keyboards/facew/facew.c b/keyboards/facew/facew.c index fc176466f..2f091ae6b 100644 --- a/keyboards/facew/facew.c +++ b/keyboards/facew/facew.c | |||
@@ -25,13 +25,12 @@ void keyboard_pre_init_kb(void) { | |||
25 | void led_init_ports(void) { | 25 | void led_init_ports(void) { |
26 | setPinOutput(D0); | 26 | setPinOutput(D0); |
27 | setPinOutput(D1); | 27 | setPinOutput(D1); |
28 | writePinHigh(D0); | ||
29 | writePinHigh(D1); | ||
30 | } | 28 | } |
31 | 29 | ||
32 | bool led_update_kb(led_t led_state) { | 30 | bool led_update_kb(led_t led_state) { |
33 | if (led_update_user(led_state)) { | 31 | if (led_update_user(led_state)) { |
34 | writePin(D1, !led_state.caps_lock); | 32 | writePin(D0, led_state.num_lock); |
33 | writePin(D1, led_state.caps_lock); | ||
35 | } | 34 | } |
36 | return true; | 35 | return true; |
37 | } | 36 | } |
diff --git a/keyboards/ft/mars80/config.h b/keyboards/ft/mars80/config.h index 38c3e851a..8c1ebe4ba 100644 --- a/keyboards/ft/mars80/config.h +++ b/keyboards/ft/mars80/config.h | |||
@@ -40,6 +40,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
40 | 40 | ||
41 | #define BACKLIGHT_PIN D4 | 41 | #define BACKLIGHT_PIN D4 |
42 | #define BACKLIGHT_LEVELS 3 | 42 | #define BACKLIGHT_LEVELS 3 |
43 | |||
43 | #define RGBLIGHT_ANIMATIONS | 44 | #define RGBLIGHT_ANIMATIONS |
44 | 45 | ||
45 | #define NO_UART 1 | 46 | #define NO_UART 1 |
diff --git a/keyboards/ft/mars80/mars80.c b/keyboards/ft/mars80/mars80.c index ca1950353..2c628a6a2 100644 --- a/keyboards/ft/mars80/mars80.c +++ b/keyboards/ft/mars80/mars80.c | |||
@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) { | |||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | setPinOutput(D6); | 26 | setPinOutput(D6); |
27 | writePinHigh(D1); | ||
28 | writePinHigh(D6); | ||
29 | } | 27 | } |
30 | 28 | ||
31 | bool led_update_kb(led_t led_state) { | 29 | bool led_update_kb(led_t led_state) { |
32 | if (led_update_user(led_state)) { | 30 | if (led_update_user(led_state)) { |
33 | writePin(D1, !led_state.caps_lock); | 31 | writePin(D1, led_state.caps_lock); |
34 | writePin(D6, !led_state.scroll_lock); | 32 | writePin(D6, led_state.scroll_lock); |
35 | } | 33 | } |
36 | return true; | 34 | return true; |
37 | } | 35 | } |
diff --git a/keyboards/gray_studio/hb85/config.h b/keyboards/gray_studio/hb85/config.h index dff360ec6..f3fb20ec6 100644 --- a/keyboards/gray_studio/hb85/config.h +++ b/keyboards/gray_studio/hb85/config.h | |||
@@ -33,3 +33,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
33 | 33 | ||
34 | #define RGBLED_NUM 5 | 34 | #define RGBLED_NUM 5 |
35 | #define RGBLIGHT_ANIMATIONS | 35 | #define RGBLIGHT_ANIMATIONS |
36 | |||
37 | #define BACKLIGHT_PIN D4 | ||
38 | #define BACKLIGHT_LEVELS 3 | ||
diff --git a/keyboards/gray_studio/hb85/hb85.c b/keyboards/gray_studio/hb85/hb85.c index 57f5e6031..4b3ff64f1 100644 --- a/keyboards/gray_studio/hb85/hb85.c +++ b/keyboards/gray_studio/hb85/hb85.c | |||
@@ -27,16 +27,13 @@ void led_init_ports(void) { | |||
27 | setPinOutput(D0); | 27 | setPinOutput(D0); |
28 | setPinOutput(D1); | 28 | setPinOutput(D1); |
29 | setPinOutput(D6); | 29 | setPinOutput(D6); |
30 | writePinHigh(D0); | ||
31 | writePinHigh(D1); | ||
32 | writePinHigh(D6); | ||
33 | } | 30 | } |
34 | 31 | ||
35 | bool led_update_kb(led_t led_state) { | 32 | bool led_update_kb(led_t led_state) { |
36 | if (led_update_user(led_state)) { | 33 | if (led_update_user(led_state)) { |
37 | writePin(D0, !led_state.num_lock); | 34 | writePin(D0, led_state.num_lock); |
38 | writePin(D1, !led_state.caps_lock); | 35 | writePin(D1, led_state.caps_lock); |
39 | writePin(D6, !led_state.scroll_lock); | 36 | writePin(D6, led_state.scroll_lock); |
40 | } | 37 | } |
41 | return true; | 38 | return true; |
42 | } | 39 | } |
diff --git a/keyboards/j80/j80.c b/keyboards/j80/j80.c index 4ac0200a2..bed30cdec 100644 --- a/keyboards/j80/j80.c +++ b/keyboards/j80/j80.c | |||
@@ -16,10 +16,21 @@ | |||
16 | 16 | ||
17 | #include "j80.h" | 17 | #include "j80.h" |
18 | 18 | ||
19 | void keyboard_pre_init_kb(void) { | ||
20 | led_init_ports(); | ||
21 | keyboard_pre_init_user(); | ||
22 | } | ||
23 | |||
24 | void led_init_ports(void) { | ||
25 | setPinOutput(D0); | ||
26 | setPinOutput(D1); | ||
27 | setPinOutput(D6); | ||
28 | } | ||
29 | |||
19 | bool led_update_kb(led_t led_state) { | 30 | bool led_update_kb(led_t led_state) { |
20 | if (led_update_user(led_state)) { | 31 | if (led_update_user(led_state)) { |
21 | writePin(D1, led_state.caps_lock); | ||
22 | writePin(D0, led_state.num_lock); | 32 | writePin(D0, led_state.num_lock); |
33 | writePin(D1, led_state.caps_lock); | ||
23 | writePin(D6, led_state.scroll_lock); | 34 | writePin(D6, led_state.scroll_lock); |
24 | } | 35 | } |
25 | return true; | 36 | return true; |
diff --git a/keyboards/jc65/v32a/v32a.c b/keyboards/jc65/v32a/v32a.c index 627661a57..f195e8f61 100644 --- a/keyboards/jc65/v32a/v32a.c +++ b/keyboards/jc65/v32a/v32a.c | |||
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { | |||
24 | 24 | ||
25 | void led_init_ports(void) { | 25 | void led_init_ports(void) { |
26 | setPinOutput(D1); | 26 | setPinOutput(D1); |
27 | writePinHigh(D1); | ||
28 | } | 27 | } |
29 | 28 | ||
30 | bool led_update_kb(led_t led_state) { | 29 | bool led_update_kb(led_t led_state) { |
31 | if (led_update_user(led_state)) { | 30 | if (led_update_user(led_state)) { |
32 | writePin(D1, !led_state.caps_lock); | 31 | writePin(D1, led_state.caps_lock); |
33 | } | 32 | } |
34 | return true; | 33 | return true; |
35 | } | 34 | } |
diff --git a/keyboards/kbdfans/kbdpad/mk1/mk1.c b/keyboards/kbdfans/kbdpad/mk1/mk1.c index f5fe47741..540ba3589 100644 --- a/keyboards/kbdfans/kbdpad/mk1/mk1.c +++ b/keyboards/kbdfans/kbdpad/mk1/mk1.c | |||
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { | |||
23 | 23 | ||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D0); | 25 | setPinOutput(D0); |
26 | writePinHigh(D0); | ||
27 | } | 26 | } |
28 | 27 | ||
29 | bool led_update_kb(led_t led_state) { | 28 | bool led_update_kb(led_t led_state) { |
30 | if (led_update_user(led_state)) { | 29 | if (led_update_user(led_state)) { |
31 | writePin(D0, !led_state.num_lock); | 30 | writePin(D0, led_state.num_lock); |
32 | } | 31 | } |
33 | return true; | 32 | return true; |
34 | } | 33 | } |
diff --git a/keyboards/mehkee96/mehkee96.c b/keyboards/mehkee96/mehkee96.c index 2da25b6b8..ae83a1bb5 100644 --- a/keyboards/mehkee96/mehkee96.c +++ b/keyboards/mehkee96/mehkee96.c | |||
@@ -25,14 +25,12 @@ void keyboard_pre_init_kb(void) { | |||
25 | void led_init_ports(void) { | 25 | void led_init_ports(void) { |
26 | setPinOutput(D0); | 26 | setPinOutput(D0); |
27 | setPinOutput(D1); | 27 | setPinOutput(D1); |
28 | writePinHigh(D0); | ||
29 | writePinHigh(D1); | ||
30 | } | 28 | } |
31 | 29 | ||
32 | bool led_update_kb(led_t led_state) { | 30 | bool led_update_kb(led_t led_state) { |
33 | if (led_update_user(led_state)) { | 31 | if (led_update_user(led_state)) { |
34 | writePin(D0, !led_state.num_lock); | 32 | writePin(D0, led_state.num_lock); |
35 | writePin(D1, !led_state.caps_lock); | 33 | writePin(D1, led_state.caps_lock); |
36 | } | 34 | } |
37 | return true; | 35 | return true; |
38 | } | 36 | } |
diff --git a/keyboards/panc60/panc60.c b/keyboards/panc60/panc60.c index a200b2587..d7ff52963 100644 --- a/keyboards/panc60/panc60.c +++ b/keyboards/panc60/panc60.c | |||
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { | |||
23 | 23 | ||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | writePinHigh(D1); | ||
27 | } | 26 | } |
28 | 27 | ||
29 | bool led_update_kb(led_t led_state) { | 28 | bool led_update_kb(led_t led_state) { |
30 | if (led_update_user(led_state)) { | 29 | if (led_update_user(led_state)) { |
31 | writePin(D1, !led_state.caps_lock); | 30 | writePin(D1, led_state.caps_lock); |
32 | } | 31 | } |
33 | return true; | 32 | return true; |
34 | } | 33 | } |
diff --git a/keyboards/pearl/pearl.c b/keyboards/pearl/pearl.c index cebbc9fcb..b08ee6f88 100644 --- a/keyboards/pearl/pearl.c +++ b/keyboards/pearl/pearl.c | |||
@@ -26,16 +26,13 @@ void led_init_ports(void) { | |||
26 | setPinOutput(D0); | 26 | setPinOutput(D0); |
27 | setPinOutput(D1); | 27 | setPinOutput(D1); |
28 | setPinOutput(D6); | 28 | setPinOutput(D6); |
29 | writePinHigh(D0); | ||
30 | writePinHigh(D1); | ||
31 | writePinHigh(D6); | ||
32 | } | 29 | } |
33 | 30 | ||
34 | bool led_update_kb(led_t led_state) { | 31 | bool led_update_kb(led_t led_state) { |
35 | if (led_update_user(led_state)) { | 32 | if (led_update_user(led_state)) { |
36 | writePin(D0, !led_state.num_lock); | 33 | writePin(D0, led_state.num_lock); |
37 | writePin(D1, !led_state.caps_lock); | 34 | writePin(D1, led_state.caps_lock); |
38 | writePin(D6, !led_state.scroll_lock); | 35 | writePin(D6, led_state.scroll_lock); |
39 | } | 36 | } |
40 | return true; | 37 | return true; |
41 | } | 38 | } |
diff --git a/keyboards/percent/canoe/canoe.c b/keyboards/percent/canoe/canoe.c index d3c66dbf1..dd31640e6 100644 --- a/keyboards/percent/canoe/canoe.c +++ b/keyboards/percent/canoe/canoe.c | |||
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { | |||
24 | 24 | ||
25 | void led_init_ports(void) { | 25 | void led_init_ports(void) { |
26 | setPinOutput(D1); | 26 | setPinOutput(D1); |
27 | writePinHigh(D1); | ||
28 | } | 27 | } |
29 | 28 | ||
30 | bool led_update_kb(led_t led_state) { | 29 | bool led_update_kb(led_t led_state) { |
31 | if (led_update_user(led_state)) { | 30 | if (led_update_user(led_state)) { |
32 | writePin(D1, !led_state.caps_lock); | 31 | writePin(D1, led_state.caps_lock); |
33 | } | 32 | } |
34 | return true; | 33 | return true; |
35 | } | 34 | } |
diff --git a/keyboards/percent/skog/skog.c b/keyboards/percent/skog/skog.c index 241833937..152fc5684 100644 --- a/keyboards/percent/skog/skog.c +++ b/keyboards/percent/skog/skog.c | |||
@@ -27,14 +27,12 @@ void keyboard_pre_init_kb(void) { | |||
27 | void led_init_ports(void) { | 27 | void led_init_ports(void) { |
28 | setPinOutput(D1); | 28 | setPinOutput(D1); |
29 | setPinOutput(D6); | 29 | setPinOutput(D6); |
30 | writePinHigh(D1); | ||
31 | writePinHigh(D6); | ||
32 | } | 30 | } |
33 | 31 | ||
34 | bool led_update_kb(led_t led_state) { | 32 | bool led_update_kb(led_t led_state) { |
35 | if (led_update_user(led_state)) { | 33 | if (led_update_user(led_state)) { |
36 | writePin(D1, !led_state.caps_lock); | 34 | writePin(D1, led_state.caps_lock); |
37 | writePin(D6, !led_state.scroll_lock); | 35 | writePin(D6, led_state.scroll_lock); |
38 | } | 36 | } |
39 | return true; | 37 | return true; |
40 | } | 38 | } |
diff --git a/keyboards/percent/skog_lite/skog_lite.c b/keyboards/percent/skog_lite/skog_lite.c index e611885a6..95d398211 100644 --- a/keyboards/percent/skog_lite/skog_lite.c +++ b/keyboards/percent/skog_lite/skog_lite.c | |||
@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) { | |||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | setPinOutput(D6); | 26 | setPinOutput(D6); |
27 | writePinHigh(D1); | ||
28 | writePinHigh(D6); | ||
29 | } | 27 | } |
30 | 28 | ||
31 | bool led_update_kb(led_t led_state) { | 29 | bool led_update_kb(led_t led_state) { |
32 | if (led_update_user(led_state)) { | 30 | if (led_update_user(led_state)) { |
33 | writePin(D1, !led_state.caps_lock); | 31 | writePin(D1, led_state.caps_lock); |
34 | writePin(D6, !led_state.scroll_lock); | 32 | writePin(D6, led_state.scroll_lock); |
35 | } | 33 | } |
36 | return true; | 34 | return true; |
37 | } | 35 | } |
diff --git a/keyboards/singa/singa.c b/keyboards/singa/singa.c index 7b60e3c29..360b214a3 100644 --- a/keyboards/singa/singa.c +++ b/keyboards/singa/singa.c | |||
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { | |||
23 | 23 | ||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | writePinHigh(D1); | ||
27 | } | 26 | } |
28 | 27 | ||
29 | bool led_update_kb(led_t led_state) { | 28 | bool led_update_kb(led_t led_state) { |
30 | if (led_update_user(led_state)) { | 29 | if (led_update_user(led_state)) { |
31 | writePin(D1, !led_state.caps_lock); | 30 | writePin(D1, led_state.caps_lock); |
32 | } | 31 | } |
33 | return true; | 32 | return true; |
34 | } | 33 | } |
diff --git a/keyboards/tgr/alice/alice.c b/keyboards/tgr/alice/alice.c index 9fb4957ac..a4a5c787c 100644 --- a/keyboards/tgr/alice/alice.c +++ b/keyboards/tgr/alice/alice.c | |||
@@ -26,16 +26,13 @@ void led_init_ports(void) { | |||
26 | setPinOutput(D0); | 26 | setPinOutput(D0); |
27 | setPinOutput(D1); | 27 | setPinOutput(D1); |
28 | setPinOutput(D6); | 28 | setPinOutput(D6); |
29 | writePinHigh(D0); | ||
30 | writePinHigh(D1); | ||
31 | writePinHigh(D6); | ||
32 | } | 29 | } |
33 | 30 | ||
34 | bool led_update_kb(led_t led_state) { | 31 | bool led_update_kb(led_t led_state) { |
35 | if (led_update_user(led_state)) { | 32 | if (led_update_user(led_state)) { |
36 | writePin(D0, !led_state.num_lock); | 33 | writePin(D0, led_state.num_lock); |
37 | writePin(D1, !led_state.caps_lock); | 34 | writePin(D1, led_state.caps_lock); |
38 | writePin(D6, !led_state.scroll_lock); | 35 | writePin(D6, led_state.scroll_lock); |
39 | } | 36 | } |
40 | return true; | 37 | return true; |
41 | } | 38 | } |
diff --git a/keyboards/tgr/jane/jane.c b/keyboards/tgr/jane/jane.c index 24183a0f7..fabdc0e90 100644 --- a/keyboards/tgr/jane/jane.c +++ b/keyboards/tgr/jane/jane.c | |||
@@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) { | |||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | setPinOutput(D6); | 26 | setPinOutput(D6); |
27 | writePinHigh(D1); | ||
28 | writePinHigh(D6); | ||
29 | } | 27 | } |
30 | 28 | ||
31 | bool led_update_kb(led_t led_state) { | 29 | bool led_update_kb(led_t led_state) { |
32 | if (led_update_user(led_state)) { | 30 | if (led_update_user(led_state)) { |
33 | writePin(D1, !led_state.caps_lock); | 31 | writePin(D1, led_state.caps_lock); |
34 | writePin(D6, !led_state.scroll_lock); | 32 | writePin(D6, led_state.scroll_lock); |
35 | } | 33 | } |
36 | return true; | 34 | return true; |
37 | } | 35 | } |
diff --git a/keyboards/unikorn/unikorn.c b/keyboards/unikorn/unikorn.c index 26a5092a5..c2c85eb98 100644 --- a/keyboards/unikorn/unikorn.c +++ b/keyboards/unikorn/unikorn.c | |||
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { | |||
23 | 23 | ||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | writePinHigh(D1); | ||
27 | } | 26 | } |
28 | 27 | ||
29 | bool led_update_kb(led_t led_state) { | 28 | bool led_update_kb(led_t led_state) { |
30 | if (led_update_user(led_state)) { | 29 | if (led_update_user(led_state)) { |
31 | writePin(D1, !led_state.caps_lock); | 30 | writePin(D1, led_state.caps_lock); |
32 | } | 31 | } |
33 | return true; | 32 | return true; |
34 | } | 33 | } |
diff --git a/keyboards/winkeyless/bface/bface.c b/keyboards/winkeyless/bface/bface.c index 49e8bbcd2..7d27096ba 100644 --- a/keyboards/winkeyless/bface/bface.c +++ b/keyboards/winkeyless/bface/bface.c | |||
@@ -25,16 +25,13 @@ void led_init_ports(void) { | |||
25 | setPinOutput(D0); | 25 | setPinOutput(D0); |
26 | setPinOutput(D1); | 26 | setPinOutput(D1); |
27 | setPinOutput(D6); | 27 | setPinOutput(D6); |
28 | writePinHigh(D0); | ||
29 | writePinHigh(D1); | ||
30 | writePinHigh(D6); | ||
31 | } | 28 | } |
32 | 29 | ||
33 | bool led_update_kb(led_t led_state) { | 30 | bool led_update_kb(led_t led_state) { |
34 | if (led_update_user(led_state)) { | 31 | if (led_update_user(led_state)) { |
35 | writePin(D0, !led_state.num_lock); | 32 | writePin(D0, led_state.num_lock); |
36 | writePin(D1, !led_state.caps_lock); | 33 | writePin(D1, led_state.caps_lock); |
37 | writePin(D6, !led_state.scroll_lock); | 34 | writePin(D6, led_state.scroll_lock); |
38 | } | 35 | } |
39 | return true; | 36 | return true; |
40 | } | 37 | } |
diff --git a/keyboards/winkeyless/bmini/bmini.c b/keyboards/winkeyless/bmini/bmini.c index fe3b74be1..6529d4403 100644 --- a/keyboards/winkeyless/bmini/bmini.c +++ b/keyboards/winkeyless/bmini/bmini.c | |||
@@ -26,16 +26,13 @@ void led_init_ports(void) { | |||
26 | setPinOutput(D0); | 26 | setPinOutput(D0); |
27 | setPinOutput(D1); | 27 | setPinOutput(D1); |
28 | setPinOutput(D6); | 28 | setPinOutput(D6); |
29 | writePinHigh(D0); | ||
30 | writePinHigh(D1); | ||
31 | writePinHigh(D6); | ||
32 | } | 29 | } |
33 | 30 | ||
34 | bool led_update_kb(led_t led_state) { | 31 | bool led_update_kb(led_t led_state) { |
35 | if (led_update_user(led_state)) { | 32 | if (led_update_user(led_state)) { |
36 | writePin(D0, !led_state.num_lock); | 33 | writePin(D0, led_state.num_lock); |
37 | writePin(D1, !led_state.caps_lock); | 34 | writePin(D1, led_state.caps_lock); |
38 | writePin(D6, !led_state.scroll_lock); | 35 | writePin(D6, led_state.scroll_lock); |
39 | } | 36 | } |
40 | return true; | 37 | return true; |
41 | } | 38 | } |
diff --git a/keyboards/winkeyless/bminiex/bminiex.c b/keyboards/winkeyless/bminiex/bminiex.c index 365aeee2b..676f88ebf 100644 --- a/keyboards/winkeyless/bminiex/bminiex.c +++ b/keyboards/winkeyless/bminiex/bminiex.c | |||
@@ -26,16 +26,13 @@ void led_init_ports(void) { | |||
26 | setPinOutput(D0); | 26 | setPinOutput(D0); |
27 | setPinOutput(D1); | 27 | setPinOutput(D1); |
28 | setPinOutput(D6); | 28 | setPinOutput(D6); |
29 | writePinHigh(D0); | ||
30 | writePinHigh(D1); | ||
31 | writePinHigh(D6); | ||
32 | } | 29 | } |
33 | 30 | ||
34 | bool led_update_kb(led_t led_state) { | 31 | bool led_update_kb(led_t led_state) { |
35 | if (led_update_user(led_state)) { | 32 | if (led_update_user(led_state)) { |
36 | writePin(D0, !led_state.num_lock); | 33 | writePin(D0, led_state.num_lock); |
37 | writePin(D1, !led_state.caps_lock); | 34 | writePin(D1, led_state.caps_lock); |
38 | writePin(D6, !led_state.scroll_lock); | 35 | writePin(D6, led_state.scroll_lock); |
39 | } | 36 | } |
40 | return true; | 37 | return true; |
41 | } | 38 | } |
diff --git a/keyboards/ymd75/ymd75.c b/keyboards/ymd75/ymd75.c index 1c5c38039..0870a6cc0 100644 --- a/keyboards/ymd75/ymd75.c +++ b/keyboards/ymd75/ymd75.c | |||
@@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { | |||
24 | 24 | ||
25 | void led_init_ports(void) { | 25 | void led_init_ports(void) { |
26 | setPinOutput(D1); | 26 | setPinOutput(D1); |
27 | writePinHigh(D1); | ||
28 | } | 27 | } |
29 | 28 | ||
30 | bool led_update_kb(led_t led_state) { | 29 | bool led_update_kb(led_t led_state) { |
31 | if (led_update_user(led_state)) { | 30 | if (led_update_user(led_state)) { |
32 | writePin(D1, !led_state.caps_lock); | 31 | writePin(D1, led_state.caps_lock); |
33 | } | 32 | } |
34 | return true; | 33 | return true; |
35 | } | 34 | } |
diff --git a/keyboards/ymd96/ymd96.c b/keyboards/ymd96/ymd96.c index c81435e45..5841decda 100644 --- a/keyboards/ymd96/ymd96.c +++ b/keyboards/ymd96/ymd96.c | |||
@@ -26,14 +26,12 @@ void keyboard_pre_init_kb(void) { | |||
26 | void led_init_ports(void) { | 26 | void led_init_ports(void) { |
27 | setPinOutput(D0); | 27 | setPinOutput(D0); |
28 | setPinOutput(D1); | 28 | setPinOutput(D1); |
29 | writePinHigh(D0); | ||
30 | writePinHigh(D1); | ||
31 | } | 29 | } |
32 | 30 | ||
33 | bool led_update_kb(led_t led_state) { | 31 | bool led_update_kb(led_t led_state) { |
34 | if (led_update_user(led_state)) { | 32 | if (led_update_user(led_state)) { |
35 | writePin(D0, !led_state.num_lock); | 33 | writePin(D0, led_state.num_lock); |
36 | writePin(D1, !led_state.caps_lock); | 34 | writePin(D1, led_state.caps_lock); |
37 | } | 35 | } |
38 | return true; | 36 | return true; |
39 | } | 37 | } |
diff --git a/keyboards/ymdk/bface/bface.c b/keyboards/ymdk/bface/bface.c index e2810409a..b35b33376 100644 --- a/keyboards/ymdk/bface/bface.c +++ b/keyboards/ymdk/bface/bface.c | |||
@@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { | |||
23 | 23 | ||
24 | void led_init_ports(void) { | 24 | void led_init_ports(void) { |
25 | setPinOutput(D1); | 25 | setPinOutput(D1); |
26 | writePinHigh(D1); | ||
27 | } | 26 | } |
28 | 27 | ||
29 | bool led_update_kb(led_t led_state) { | 28 | bool led_update_kb(led_t led_state) { |
30 | if (led_update_user(led_state)) { | 29 | if (led_update_user(led_state)) { |
31 | writePin(D1, !led_state.caps_lock); | 30 | writePin(D1, led_state.caps_lock); |
32 | } | 31 | } |
33 | return true; | 32 | return true; |
34 | } | 33 | } |
diff --git a/keyboards/ymdk_np21/ymdk_np21.c b/keyboards/ymdk_np21/ymdk_np21.c index b7c2001a4..63812c936 100644 --- a/keyboards/ymdk_np21/ymdk_np21.c +++ b/keyboards/ymdk_np21/ymdk_np21.c | |||
@@ -25,7 +25,6 @@ void keyboard_pre_init_kb(void) { | |||
25 | 25 | ||
26 | void led_init_ports(void) { | 26 | void led_init_ports(void) { |
27 | setPinOutput(D0); | 27 | setPinOutput(D0); |
28 | writePinHigh(D0); | ||
29 | } | 28 | } |
30 | 29 | ||
31 | bool led_update_kb(led_t led_state) { | 30 | bool led_update_kb(led_t led_state) { |