aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornoroadsleft <18669334+noroadsleft@users.noreply.github.com>2019-07-20 13:49:28 -0700
committerDrashna Jaelre <drashna@live.com>2019-07-20 13:49:28 -0700
commitd686c0ea43d6a9db7768da64ee54c3ba25c018f7 (patch)
tree324dfce3a93077421d703bfc04e3af81b77a8bd4
parentb3cdc7ef70dd4bbf7d458a90c75c4d72f97e340e (diff)
downloadqmk_firmware-d686c0ea43d6a9db7768da64ee54c3ba25c018f7.tar.gz
qmk_firmware-d686c0ea43d6a9db7768da64ee54c3ba25c018f7.zip
[Keyboard] Snagpad Configurator bugfix and readme refactor (#6381)
* Update snagpad.h White-space changes only. Making this file easier to read. * Update info.json Refactor: - add labels - debug linting (one key object per line) - reorder keys for LAYOUT_numpad_5x4 (fixes QMK Configurator assigning keys to incorrect positions) * Update readme.md Refactor to conform to QMK template. Updated link to The Board Podcast (old link was Error 404).
-rw-r--r--keyboards/snagpad/info.json49
-rw-r--r--keyboards/snagpad/readme.md24
-rw-r--r--keyboards/snagpad/snagpad.h40
3 files changed, 76 insertions, 37 deletions
diff --git a/keyboards/snagpad/info.json b/keyboards/snagpad/info.json
index f6b19ee81..6e3ab601a 100644
--- a/keyboards/snagpad/info.json
+++ b/keyboards/snagpad/info.json
@@ -7,11 +7,50 @@
7 "height": 5, 7 "height": 5,
8 "layouts": { 8 "layouts": {
9 9
10 "LAYOUT_ortho_5x4": { 10 "LAYOUT_ortho_5x4": {
11 "layout": [{"x":0, "y":0}, {"x":1, "y":0}, {"x":2, "y":0}, {"x":3, "y":0}, {"x":0, "y":1}, {"x":1, "y":1}, {"x":2, "y":1}, {"x":3, "y":1}, {"x":0, "y":2}, {"x":1, "y":2}, {"x":2, "y":2}, {"x":3, "y":2}, {"x":0, "y":3}, {"x":1, "y":3}, {"x":2, "y":3}, {"x":3, "y":3}, {"x":0, "y":4}, {"x":1, "y":4}, {"x":2, "y":4}, {"x":3, "y":4}] 11 "layout": [
12 }, 12 {"label":"Num Lock", "x":0, "y":0},
13 {"label":"/", "x":1, "y":0},
14 {"label":"*", "x":2, "y":0},
15 {"label":"-", "x":3, "y":0},
16 {"label":"7", "x":0, "y":1},
17 {"label":"8", "x":1, "y":1},
18 {"label":"9", "x":2, "y":1},
19 {"label":"+", "x":3, "y":1},
20 {"label":"4", "x":0, "y":2},
21 {"label":"5", "x":1, "y":2},
22 {"label":"6", "x":2, "y":2},
23 {"label":"+", "x":3, "y":2},
24 {"label":"1", "x":0, "y":3},
25 {"label":"2", "x":1, "y":3},
26 {"label":"3", "x":2, "y":3},
27 {"label":"Enter", "x":3, "y":3},
28 {"label":"0", "x":0, "y":4},
29 {"label":"0", "x":1, "y":4},
30 {"label":".", "x":2, "y":4},
31 {"label":"Enter", "x":3, "y":4}
32 ]
33 },
13 "LAYOUT_numpad_5x4": { 34 "LAYOUT_numpad_5x4": {
14 "layout": [{"x":0, "y":0}, {"x":1, "y":0}, {"x":2, "y":0}, {"x":3, "y":0}, {"x":0, "y":1}, {"x":1, "y":1}, {"x":2, "y":1}, {"x":3, "y":1, "h":2}, {"x":0, "y":2}, {"x":1, "y":2}, {"x":2, "y":2}, {"x":0, "y":3}, {"x":1, "y":3}, {"x":2, "y":3}, {"x":3, "y":3, "h":2}, {"x":0, "y":4, "w":2}, {"x":2, "y":4}] 35 "layout": [
15 } 36 {"label":"Num Lock", "x":0, "y":0},
37 {"label":"/", "x":1, "y":0},
38 {"label":"*", "x":2, "y":0},
39 {"label":"-", "x":3, "y":0},
40 {"label":"7", "x":0, "y":1},
41 {"label":"8", "x":1, "y":1},
42 {"label":"9", "x":2, "y":1},
43 {"label":"4", "x":0, "y":2},
44 {"label":"5", "x":1, "y":2},
45 {"label":"6", "x":2, "y":2},
46 {"label":"+", "x":3, "y":1, "h":2},
47 {"label":"1", "x":0, "y":3},
48 {"label":"2", "x":1, "y":3},
49 {"label":"3", "x":2, "y":3},
50 {"label":"0", "x":0, "y":4, "w":2},
51 {"label":".", "x":2, "y":4},
52 {"label":"Enter", "x":3, "y":3, "h":2}
53 ]
54 }
16 } 55 }
17} 56}
diff --git a/keyboards/snagpad/readme.md b/keyboards/snagpad/readme.md
index eeafceba9..b59bd7588 100644
--- a/keyboards/snagpad/readme.md
+++ b/keyboards/snagpad/readme.md
@@ -1,21 +1,21 @@
1# Snagpad 1# Snagpad
2QMK for Snagpad
3 2
4This PCB can be used as a standard numpad, or a ortho 5x4 macropad. 3A five-row PCB that can be built as a standard numpad or an ortholinear 5x4 macropad. Can be built as single PCB with custom case, or as two PCB style with standoffs. Requires a Pro Micro.
5 4
6For QMK Configurator, the info.json is utilised. 5Keyboard Maintainer: [Flehrad](https://github.com/flehrad)
7- For 2U keys on numpad, the first 1u row/column key assignment is the same as the 2u position. 6Hardware Supported: Snagpad PCB, Pro Micro
7Hardware Availability: [GitHub](https://github.com/flehrad/Snagpad)
8 8
9Build requires a pro micro. 9Make example for this keyboard (after setting up your build environment):
10 10
11Can be built as single PCB with custom case, or as two PCB style with standoffs. 11 make snagpad:default
12 12
13If you like this simple PCB and want to make a donation, you can at https://paypal.me/theboardpodcast 13See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).
14 14
15Check out our: 15If you like this simple PCB and want to make a donation, you can do so at https://paypal.me/theboardpodcast.
16
17YouTube (https://www.youtube.com/channel/UCg98oJZNffR9nDLJNkorjqw)
18 16
19Podcast (www.libsyn.com/theboardpodcast) 17Check out our:
20 18
21Patreon (www.patreon.com/theboardpodcast) 19- [YouTube](https://www.youtube.com/channel/UCg98oJZNffR9nDLJNkorjqw)
20- [Podcast](https://podcasts.apple.com/au/podcast/theboard-mechanical-keyboard/id1147089749?mt=2)
21- [Patreon](https://www.patreon.com/theboardpodcast)
diff --git a/keyboards/snagpad/snagpad.h b/keyboards/snagpad/snagpad.h
index d6a62ddf7..f1e5e34e6 100644
--- a/keyboards/snagpad/snagpad.h
+++ b/keyboards/snagpad/snagpad.h
@@ -3,28 +3,28 @@
3#include "quantum.h" 3#include "quantum.h"
4 4
5#define LAYOUT_ortho_5x4( \ 5#define LAYOUT_ortho_5x4( \
6 K00, K01, K02, K03, \ 6 K00, K01, K02, K03, \
7 K10, K11, K12, K13, \ 7 K10, K11, K12, K13, \
8 K20, K21, K22, K23, \ 8 K20, K21, K22, K23, \
9 K30, K31, K32, K33, \ 9 K30, K31, K32, K33, \
10 K40, K41, K42, K43 \ 10 K40, K41, K42, K43 \
11) { \ 11) { \
12 { K00, K01, K02, K03 }, \ 12 { K00, K01, K02, K03 }, \
13 { K10, K11, K12, K13 }, \ 13 { K10, K11, K12, K13 }, \
14 { K20, K21, K22, K23 }, \ 14 { K20, K21, K22, K23 }, \
15 { K30, K31, K32, K33 }, \ 15 { K30, K31, K32, K33 }, \
16 { K40, K41, K42, K43 } \ 16 { K40, K41, K42, K43 } \
17} 17}
18#define LAYOUT_numpad_5x4( \ 18#define LAYOUT_numpad_5x4( \
19 K00, K01, K02, K03, \ 19 K00, K01, K02, K03, \
20 K10, K11, K12, \ 20 K10, K11, K12, \
21 K20, K21, K22, K13, \ 21 K20, K21, K22, K13, \
22 K30, K31, K32, \ 22 K30, K31, K32, \
23 K40, K42, K33 \ 23 K40, K42, K33 \
24) { \ 24) { \
25 { K00, K01, K02, K03 }, \ 25 { K00, K01, K02, K03 }, \
26 { K10, K11, K12, K13 }, \ 26 { K10, K11, K12, K13 }, \
27 { K20, K21, K22, KC_NO }, \ 27 { K20, K21, K22, KC_NO }, \
28 { K30, K31, K32, K33 }, \ 28 { K30, K31, K32, K33 }, \
29 { K40, KC_NO, K42, KC_NO } \ 29 { K40, KC_NO, K42, KC_NO } \
30} 30}