diff options
| author | Joel Challis <git@zvecr.com> | 2020-11-16 03:16:42 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-16 14:16:42 +1100 |
| commit | 94e94ffb5bbe61b5da4aad205016923746010b23 (patch) | |
| tree | 023656aea94e118551bc4e991a3f5dd272db04da /docs/pr_checklist.md | |
| parent | cfc9a358c584e65782b2dade05d31700719a18e7 (diff) | |
| download | qmk_firmware-94e94ffb5bbe61b5da4aad205016923746010b23.tar.gz qmk_firmware-94e94ffb5bbe61b5da4aad205016923746010b23.zip | |
Recommend use of LED Indicator config (#10895)
* Recommend use of LED Indicator config
* Recommend use of LED Indicator config - update link
* Update quantum/template/ps2avrgb/config.h
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Diffstat (limited to 'docs/pr_checklist.md')
| -rw-r--r-- | docs/pr_checklist.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index 22e8a3fe1..e0dd0770c 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md | |||
| @@ -73,6 +73,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard | |||
| 73 | - commented-out functions removed too | 73 | - commented-out functions removed too |
| 74 | - `matrix_init_board()` etc. migrated to `keyboard_pre_init_kb()`, see: [keyboard_pre_init*](https://docs.qmk.fm/#/custom_quantum_functions?id=keyboard_pre_init_-function-documentation) | 74 | - `matrix_init_board()` etc. migrated to `keyboard_pre_init_kb()`, see: [keyboard_pre_init*](https://docs.qmk.fm/#/custom_quantum_functions?id=keyboard_pre_init_-function-documentation) |
| 75 | - prefer `CUSTOM_MATRIX = lite` if custom matrix used, allows for standard debounce, see [custom matrix 'lite'](https://docs.qmk.fm/#/custom_matrix?id=lite) | 75 | - prefer `CUSTOM_MATRIX = lite` if custom matrix used, allows for standard debounce, see [custom matrix 'lite'](https://docs.qmk.fm/#/custom_matrix?id=lite) |
| 76 | - prefer LED indicator [Configuration Options](https://docs.qmk.fm/#/feature_led_indicators?id=configuration-options) to custom `led_update_*()` implementations where possible | ||
| 76 | - `keyboard.h` | 77 | - `keyboard.h` |
| 77 | - `#include "quantum.h"` appears at the top | 78 | - `#include "quantum.h"` appears at the top |
| 78 | - `LAYOUT` macros should use standard definitions if applicable | 79 | - `LAYOUT` macros should use standard definitions if applicable |