diff options
author | Drashna Jaelre <drashna@live.com> | 2019-01-26 15:49:45 -0800 |
---|---|---|
committer | MechMerlin <30334081+mechmerlin@users.noreply.github.com> | 2019-01-26 15:49:45 -0800 |
commit | b05c0e46c6c62972b68518635104fb58927d1a13 (patch) | |
tree | 4037e0ff8b7d52aee235e9a7e31083984b453777 /keyboards/duck | |
parent | 478538e0d9938952568c62d135166d2cba15a70c (diff) | |
download | qmk_firmware-b05c0e46c6c62972b68518635104fb58927d1a13.tar.gz qmk_firmware-b05c0e46c6c62972b68518635104fb58927d1a13.zip |
Adds a default value for IS_COMMAND for COMMAND feature (#4301)
* Add default value for IS_COMMAND for COMMAND feature
* Cleanup and consistency
* Update Templates to reflect change
* Fix IS_COMMAND in template
* Fix IS_COMMAND define
* Use consistent IS_COMMAND block in templates
* Remove unnecessary `#undef IS_COMMAND` directives
* Fix compile issue on orthodox
* Reomve IS_COMMAND option for newer boards
* Remove all existing definitions of IS_COMMAND if they use default LSHIFT and RSHIFT setting
* Remove a couple of additional IS_COMMAND defines
* Remove remaining redundant IS_COMMAND definitions
* Remove #undef IS_COMMAND from orthodox:drashna and whitefox:konstantin
* Remove multiple empty lines in modified config.h files
* Update additional boards
* Reomve IS_COMMAND from newer boards
* Update Alice keyboard
* Remove IS_COMMAND from additional boards
Jan 24th edition
Diffstat (limited to 'keyboards/duck')
-rw-r--r-- | keyboards/duck/eagle_viper/v2/config.h | 5 | ||||
-rw-r--r-- | keyboards/duck/jetfire/config.h | 8 | ||||
-rw-r--r-- | keyboards/duck/lightsaver/config.h | 5 | ||||
-rw-r--r-- | keyboards/duck/octagon/v1/config.h | 5 | ||||
-rw-r--r-- | keyboards/duck/octagon/v2/config.h | 5 |
5 files changed, 0 insertions, 28 deletions
diff --git a/keyboards/duck/eagle_viper/v2/config.h b/keyboards/duck/eagle_viper/v2/config.h index 9c49344ff..f454b2e0e 100644 --- a/keyboards/duck/eagle_viper/v2/config.h +++ b/keyboards/duck/eagle_viper/v2/config.h | |||
@@ -40,11 +40,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
40 | /* number of backlight levels */ | 40 | /* number of backlight levels */ |
41 | #define BACKLIGHT_LEVELS 3 | 41 | #define BACKLIGHT_LEVELS 3 |
42 | 42 | ||
43 | /* key combination for magic key command */ | ||
44 | #define IS_COMMAND() ( \ | ||
45 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
46 | ) | ||
47 | |||
48 | #define RGBLIGHT_ANIMATIONS | 43 | #define RGBLIGHT_ANIMATIONS |
49 | #define RGB_DI_PIN D6 | 44 | #define RGB_DI_PIN D6 |
50 | #define RGBLED_NUM 17 | 45 | #define RGBLED_NUM 17 |
diff --git a/keyboards/duck/jetfire/config.h b/keyboards/duck/jetfire/config.h index 54c5321c6..f49a29888 100644 --- a/keyboards/duck/jetfire/config.h +++ b/keyboards/duck/jetfire/config.h | |||
@@ -34,7 +34,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
34 | /* COL2ROW, ROW2COL, or CUSTOM_MATRIX */ | 34 | /* COL2ROW, ROW2COL, or CUSTOM_MATRIX */ |
35 | #define DIODE_DIRECTION COL2ROW | 35 | #define DIODE_DIRECTION COL2ROW |
36 | 36 | ||
37 | |||
38 | #define BACKLIGHT_LEVELS 1 | 37 | #define BACKLIGHT_LEVELS 1 |
39 | 38 | ||
40 | #define RGB_DI_PIN D6 | 39 | #define RGB_DI_PIN D6 |
@@ -49,7 +48,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
49 | /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ | 48 | /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ |
50 | #define DEBOUNCING_DELAY 5 | 49 | #define DEBOUNCING_DELAY 5 |
51 | 50 | ||
52 | |||
53 | /* If defined, GRAVE_ESC will always act as ESC when CTRL is held. | 51 | /* If defined, GRAVE_ESC will always act as ESC when CTRL is held. |
54 | * This is userful for the Windows task manager shortcut (ctrl+shift+esc). | 52 | * This is userful for the Windows task manager shortcut (ctrl+shift+esc). |
55 | */ | 53 | */ |
@@ -88,11 +86,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
88 | * | 86 | * |
89 | */ | 87 | */ |
90 | 88 | ||
91 | /* key combination for magic key command */ | ||
92 | #define IS_COMMAND() ( \ | ||
93 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
94 | ) | ||
95 | |||
96 | /* control how magic key switches layers */ | 89 | /* control how magic key switches layers */ |
97 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true | 90 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true |
98 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true | 91 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true |
@@ -197,4 +190,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
197 | #define LCD_E_PIN 1 //< pin for Enable line | 190 | #define LCD_E_PIN 1 //< pin for Enable line |
198 | #endif | 191 | #endif |
199 | */ | 192 | */ |
200 | |||
diff --git a/keyboards/duck/lightsaver/config.h b/keyboards/duck/lightsaver/config.h index 745af4330..9e3a08fbd 100644 --- a/keyboards/duck/lightsaver/config.h +++ b/keyboards/duck/lightsaver/config.h | |||
@@ -40,11 +40,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
40 | /* number of backlight levels */ | 40 | /* number of backlight levels */ |
41 | #define BACKLIGHT_LEVELS 1 | 41 | #define BACKLIGHT_LEVELS 1 |
42 | 42 | ||
43 | /* key combination for magic key command */ | ||
44 | #define IS_COMMAND() ( \ | ||
45 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
46 | ) | ||
47 | |||
48 | #define RGBLIGHT_ANIMATIONS | 43 | #define RGBLIGHT_ANIMATIONS |
49 | #define RGB_DI_PIN D6 | 44 | #define RGB_DI_PIN D6 |
50 | #define RGBLED_NUM 17 | 45 | #define RGBLED_NUM 17 |
diff --git a/keyboards/duck/octagon/v1/config.h b/keyboards/duck/octagon/v1/config.h index a2b3d6413..5400c53ef 100644 --- a/keyboards/duck/octagon/v1/config.h +++ b/keyboards/duck/octagon/v1/config.h | |||
@@ -40,11 +40,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
40 | /* number of backlight levels */ | 40 | /* number of backlight levels */ |
41 | #define BACKLIGHT_LEVELS 1 | 41 | #define BACKLIGHT_LEVELS 1 |
42 | 42 | ||
43 | /* key combination for magic key command */ | ||
44 | #define IS_COMMAND() ( \ | ||
45 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
46 | ) | ||
47 | |||
48 | #define RGBLIGHT_ANIMATIONS | 43 | #define RGBLIGHT_ANIMATIONS |
49 | #define RGB_DI_PIN D6 | 44 | #define RGB_DI_PIN D6 |
50 | #define RGBLED_NUM 17 | 45 | #define RGBLED_NUM 17 |
diff --git a/keyboards/duck/octagon/v2/config.h b/keyboards/duck/octagon/v2/config.h index 7adcb2760..78d18d3bb 100644 --- a/keyboards/duck/octagon/v2/config.h +++ b/keyboards/duck/octagon/v2/config.h | |||
@@ -40,11 +40,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
40 | /* number of backlight levels */ | 40 | /* number of backlight levels */ |
41 | #define BACKLIGHT_LEVELS 1 | 41 | #define BACKLIGHT_LEVELS 1 |
42 | 42 | ||
43 | /* key combination for magic key command */ | ||
44 | #define IS_COMMAND() ( \ | ||
45 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
46 | ) | ||
47 | |||
48 | #define RGBLIGHT_ANIMATIONS | 43 | #define RGBLIGHT_ANIMATIONS |
49 | #define RGB_DI_PIN D6 | 44 | #define RGB_DI_PIN D6 |
50 | #define RGBLED_NUM 17 | 45 | #define RGBLED_NUM 17 |