diff options
| author | Joel Challis <git@zvecr.com> | 2020-01-30 23:44:40 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-31 10:44:40 +1100 |
| commit | 4139de3cc9c56a157d78e1e418893d08e3f23bde (patch) | |
| tree | c1822b9710b9bfeef43c10fc4a49d24050744558 /keyboards/duck | |
| parent | 7514f5124ac81ce1db51eb07a287f82d6a9bf10c (diff) | |
| download | qmk_firmware-4139de3cc9c56a157d78e1e418893d08e3f23bde.tar.gz qmk_firmware-4139de3cc9c56a157d78e1e418893d08e3f23bde.zip | |
Fix AVR boards which were overriding backlight without setting… (#8044)
* Add backlight custom driver to all boards not declaring it but overriding backlight
* Apply suggestions from code review
Co-Authored-By: fauxpark <fauxpark@gmail.com>
* Apply suggestions from code review
Co-Authored-By: fauxpark <fauxpark@gmail.com>
* Remove old tmk references from show_options.mk
Co-authored-by: fauxpark <fauxpark@gmail.com>
Diffstat (limited to 'keyboards/duck')
| -rw-r--r-- | keyboards/duck/eagle_viper/v2/rules.mk | 3 | ||||
| -rw-r--r-- | keyboards/duck/jetfire/rules.mk | 3 | ||||
| -rw-r--r-- | keyboards/duck/lightsaver/rules.mk | 3 | ||||
| -rw-r--r-- | keyboards/duck/octagon/v1/rules.mk | 3 | ||||
| -rw-r--r-- | keyboards/duck/octagon/v2/rules.mk | 3 | ||||
| -rw-r--r-- | keyboards/duck/orion/v3/rules.mk | 3 |
6 files changed, 12 insertions, 6 deletions
diff --git a/keyboards/duck/eagle_viper/v2/rules.mk b/keyboards/duck/eagle_viper/v2/rules.mk index 71d318946..a8c804e52 100644 --- a/keyboards/duck/eagle_viper/v2/rules.mk +++ b/keyboards/duck/eagle_viper/v2/rules.mk | |||
| @@ -23,7 +23,8 @@ COMMAND_ENABLE = yes # Commands for debug and configuration | |||
| 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend |
| 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
| 25 | NKRO_ENABLE = yes # USB Nkey Rollover | 25 | NKRO_ENABLE = yes # USB Nkey Rollover |
| 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default | 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 27 | BACKLIGHT_DRIVER = custom | ||
| 27 | MIDI_ENABLE = no # MIDI support | 28 | MIDI_ENABLE = no # MIDI support |
| 28 | UNICODE_ENABLE = no # Unicode | 29 | UNICODE_ENABLE = no # Unicode |
| 29 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 30 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
diff --git a/keyboards/duck/jetfire/rules.mk b/keyboards/duck/jetfire/rules.mk index b51285bd4..09a5d1ecc 100644 --- a/keyboards/duck/jetfire/rules.mk +++ b/keyboards/duck/jetfire/rules.mk | |||
| @@ -23,7 +23,8 @@ COMMAND_ENABLE = yes # Commands for debug and configuration | |||
| 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend |
| 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
| 25 | NKRO_ENABLE = no # USB Nkey Rollover | 25 | NKRO_ENABLE = no # USB Nkey Rollover |
| 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default | 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 27 | BACKLIGHT_DRIVER = custom | ||
| 27 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow | 28 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow |
| 28 | MIDI_ENABLE = no # MIDI support | 29 | MIDI_ENABLE = no # MIDI support |
| 29 | UNICODE_ENABLE = no # Unicode | 30 | UNICODE_ENABLE = no # Unicode |
diff --git a/keyboards/duck/lightsaver/rules.mk b/keyboards/duck/lightsaver/rules.mk index 8f2589139..64e18c9b1 100644 --- a/keyboards/duck/lightsaver/rules.mk +++ b/keyboards/duck/lightsaver/rules.mk | |||
| @@ -23,7 +23,8 @@ COMMAND_ENABLE = yes # Commands for debug and configuration | |||
| 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend |
| 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
| 25 | NKRO_ENABLE = yes # USB Nkey Rollover | 25 | NKRO_ENABLE = yes # USB Nkey Rollover |
| 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default | 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 27 | BACKLIGHT_DRIVER = custom | ||
| 27 | MIDI_ENABLE = no # MIDI support | 28 | MIDI_ENABLE = no # MIDI support |
| 28 | UNICODE_ENABLE = no # Unicode | 29 | UNICODE_ENABLE = no # Unicode |
| 29 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 30 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
diff --git a/keyboards/duck/octagon/v1/rules.mk b/keyboards/duck/octagon/v1/rules.mk index a750a8f00..4a8191fa6 100644 --- a/keyboards/duck/octagon/v1/rules.mk +++ b/keyboards/duck/octagon/v1/rules.mk | |||
| @@ -23,7 +23,8 @@ COMMAND_ENABLE = yes # Commands for debug and configuration | |||
| 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend |
| 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
| 25 | NKRO_ENABLE = yes # USB Nkey Rollover | 25 | NKRO_ENABLE = yes # USB Nkey Rollover |
| 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default | 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 27 | BACKLIGHT_DRIVER = custom | ||
| 27 | MIDI_ENABLE = no # MIDI support | 28 | MIDI_ENABLE = no # MIDI support |
| 28 | UNICODE_ENABLE = no # Unicode | 29 | UNICODE_ENABLE = no # Unicode |
| 29 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 30 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
diff --git a/keyboards/duck/octagon/v2/rules.mk b/keyboards/duck/octagon/v2/rules.mk index 0b2b12444..49f3f12f5 100644 --- a/keyboards/duck/octagon/v2/rules.mk +++ b/keyboards/duck/octagon/v2/rules.mk | |||
| @@ -23,7 +23,8 @@ COMMAND_ENABLE = yes # Commands for debug and configuration | |||
| 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend |
| 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
| 25 | NKRO_ENABLE = yes # USB Nkey Rollover | 25 | NKRO_ENABLE = yes # USB Nkey Rollover |
| 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default | 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 27 | BACKLIGHT_DRIVER = custom | ||
| 27 | MIDI_ENABLE = no # MIDI support | 28 | MIDI_ENABLE = no # MIDI support |
| 28 | UNICODE_ENABLE = no # Unicode | 29 | UNICODE_ENABLE = no # Unicode |
| 29 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 30 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
diff --git a/keyboards/duck/orion/v3/rules.mk b/keyboards/duck/orion/v3/rules.mk index 7463d7da4..019dd7dd3 100644 --- a/keyboards/duck/orion/v3/rules.mk +++ b/keyboards/duck/orion/v3/rules.mk | |||
| @@ -23,7 +23,8 @@ COMMAND_ENABLE = yes # Commands for debug and configuration | |||
| 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend |
| 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
| 25 | NKRO_ENABLE = yes # USB Nkey Rollover | 25 | NKRO_ENABLE = yes # USB Nkey Rollover |
| 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default | 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
| 27 | BACKLIGHT_DRIVER = custom | ||
| 27 | MIDI_ENABLE = no # MIDI support | 28 | MIDI_ENABLE = no # MIDI support |
| 28 | UNICODE_ENABLE = no # Unicode | 29 | UNICODE_ENABLE = no # Unicode |
| 29 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 30 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
