diff options
| author | Drashna Jaelre <drashna@live.com> | 2019-01-26 15:49:45 -0800 |
|---|---|---|
| committer | MechMerlin <30334081+mechmerlin@users.noreply.github.com> | 2019-01-26 15:49:45 -0800 |
| commit | b05c0e46c6c62972b68518635104fb58927d1a13 (patch) | |
| tree | 4037e0ff8b7d52aee235e9a7e31083984b453777 /keyboards/ergodash | |
| parent | 478538e0d9938952568c62d135166d2cba15a70c (diff) | |
| download | qmk_firmware-b05c0e46c6c62972b68518635104fb58927d1a13.tar.gz qmk_firmware-b05c0e46c6c62972b68518635104fb58927d1a13.zip | |
Adds a default value for IS_COMMAND for COMMAND feature (#4301)
* Add default value for IS_COMMAND for COMMAND feature
* Cleanup and consistency
* Update Templates to reflect change
* Fix IS_COMMAND in template
* Fix IS_COMMAND define
* Use consistent IS_COMMAND block in templates
* Remove unnecessary `#undef IS_COMMAND` directives
* Fix compile issue on orthodox
* Reomve IS_COMMAND option for newer boards
* Remove all existing definitions of IS_COMMAND if they use default LSHIFT and RSHIFT setting
* Remove a couple of additional IS_COMMAND defines
* Remove remaining redundant IS_COMMAND definitions
* Remove #undef IS_COMMAND from orthodox:drashna and whitefox:konstantin
* Remove multiple empty lines in modified config.h files
* Update additional boards
* Reomve IS_COMMAND from newer boards
* Update Alice keyboard
* Remove IS_COMMAND from additional boards
Jan 24th edition
Diffstat (limited to 'keyboards/ergodash')
| -rw-r--r-- | keyboards/ergodash/mini/config.h | 5 | ||||
| -rw-r--r-- | keyboards/ergodash/rev1/config.h | 6 | ||||
| -rw-r--r-- | keyboards/ergodash/rev2/config.h | 6 |
3 files changed, 0 insertions, 17 deletions
diff --git a/keyboards/ergodash/mini/config.h b/keyboards/ergodash/mini/config.h index 11cff145e..fc63cc1e9 100644 --- a/keyboards/ergodash/mini/config.h +++ b/keyboards/ergodash/mini/config.h | |||
| @@ -66,11 +66,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 66 | /* Locking resynchronize hack */ | 66 | /* Locking resynchronize hack */ |
| 67 | #define LOCKING_RESYNC_ENABLE | 67 | #define LOCKING_RESYNC_ENABLE |
| 68 | 68 | ||
| 69 | /* key combination for command */ | ||
| 70 | #define IS_COMMAND() ( \ | ||
| 71 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 72 | ) | ||
| 73 | |||
| 74 | /* ws2812 RGB LED */ | 69 | /* ws2812 RGB LED */ |
| 75 | #define RGB_DI_PIN D3 | 70 | #define RGB_DI_PIN D3 |
| 76 | 71 | ||
diff --git a/keyboards/ergodash/rev1/config.h b/keyboards/ergodash/rev1/config.h index d3f3314ee..160e70362 100644 --- a/keyboards/ergodash/rev1/config.h +++ b/keyboards/ergodash/rev1/config.h | |||
| @@ -56,11 +56,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 56 | /* Locking resynchronize hack */ | 56 | /* Locking resynchronize hack */ |
| 57 | #define LOCKING_RESYNC_ENABLE | 57 | #define LOCKING_RESYNC_ENABLE |
| 58 | 58 | ||
| 59 | /* key combination for command */ | ||
| 60 | #define IS_COMMAND() ( \ | ||
| 61 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 62 | ) | ||
| 63 | |||
| 64 | /* ws2812 RGB LED */ | 59 | /* ws2812 RGB LED */ |
| 65 | #define RGB_DI_PIN D3 | 60 | #define RGB_DI_PIN D3 |
| 66 | 61 | ||
| @@ -84,5 +79,4 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 84 | //#define NO_ACTION_MACRO | 79 | //#define NO_ACTION_MACRO |
| 85 | //#define NO_ACTION_FUNCTION | 80 | //#define NO_ACTION_FUNCTION |
| 86 | 81 | ||
| 87 | |||
| 88 | #endif | 82 | #endif |
diff --git a/keyboards/ergodash/rev2/config.h b/keyboards/ergodash/rev2/config.h index 5f9c68991..09657250b 100644 --- a/keyboards/ergodash/rev2/config.h +++ b/keyboards/ergodash/rev2/config.h | |||
| @@ -63,11 +63,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 63 | /* Locking resynchronize hack */ | 63 | /* Locking resynchronize hack */ |
| 64 | #define LOCKING_RESYNC_ENABLE | 64 | #define LOCKING_RESYNC_ENABLE |
| 65 | 65 | ||
| 66 | /* key combination for command */ | ||
| 67 | #define IS_COMMAND() ( \ | ||
| 68 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 69 | ) | ||
| 70 | |||
| 71 | /* ws2812 RGB LED */ | 66 | /* ws2812 RGB LED */ |
| 72 | #define RGB_DI_PIN D3 | 67 | #define RGB_DI_PIN D3 |
| 73 | 68 | ||
| @@ -91,5 +86,4 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 91 | //#define NO_ACTION_MACRO | 86 | //#define NO_ACTION_MACRO |
| 92 | //#define NO_ACTION_FUNCTION | 87 | //#define NO_ACTION_FUNCTION |
| 93 | 88 | ||
| 94 | |||
| 95 | #endif | 89 | #endif |
