diff options
author | James Young <18669334+noroadsleft@users.noreply.github.com> | 2021-08-15 20:51:13 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-08-16 06:51:13 +1000 |
commit | 4b453dca92f87899d98b5340b16677bd78a52beb (patch) | |
tree | a40b8e53964520762946e0c63bfc0a83cb2a3428 /keyboards/halberd | |
parent | fd340f8957055d74b26a5ddc490253fcc8a3a2f7 (diff) | |
download | qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.tar.gz qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.zip |
Remove MIDI Configuration boilerplate (#11151)
* remove keyboard-level instances of `MIDI_ENABLE = no`
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} +
```
Co-Authored-By: Nick Brassel <nick@tzarc.org>
* fix case-sensitivity issues on MIDI_ENABLE
Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} +
```
* replace `# MIDI controls` with `# MIDI support`
Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} +
```
* align inline comments
Aligns the inline comments to the length used by the QMK AVR rules.mk template.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} +
```
* remove commented instances of `MIDI_ENABLE` from keyboard `rules.mk` files
Commands:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} +
```
* remove MIDI configuration boilerplate from keyboard config.h files
Co-authored-by: Nick Brassel <nick@tzarc.org>
Diffstat (limited to 'keyboards/halberd')
-rw-r--r-- | keyboards/halberd/config.h | 20 | ||||
-rw-r--r-- | keyboards/halberd/rules.mk | 1 |
2 files changed, 0 insertions, 21 deletions
diff --git a/keyboards/halberd/config.h b/keyboards/halberd/config.h index d21e9bb52..f56b99d2c 100644 --- a/keyboards/halberd/config.h +++ b/keyboards/halberd/config.h | |||
@@ -164,26 +164,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
164 | //#define NO_ACTION_MACRO | 164 | //#define NO_ACTION_MACRO |
165 | //#define NO_ACTION_FUNCTION | 165 | //#define NO_ACTION_FUNCTION |
166 | 166 | ||
167 | /* | ||
168 | * MIDI options | ||
169 | */ | ||
170 | |||
171 | /* enable basic MIDI features: | ||
172 | - MIDI notes can be sent when in Music mode is on | ||
173 | */ | ||
174 | //#define MIDI_BASIC | ||
175 | |||
176 | /* enable advanced MIDI features: | ||
177 | - MIDI notes can be added to the keymap | ||
178 | - Octave shift and transpose | ||
179 | - Virtual sustain, portamento, and modulation wheel | ||
180 | - etc. | ||
181 | */ | ||
182 | //#define MIDI_ADVANCED | ||
183 | |||
184 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
185 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
186 | |||
187 | /* Bootmagic Lite key configuration */ | 167 | /* Bootmagic Lite key configuration */ |
188 | // #define BOOTMAGIC_LITE_ROW 0 | 168 | // #define BOOTMAGIC_LITE_ROW 0 |
189 | // #define BOOTMAGIC_LITE_COLUMN 0 | 169 | // #define BOOTMAGIC_LITE_COLUMN 0 |
diff --git a/keyboards/halberd/rules.mk b/keyboards/halberd/rules.mk index 4940e8d5b..35b1a6d97 100644 --- a/keyboards/halberd/rules.mk +++ b/keyboards/halberd/rules.mk | |||
@@ -25,7 +25,6 @@ SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | |||
25 | NKRO_ENABLE = no # USB Nkey Rollover | 25 | NKRO_ENABLE = no # USB Nkey Rollover |
26 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality on B7 by default | 26 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality on B7 by default |
27 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow | 27 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow |
28 | MIDI_ENABLE = no # MIDI support | ||
29 | UNICODE_ENABLE = no # Unicode | 28 | UNICODE_ENABLE = no # Unicode |
30 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 29 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
31 | AUDIO_ENABLE = no # Audio output on port C6 | 30 | AUDIO_ENABLE = no # Audio output on port C6 |