diff options
author | James Young <18669334+noroadsleft@users.noreply.github.com> | 2021-08-15 20:51:13 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-08-16 06:51:13 +1000 |
commit | 4b453dca92f87899d98b5340b16677bd78a52beb (patch) | |
tree | a40b8e53964520762946e0c63bfc0a83cb2a3428 /keyboards/qwertyydox | |
parent | fd340f8957055d74b26a5ddc490253fcc8a3a2f7 (diff) | |
download | qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.tar.gz qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.zip |
Remove MIDI Configuration boilerplate (#11151)
* remove keyboard-level instances of `MIDI_ENABLE = no`
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} +
```
Co-Authored-By: Nick Brassel <nick@tzarc.org>
* fix case-sensitivity issues on MIDI_ENABLE
Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} +
```
* replace `# MIDI controls` with `# MIDI support`
Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} +
```
* align inline comments
Aligns the inline comments to the length used by the QMK AVR rules.mk template.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} +
```
* remove commented instances of `MIDI_ENABLE` from keyboard `rules.mk` files
Commands:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} +
```
* remove MIDI configuration boilerplate from keyboard config.h files
Co-authored-by: Nick Brassel <nick@tzarc.org>
Diffstat (limited to 'keyboards/qwertyydox')
-rw-r--r-- | keyboards/qwertyydox/config.h | 20 | ||||
-rw-r--r-- | keyboards/qwertyydox/rules.mk | 1 |
2 files changed, 0 insertions, 21 deletions
diff --git a/keyboards/qwertyydox/config.h b/keyboards/qwertyydox/config.h index 386a1fae9..cc77cf9c1 100644 --- a/keyboards/qwertyydox/config.h +++ b/keyboards/qwertyydox/config.h | |||
@@ -200,26 +200,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
200 | //#define NO_ACTION_MACRO | 200 | //#define NO_ACTION_MACRO |
201 | //#define NO_ACTION_FUNCTION | 201 | //#define NO_ACTION_FUNCTION |
202 | 202 | ||
203 | /* | ||
204 | * MIDI options | ||
205 | */ | ||
206 | |||
207 | /* enable basic MIDI features: | ||
208 | - MIDI notes can be sent when in Music mode is on | ||
209 | */ | ||
210 | //#define MIDI_BASIC | ||
211 | |||
212 | /* enable advanced MIDI features: | ||
213 | - MIDI notes can be added to the keymap | ||
214 | - Octave shift and transpose | ||
215 | - Virtual sustain, portamento, and modulation wheel | ||
216 | - etc. | ||
217 | */ | ||
218 | //#define MIDI_ADVANCED | ||
219 | |||
220 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
221 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
222 | |||
223 | /* Bootmagic Lite key configuration */ | 203 | /* Bootmagic Lite key configuration */ |
224 | // #define BOOTMAGIC_LITE_ROW 0 | 204 | // #define BOOTMAGIC_LITE_ROW 0 |
225 | // #define BOOTMAGIC_LITE_COLUMN 0 | 205 | // #define BOOTMAGIC_LITE_COLUMN 0 |
diff --git a/keyboards/qwertyydox/rules.mk b/keyboards/qwertyydox/rules.mk index e6fc573bd..50329f9cf 100644 --- a/keyboards/qwertyydox/rules.mk +++ b/keyboards/qwertyydox/rules.mk | |||
@@ -9,7 +9,6 @@ CONSOLE_ENABLE = no # Console for debug | |||
9 | COMMAND_ENABLE = no # Commands for debug and configuration | 9 | COMMAND_ENABLE = no # Commands for debug and configuration |
10 | NKRO_ENABLE = no # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 10 | NKRO_ENABLE = no # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
11 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality | 11 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality |
12 | MIDI_ENABLE = no # MIDI controls | ||
13 | AUDIO_ENABLE = no # Audio output on port C6 | 12 | AUDIO_ENABLE = no # Audio output on port C6 |
14 | UNICODE_ENABLE = no # Unicode | 13 | UNICODE_ENABLE = no # Unicode |
15 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 14 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |