diff options
author | James Young <18669334+noroadsleft@users.noreply.github.com> | 2021-08-15 20:51:13 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-08-16 06:51:13 +1000 |
commit | 4b453dca92f87899d98b5340b16677bd78a52beb (patch) | |
tree | a40b8e53964520762946e0c63bfc0a83cb2a3428 /keyboards/tkc | |
parent | fd340f8957055d74b26a5ddc490253fcc8a3a2f7 (diff) | |
download | qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.tar.gz qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.zip |
Remove MIDI Configuration boilerplate (#11151)
* remove keyboard-level instances of `MIDI_ENABLE = no`
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} +
```
Co-Authored-By: Nick Brassel <nick@tzarc.org>
* fix case-sensitivity issues on MIDI_ENABLE
Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} +
```
* replace `# MIDI controls` with `# MIDI support`
Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} +
```
* align inline comments
Aligns the inline comments to the length used by the QMK AVR rules.mk template.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} +
```
* remove commented instances of `MIDI_ENABLE` from keyboard `rules.mk` files
Commands:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} +
```
* remove MIDI configuration boilerplate from keyboard config.h files
Co-authored-by: Nick Brassel <nick@tzarc.org>
Diffstat (limited to 'keyboards/tkc')
-rw-r--r-- | keyboards/tkc/candybar/lefty/config.h | 20 | ||||
-rw-r--r-- | keyboards/tkc/candybar/righty/config.h | 20 | ||||
-rw-r--r-- | keyboards/tkc/godspeed75/config.h | 20 | ||||
-rw-r--r-- | keyboards/tkc/osav2/config.h | 20 | ||||
-rw-r--r-- | keyboards/tkc/osav2/rules.mk | 1 | ||||
-rw-r--r-- | keyboards/tkc/tkc1800/config.h | 20 | ||||
-rw-r--r-- | keyboards/tkc/tkc1800/rules.mk | 1 |
7 files changed, 0 insertions, 102 deletions
diff --git a/keyboards/tkc/candybar/lefty/config.h b/keyboards/tkc/candybar/lefty/config.h index 0f789a7b6..ba5c0b077 100644 --- a/keyboards/tkc/candybar/lefty/config.h +++ b/keyboards/tkc/candybar/lefty/config.h | |||
@@ -80,26 +80,6 @@ | |||
80 | //#define NO_ACTION_MACRO | 80 | //#define NO_ACTION_MACRO |
81 | //#define NO_ACTION_FUNCTION | 81 | //#define NO_ACTION_FUNCTION |
82 | 82 | ||
83 | /* | ||
84 | * MIDI options | ||
85 | */ | ||
86 | |||
87 | /* enable basic MIDI features: | ||
88 | - MIDI notes can be sent when in Music mode is on | ||
89 | */ | ||
90 | //#define MIDI_BASIC | ||
91 | |||
92 | /* enable advanced MIDI features: | ||
93 | - MIDI notes can be added to the keymap | ||
94 | - Octave shift and transpose | ||
95 | - Virtual sustain, portamento, and modulation wheel | ||
96 | - etc. | ||
97 | */ | ||
98 | //#define MIDI_ADVANCED | ||
99 | |||
100 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
101 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
102 | |||
103 | // #define WS2812_LED_N 2 | 83 | // #define WS2812_LED_N 2 |
104 | // #define RGBLED_NUM WS2812_LED_N | 84 | // #define RGBLED_NUM WS2812_LED_N |
105 | // #define WS2812_TIM_N 2 | 85 | // #define WS2812_TIM_N 2 |
diff --git a/keyboards/tkc/candybar/righty/config.h b/keyboards/tkc/candybar/righty/config.h index 4c269c299..47e3985ff 100644 --- a/keyboards/tkc/candybar/righty/config.h +++ b/keyboards/tkc/candybar/righty/config.h | |||
@@ -80,26 +80,6 @@ | |||
80 | //#define NO_ACTION_MACRO | 80 | //#define NO_ACTION_MACRO |
81 | //#define NO_ACTION_FUNCTION | 81 | //#define NO_ACTION_FUNCTION |
82 | 82 | ||
83 | /* | ||
84 | * MIDI options | ||
85 | */ | ||
86 | |||
87 | /* enable basic MIDI features: | ||
88 | - MIDI notes can be sent when in Music mode is on | ||
89 | */ | ||
90 | //#define MIDI_BASIC | ||
91 | |||
92 | /* enable advanced MIDI features: | ||
93 | - MIDI notes can be added to the keymap | ||
94 | - Octave shift and transpose | ||
95 | - Virtual sustain, portamento, and modulation wheel | ||
96 | - etc. | ||
97 | */ | ||
98 | //#define MIDI_ADVANCED | ||
99 | |||
100 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
101 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
102 | |||
103 | // #define WS2812_LED_N 2 | 83 | // #define WS2812_LED_N 2 |
104 | // #define RGBLED_NUM WS2812_LED_N | 84 | // #define RGBLED_NUM WS2812_LED_N |
105 | // #define WS2812_TIM_N 2 | 85 | // #define WS2812_TIM_N 2 |
diff --git a/keyboards/tkc/godspeed75/config.h b/keyboards/tkc/godspeed75/config.h index 93604a9a6..f50d4c638 100644 --- a/keyboards/tkc/godspeed75/config.h +++ b/keyboards/tkc/godspeed75/config.h | |||
@@ -80,26 +80,6 @@ | |||
80 | //#define NO_ACTION_MACRO | 80 | //#define NO_ACTION_MACRO |
81 | //#define NO_ACTION_FUNCTION | 81 | //#define NO_ACTION_FUNCTION |
82 | 82 | ||
83 | /* | ||
84 | * MIDI options | ||
85 | */ | ||
86 | |||
87 | /* enable basic MIDI features: | ||
88 | - MIDI notes can be sent when in Music mode is on | ||
89 | */ | ||
90 | //#define MIDI_BASIC | ||
91 | |||
92 | /* enable advanced MIDI features: | ||
93 | - MIDI notes can be added to the keymap | ||
94 | - Octave shift and transpose | ||
95 | - Virtual sustain, portamento, and modulation wheel | ||
96 | - etc. | ||
97 | */ | ||
98 | //#define MIDI_ADVANCED | ||
99 | |||
100 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
101 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
102 | |||
103 | #define RGB_DI_PIN A13 | 83 | #define RGB_DI_PIN A13 |
104 | #define RGBLED_NUM 14 | 84 | #define RGBLED_NUM 14 |
105 | #define RGBLIGHT_ANIMATIONS | 85 | #define RGBLIGHT_ANIMATIONS |
diff --git a/keyboards/tkc/osav2/config.h b/keyboards/tkc/osav2/config.h index aaac1a0a9..c70fdc981 100644 --- a/keyboards/tkc/osav2/config.h +++ b/keyboards/tkc/osav2/config.h | |||
@@ -194,26 +194,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
194 | //#define NO_ACTION_MACRO | 194 | //#define NO_ACTION_MACRO |
195 | //#define NO_ACTION_FUNCTION | 195 | //#define NO_ACTION_FUNCTION |
196 | 196 | ||
197 | /* | ||
198 | * MIDI options | ||
199 | */ | ||
200 | |||
201 | /* enable basic MIDI features: | ||
202 | - MIDI notes can be sent when in Music mode is on | ||
203 | */ | ||
204 | //#define MIDI_BASIC | ||
205 | |||
206 | /* enable advanced MIDI features: | ||
207 | - MIDI notes can be added to the keymap | ||
208 | - Octave shift and transpose | ||
209 | - Virtual sustain, portamento, and modulation wheel | ||
210 | - etc. | ||
211 | */ | ||
212 | //#define MIDI_ADVANCED | ||
213 | |||
214 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
215 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
216 | |||
217 | /* Bootmagic Lite key configuration */ | 197 | /* Bootmagic Lite key configuration */ |
218 | //#define BOOTMAGIC_LITE_ROW 0 | 198 | //#define BOOTMAGIC_LITE_ROW 0 |
219 | //#define BOOTMAGIC_LITE_COLUMN 0 | 199 | //#define BOOTMAGIC_LITE_COLUMN 0 |
diff --git a/keyboards/tkc/osav2/rules.mk b/keyboards/tkc/osav2/rules.mk index 8da4c4683..835ccebd2 100644 --- a/keyboards/tkc/osav2/rules.mk +++ b/keyboards/tkc/osav2/rules.mk | |||
@@ -25,7 +25,6 @@ SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | |||
25 | NKRO_ENABLE = yes # USB Nkey Rollover | 25 | NKRO_ENABLE = yes # USB Nkey Rollover |
26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 26 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
27 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow | 27 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow |
28 | MIDI_ENABLE = no # MIDI support | ||
29 | UNICODE_ENABLE = no # Unicode | 28 | UNICODE_ENABLE = no # Unicode |
30 | BLUETOOTH_ENABLE = no # Enable Bluetooth | 29 | BLUETOOTH_ENABLE = no # Enable Bluetooth |
31 | AUDIO_ENABLE = no # Audio output | 30 | AUDIO_ENABLE = no # Audio output |
diff --git a/keyboards/tkc/tkc1800/config.h b/keyboards/tkc/tkc1800/config.h index 82d599c55..17441b084 100644 --- a/keyboards/tkc/tkc1800/config.h +++ b/keyboards/tkc/tkc1800/config.h | |||
@@ -161,23 +161,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
161 | //#define NO_ACTION_ONESHOT | 161 | //#define NO_ACTION_ONESHOT |
162 | //#define NO_ACTION_MACRO | 162 | //#define NO_ACTION_MACRO |
163 | //#define NO_ACTION_FUNCTION | 163 | //#define NO_ACTION_FUNCTION |
164 | |||
165 | /* | ||
166 | * MIDI options | ||
167 | */ | ||
168 | |||
169 | /* enable basic MIDI features: | ||
170 | - MIDI notes can be sent when in Music mode is on | ||
171 | */ | ||
172 | //#define MIDI_BASIC | ||
173 | |||
174 | /* enable advanced MIDI features: | ||
175 | - MIDI notes can be added to the keymap | ||
176 | - Octave shift and transpose | ||
177 | - Virtual sustain, portamento, and modulation wheel | ||
178 | - etc. | ||
179 | */ | ||
180 | //#define MIDI_ADVANCED | ||
181 | |||
182 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
183 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
diff --git a/keyboards/tkc/tkc1800/rules.mk b/keyboards/tkc/tkc1800/rules.mk index cc5d3676b..a81223745 100644 --- a/keyboards/tkc/tkc1800/rules.mk +++ b/keyboards/tkc/tkc1800/rules.mk | |||
@@ -26,7 +26,6 @@ SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | |||
26 | NKRO_ENABLE = yes # USB Nkey Rollover | 26 | NKRO_ENABLE = yes # USB Nkey Rollover |
27 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default | 27 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default |
28 | RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. Do not enable this with audio at the same time. | 28 | RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. Do not enable this with audio at the same time. |
29 | MIDI_ENABLE = no # MIDI controls | ||
30 | UNICODE_ENABLE = no # Unicode | 29 | UNICODE_ENABLE = no # Unicode |
31 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 30 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
32 | AUDIO_ENABLE = no # Audio output on port C6 | 31 | AUDIO_ENABLE = no # Audio output on port C6 |