diff options
| author | Stefan Schulze <shaggadalic+github@gmail.com> | 2021-02-16 18:45:05 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-16 09:45:05 -0800 |
| commit | 4a10dfb54d42fe81d1acf578152e264dac725b8d (patch) | |
| tree | de0eb49d4873f2932d9db75ef6d607eda55231c5 /lib/python/qmk/cli/doctor.py | |
| parent | 95304f269b824f1c453fe380617af85f9d534882 (diff) | |
| download | qmk_firmware-4a10dfb54d42fe81d1acf578152e264dac725b8d.tar.gz qmk_firmware-4a10dfb54d42fe81d1acf578152e264dac725b8d.zip | |
Fix submodule check for qmk setup (#11379)
The initialization of the submodules would succeed, but the result of the subsequent
check_submodules() run wasn't checked correctly.
Co-authored-by: Stefan Schulze <stefan.andre.schulze@posteo.de>
Diffstat (limited to 'lib/python/qmk/cli/doctor.py')
| -rwxr-xr-x | lib/python/qmk/cli/doctor.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/python/qmk/cli/doctor.py b/lib/python/qmk/cli/doctor.py index 70f32911a..28d480707 100755 --- a/lib/python/qmk/cli/doctor.py +++ b/lib/python/qmk/cli/doctor.py | |||
| @@ -107,9 +107,9 @@ def doctor(cli): | |||
| 107 | submodules.update() | 107 | submodules.update() |
| 108 | sub_ok = check_submodules() | 108 | sub_ok = check_submodules() |
| 109 | 109 | ||
| 110 | if CheckStatus.ERROR in sub_ok: | 110 | if sub_ok == CheckStatus.ERROR: |
| 111 | status = CheckStatus.ERROR | 111 | status = CheckStatus.ERROR |
| 112 | elif CheckStatus.WARNING in sub_ok and status == CheckStatus.OK: | 112 | elif sub_ok == CheckStatus.WARNING and status == CheckStatus.OK: |
| 113 | status = CheckStatus.WARNING | 113 | status = CheckStatus.WARNING |
| 114 | 114 | ||
| 115 | # Report a summary of our findings to the user | 115 | # Report a summary of our findings to the user |