aboutsummaryrefslogtreecommitdiff
path: root/tmk_core
diff options
context:
space:
mode:
authorDrashna Jaelre <drashna@live.com>2020-04-12 08:27:17 -0700
committerGitHub <noreply@github.com>2020-04-12 17:27:17 +0200
commit23124b9fd1d667b3457410b771153361e22ae133 (patch)
treecc5bf6744ff5e02bb0f9c0b0e0a1808be5cc3094 /tmk_core
parenteb7fc7f9d99231e4c59dee2bef8659b089f4846a (diff)
downloadqmk_firmware-23124b9fd1d667b3457410b771153361e22ae133.tar.gz
qmk_firmware-23124b9fd1d667b3457410b771153361e22ae133.zip
Fix bug with layer caching in get_event_keycode (#8693)
* Fix bug with layer caching in get_event_keycode * Improve naming
Diffstat (limited to 'tmk_core')
-rw-r--r--tmk_core/common/action.c2
-rw-r--r--tmk_core/common/action_tapping.c8
-rw-r--r--tmk_core/common/action_tapping.h2
3 files changed, 6 insertions, 6 deletions
diff --git a/tmk_core/common/action.c b/tmk_core/common/action.c
index 74db245c1..27c0abe6f 100644
--- a/tmk_core/common/action.c
+++ b/tmk_core/common/action.c
@@ -324,7 +324,7 @@ void process_action(keyrecord_t *record, action_t action) {
324# if !defined(IGNORE_MOD_TAP_INTERRUPT) || defined(IGNORE_MOD_TAP_INTERRUPT_PER_KEY) 324# if !defined(IGNORE_MOD_TAP_INTERRUPT) || defined(IGNORE_MOD_TAP_INTERRUPT_PER_KEY)
325 if ( 325 if (
326# ifdef IGNORE_MOD_TAP_INTERRUPT_PER_KEY 326# ifdef IGNORE_MOD_TAP_INTERRUPT_PER_KEY
327 !get_ignore_mod_tap_interrupt(get_event_keycode(record->event)) && 327 !get_ignore_mod_tap_interrupt(get_event_keycode(record->event, false)) &&
328# endif 328# endif
329 record->tap.interrupted) { 329 record->tap.interrupted) {
330 dprint("mods_tap: tap: cancel: add_mods\n"); 330 dprint("mods_tap: tap: cancel: add_mods\n");
diff --git a/tmk_core/common/action_tapping.c b/tmk_core/common/action_tapping.c
index acce3ee51..34f08d890 100644
--- a/tmk_core/common/action_tapping.c
+++ b/tmk_core/common/action_tapping.c
@@ -22,7 +22,7 @@
22__attribute__((weak)) uint16_t get_tapping_term(uint16_t keycode) { return TAPPING_TERM; } 22__attribute__((weak)) uint16_t get_tapping_term(uint16_t keycode) { return TAPPING_TERM; }
23 23
24# ifdef TAPPING_TERM_PER_KEY 24# ifdef TAPPING_TERM_PER_KEY
25# define WITHIN_TAPPING_TERM(e) (TIMER_DIFF_16(e.time, tapping_key.event.time) < get_tapping_term(get_event_keycode(tapping_key.event))) 25# define WITHIN_TAPPING_TERM(e) (TIMER_DIFF_16(e.time, tapping_key.event.time) < get_tapping_term(get_event_keycode(tapping_key.event, false)))
26# else 26# else
27# define WITHIN_TAPPING_TERM(e) (TIMER_DIFF_16(e.time, tapping_key.event.time) < TAPPING_TERM) 27# define WITHIN_TAPPING_TERM(e) (TIMER_DIFF_16(e.time, tapping_key.event.time) < TAPPING_TERM)
28# endif 28# endif
@@ -122,10 +122,10 @@ bool process_tapping(keyrecord_t *keyp) {
122# if defined(TAPPING_TERM_PER_KEY) || (TAPPING_TERM >= 500) || defined(PERMISSIVE_HOLD) || defined(PERMISSIVE_HOLD_PER_KEY) 122# if defined(TAPPING_TERM_PER_KEY) || (TAPPING_TERM >= 500) || defined(PERMISSIVE_HOLD) || defined(PERMISSIVE_HOLD_PER_KEY)
123 else if ( 123 else if (
124# ifdef TAPPING_TERM_PER_KEY 124# ifdef TAPPING_TERM_PER_KEY
125 (get_tapping_term(get_event_keycode(tapping_key.event)) >= 500) && 125 (get_tapping_term(get_event_keycode(tapping_key.event, false)) >= 500) &&
126# endif 126# endif
127# ifdef PERMISSIVE_HOLD_PER_KEY 127# ifdef PERMISSIVE_HOLD_PER_KEY
128 !get_permissive_hold(get_event_keycode(tapping_key.event), keyp) && 128 !get_permissive_hold(get_event_keycode(tapping_key.event, false), keyp) &&
129# endif 129# endif
130 IS_RELEASED(event) && waiting_buffer_typed(event)) { 130 IS_RELEASED(event) && waiting_buffer_typed(event)) {
131 debug("Tapping: End. No tap. Interfered by typing key\n"); 131 debug("Tapping: End. No tap. Interfered by typing key\n");
@@ -246,7 +246,7 @@ bool process_tapping(keyrecord_t *keyp) {
246# if !defined(TAPPING_FORCE_HOLD) || defined(TAPPING_FORCE_HOLD_PER_KEY) 246# if !defined(TAPPING_FORCE_HOLD) || defined(TAPPING_FORCE_HOLD_PER_KEY)
247 if ( 247 if (
248# ifdef TAPPING_FORCE_HOLD_PER_KEY 248# ifdef TAPPING_FORCE_HOLD_PER_KEY
249 !get_tapping_force_hold(get_event_keycode(tapping_key.event), keyp) && 249 !get_tapping_force_hold(get_event_keycode(tapping_key.event, false), keyp) &&
250# endif 250# endif
251 !tapping_key.tap.interrupted && tapping_key.tap.count > 0) { 251 !tapping_key.tap.interrupted && tapping_key.tap.count > 0) {
252 // sequential tap. 252 // sequential tap.
diff --git a/tmk_core/common/action_tapping.h b/tmk_core/common/action_tapping.h
index 509d5eabd..5eaef1c5f 100644
--- a/tmk_core/common/action_tapping.h
+++ b/tmk_core/common/action_tapping.h
@@ -32,7 +32,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
32#define WAITING_BUFFER_SIZE 8 32#define WAITING_BUFFER_SIZE 8
33 33
34#ifndef NO_ACTION_TAPPING 34#ifndef NO_ACTION_TAPPING
35uint16_t get_event_keycode(keyevent_t event); 35uint16_t get_event_keycode(keyevent_t event, bool update_layer_cache);
36uint16_t get_tapping_term(uint16_t keycode); 36uint16_t get_tapping_term(uint16_t keycode);
37void action_tapping_process(keyrecord_t record); 37void action_tapping_process(keyrecord_t record);
38#endif 38#endif