diff options
| author | Zach White <skullydazed@gmail.com> | 2021-09-27 10:02:54 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-27 10:02:54 -0700 |
| commit | fce9cb933845bf0b74d322eba02de3b76daaeb84 (patch) | |
| tree | a28ffc6f3c53a4ddf1004f1a99938e2e5a42e6c3 /util | |
| parent | 5f38a98fa07677be960b71b8e3b0a1785effe0d8 (diff) | |
| download | qmk_firmware-fce9cb933845bf0b74d322eba02de3b76daaeb84.tar.gz qmk_firmware-fce9cb933845bf0b74d322eba02de3b76daaeb84.zip | |
Cleanup issues identified by lgtm (#14459)
* cleanup issues identified by lgtm
* fix the git_status check
Diffstat (limited to 'util')
| -rwxr-xr-x | util/stm32eeprom_parser.py | 1 | ||||
| -rwxr-xr-x | util/uf2conv.py | 8 |
2 files changed, 4 insertions, 5 deletions
diff --git a/util/stm32eeprom_parser.py b/util/stm32eeprom_parser.py index b124f713d..e08b67064 100755 --- a/util/stm32eeprom_parser.py +++ b/util/stm32eeprom_parser.py | |||
| @@ -197,7 +197,6 @@ def dumpBinary(data, canonical): | |||
| 197 | print("") | 197 | print("") |
| 198 | 198 | ||
| 199 | size = len(data) | 199 | size = len(data) |
| 200 | empty_rows = 0 | ||
| 201 | prev_row = '' | 200 | prev_row = '' |
| 202 | first_repeat = True | 201 | first_repeat = True |
| 203 | for pos in range(0, size, 16): | 202 | for pos in range(0, size, 16): |
diff --git a/util/uf2conv.py b/util/uf2conv.py index 044a7f231..8677a828c 100755 --- a/util/uf2conv.py +++ b/util/uf2conv.py | |||
| @@ -78,7 +78,7 @@ def convert_from_uf2(buf): | |||
| 78 | if datalen > 476: | 78 | if datalen > 476: |
| 79 | assert False, "Invalid UF2 data size at " + ptr | 79 | assert False, "Invalid UF2 data size at " + ptr |
| 80 | newaddr = hd[3] | 80 | newaddr = hd[3] |
| 81 | if curraddr == None: | 81 | if curraddr is None: |
| 82 | appstartaddr = newaddr | 82 | appstartaddr = newaddr |
| 83 | curraddr = newaddr | 83 | curraddr = newaddr |
| 84 | padding = newaddr - curraddr | 84 | padding = newaddr - curraddr |
| @@ -171,7 +171,7 @@ def convert_from_hex_to_uf2(buf): | |||
| 171 | break | 171 | break |
| 172 | elif tp == 0: | 172 | elif tp == 0: |
| 173 | addr = upper | (rec[1] << 8) | rec[2] | 173 | addr = upper | (rec[1] << 8) | rec[2] |
| 174 | if appstartaddr == None: | 174 | if appstartaddr is None: |
| 175 | appstartaddr = addr | 175 | appstartaddr = addr |
| 176 | i = 4 | 176 | i = 4 |
| 177 | while i < len(rec) - 1: | 177 | while i < len(rec) - 1: |
| @@ -215,7 +215,7 @@ def get_drives(): | |||
| 215 | def has_info(d): | 215 | def has_info(d): |
| 216 | try: | 216 | try: |
| 217 | return os.path.isfile(d + INFO_FILE) | 217 | return os.path.isfile(d + INFO_FILE) |
| 218 | except: | 218 | except Exception: |
| 219 | return False | 219 | return False |
| 220 | 220 | ||
| 221 | return list(filter(has_info, drives)) | 221 | return list(filter(has_info, drives)) |
| @@ -300,7 +300,7 @@ def main(): | |||
| 300 | (ext, len(outbuf), appstartaddr)) | 300 | (ext, len(outbuf), appstartaddr)) |
| 301 | if args.convert or ext != "uf2": | 301 | if args.convert or ext != "uf2": |
| 302 | drives = [] | 302 | drives = [] |
| 303 | if args.output == None: | 303 | if args.output is None: |
| 304 | args.output = "flash." + ext | 304 | args.output = "flash." + ext |
| 305 | else: | 305 | else: |
| 306 | drives = get_drives() | 306 | drives = get_drives() |
