diff options
| author | Konstantin Đorđević <vomindoraan@gmail.com> | 2018-12-08 18:42:46 +0100 |
|---|---|---|
| committer | MechMerlin <30334081+mechmerlin@users.noreply.github.com> | 2018-12-08 09:42:46 -0800 |
| commit | 13ad6501361faa9433562dba4ea8c55f85bf1dc5 (patch) | |
| tree | c6ac7ff8074cd4bb1f920fa0a204219d76fb8d0a /util | |
| parent | 2ad2b73d685cf25268fa7d3726f45594edee70c4 (diff) | |
| download | qmk_firmware-13ad6501361faa9433562dba4ea8c55f85bf1dc5.tar.gz qmk_firmware-13ad6501361faa9433562dba4ea8c55f85bf1dc5.zip | |
Add a better Docker build script + update Dockerfile (#4222)
* Add a Docker build script
* Add usage and error messages
* Add -r to reads
Thanks mechmerlin
* Add keyboard:keymap form, improve script
* Add target argument, change usage forms in script
* Add check for more than 3 args in keyboard:keymap:target form
* Change Docker base image to debian, use community repo
This matches what qmk_compiler uses (https://github.com/qmk/qmk_compiler/blob/master/Dockerfile#L1).
I've removed the maintainer as we now have a community build on Docker Hub (https://hub.docker.com/r/qmkfm/qmk_firmware). This Dockerfile will also be maintained by the community.
* Change build command format to keyboard:keymap
* Call make directly in container run command
* Simplify script, remove 3-arg form
* Add COPY to Dockerfile so images are usable in and of themselves
Also change WORKDIR from /qmk to /qmk_firmware
* Add USB pass-through for Linux and docker-machine hosts
* Read directly into variables instead of array
* Alphabetically sort dependencies in Dockerfile
* Set executable bit on util/docker_build.sh
* Update Docker docs
* Add warning about Docker on Windows
* Expand comment in docs
* Check docker-machine exit code instead of string
* Only match --help with whole arguments
* Make script POSIX-compliant
* Convert script indentation to tabs
Diffstat (limited to 'util')
| -rwxr-xr-x | util/docker_build.sh | 49 |
1 files changed, 49 insertions, 0 deletions
diff --git a/util/docker_build.sh b/util/docker_build.sh new file mode 100755 index 000000000..26075cc90 --- /dev/null +++ b/util/docker_build.sh | |||
| @@ -0,0 +1,49 @@ | |||
| 1 | #!/bin/sh | ||
| 2 | # NOTE: This script uses tabs for indentation | ||
| 3 | |||
| 4 | USAGE="Usage: $0 [keyboard[:keymap[:target]]]" | ||
| 5 | |||
| 6 | # Check preconditions | ||
| 7 | for arg; do | ||
| 8 | if [ "$arg" = "--help" ]; then | ||
| 9 | echo "$USAGE" | ||
| 10 | exit 0 | ||
| 11 | fi | ||
| 12 | done | ||
| 13 | if [ $# -gt 1 ]; then | ||
| 14 | echo "$USAGE" >&2 | ||
| 15 | exit 1 | ||
| 16 | elif ! command -v docker >/dev/null 2>&1; then | ||
| 17 | echo "Error: docker not found" >&2 | ||
| 18 | echo "See https://docs.docker.com/install/#supported-platforms for installation instructions" >&2 | ||
| 19 | exit 2 | ||
| 20 | fi | ||
| 21 | |||
| 22 | # Determine arguments | ||
| 23 | if [ $# -eq 0 ]; then | ||
| 24 | printf "keyboard=" && read -r keyboard | ||
| 25 | [ -n "$keyboard" ] && printf "keymap=" && read -r keymap | ||
| 26 | [ -n "$keymap" ] && printf "target=" && read -r target | ||
| 27 | else | ||
| 28 | IFS=':' read -r keyboard keymap target x <<-EOF | ||
| 29 | $1 | ||
| 30 | EOF | ||
| 31 | if [ -n "$x" ]; then | ||
| 32 | echo "$USAGE" >&2 | ||
| 33 | exit 1 | ||
| 34 | fi | ||
| 35 | fi | ||
| 36 | if [ -n "$target" ]; then | ||
| 37 | if [ "$(uname)" = "Linux" ] || docker-machine active >/dev/null 2>&1; then | ||
| 38 | usb_args="--privileged -v /dev/bus/usb:/dev/bus/usb" | ||
| 39 | else | ||
| 40 | echo "Error: target requires docker-machine to work on your platform" >&2 | ||
| 41 | echo "See http://gw.tnode.com/docker/docker-machine-with-usb-support-on-windows-macos" >&2 | ||
| 42 | exit 3 | ||
| 43 | fi | ||
| 44 | fi | ||
| 45 | dir=$(pwd -W 2>/dev/null) || dir=$PWD # Use Windows path if on Windows | ||
| 46 | |||
| 47 | # Run container and build firmware | ||
| 48 | docker run --rm $usb_args -v "$dir":/qmk_firmware qmkfm/qmk_firmware \ | ||
| 49 | make "$keyboard${keymap:+:$keymap}${target:+:$target}" | ||
