diff options
Diffstat (limited to 'docs/pr_checklist.md')
| -rw-r--r-- | docs/pr_checklist.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index 94c62c653..2a2b0f1e7 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md | |||
| @@ -24,7 +24,7 @@ If there are any inconsistencies with these recommendations, you're best off [cr | |||
| 24 | - no "old-school" or other low-level GPIO/I2C/SPI functions may be used -- must use QMK abstractions unless justifiable (and laziness is not valid justification) | 24 | - no "old-school" or other low-level GPIO/I2C/SPI functions may be used -- must use QMK abstractions unless justifiable (and laziness is not valid justification) |
| 25 | - timing abstractions should be followed too: | 25 | - timing abstractions should be followed too: |
| 26 | - `wait_ms()` instead of `_delay_ms()` (remove `#include <util/delay.h>` too) | 26 | - `wait_ms()` instead of `_delay_ms()` (remove `#include <util/delay.h>` too) |
| 27 | - `timer_read()` and `timer_read32()` etc. -- see [timer.h](https://github.com/qmk/qmk_firmware/blob/master/tmk_core/common/timer.h) for the timing APIs | 27 | - `timer_read()` and `timer_read32()` etc. -- see [timer.h](https://github.com/qmk/qmk_firmware/blob/master/platforms/timer.h) for the timing APIs |
| 28 | - if you think a new abstraction is useful, you're encouraged to: | 28 | - if you think a new abstraction is useful, you're encouraged to: |
| 29 | - prototype it in your own keyboard until it's feature-complete | 29 | - prototype it in your own keyboard until it's feature-complete |
| 30 | - discuss it with QMK Collaborators on Discord | 30 | - discuss it with QMK Collaborators on Discord |