diff options
Diffstat (limited to 'docs/pr_checklist.md')
| -rw-r--r-- | docs/pr_checklist.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index 2a2b0f1e7..25f3d7662 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md | |||
| @@ -118,6 +118,10 @@ Also, specific to ChibiOS: | |||
| 118 | ## Core PRs | 118 | ## Core PRs |
| 119 | 119 | ||
| 120 | - must now target `develop` branch, which will subsequently be merged back to `master` on the breaking changes timeline | 120 | - must now target `develop` branch, which will subsequently be merged back to `master` on the breaking changes timeline |
| 121 | - any support for new hardware now requires a corresponding test board under `keyboards/handwired/onekey` | ||
| 122 | - for new MCUs, a new "child" keyboard should be added that targets your newly-added MCU, so that builds can be verified | ||
| 123 | - for new hardware support such as display panels, core-side matrix implementations, or other peripherals, an associated keymap should be provided | ||
| 124 | - if an existing keymap exists that can leverage this functionality this may not be required (e.g. a new RGB driver chip, supported by the `rgb` keymap) -- consult with the QMK Collaborators on Discord to determine if there is sufficient overlap already | ||
| 121 | - other requirements are at the discretion of QMK collaborators | 125 | - other requirements are at the discretion of QMK collaborators |
| 122 | - core is a lot more subjective given the breadth of posted changes | 126 | - core is a lot more subjective given the breadth of posted changes |
| 123 | 127 | ||