aboutsummaryrefslogtreecommitdiff
path: root/keyboards/3w6/rev2/matrix.c
diff options
context:
space:
mode:
Diffstat (limited to 'keyboards/3w6/rev2/matrix.c')
-rw-r--r--keyboards/3w6/rev2/matrix.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/keyboards/3w6/rev2/matrix.c b/keyboards/3w6/rev2/matrix.c
index 0fc0322b6..c47c24e1d 100644
--- a/keyboards/3w6/rev2/matrix.c
+++ b/keyboards/3w6/rev2/matrix.c
@@ -34,7 +34,7 @@ extern i2c_status_t tca9555_status;
34// All address pins of the tca9555 are connected to the ground 34// All address pins of the tca9555 are connected to the ground
35// | 0 | 1 | 0 | 0 | A2 | A1 | A0 | 35// | 0 | 1 | 0 | 0 | A2 | A1 | A0 |
36// | 0 | 1 | 0 | 0 | 0 | 0 | 0 | 36// | 0 | 1 | 0 | 0 | 0 | 0 | 0 |
37#define I2C_ADDR 0b0100000 37#define I2C_ADDR (0b0100000 << 1)
38 38
39// Register addresses 39// Register addresses
40#define IODIRA 0x06 // i/o direction register 40#define IODIRA 0x06 // i/o direction register
@@ -192,6 +192,7 @@ static matrix_row_t read_cols(uint8_t row) {
192 // do nothing 192 // do nothing
193 return 0; 193 return 0;
194 } else { 194 } else {
195 port0 = ~port0;
195 // We read all the pins on GPIOA. 196 // We read all the pins on GPIOA.
196 // The initial state was all ones and any depressed key at a given column for the currently selected row will have its bit flipped to zero. 197 // The initial state was all ones and any depressed key at a given column for the currently selected row will have its bit flipped to zero.
197 // The return value is a row as represented in the generic matrix code were the rightmost bits represent the lower columns and zeroes represent non-depressed keys while ones represent depressed keys. 198 // The return value is a row as represented in the generic matrix code were the rightmost bits represent the lower columns and zeroes represent non-depressed keys while ones represent depressed keys.
@@ -247,7 +248,7 @@ static void select_row(uint8_t row) {
247 default: break; 248 default: break;
248 } 249 }
249 250
250 tca9555_status = i2c_writeReg(I2C_ADDR, OREGP1, &port1, 2, I2C_TIMEOUT); 251 tca9555_status = i2c_writeReg(I2C_ADDR, OREGP1, &port1, 1, I2C_TIMEOUT);
251 // Select the desired row by writing a byte for the entire GPIOB bus where only the bit representing the row we want to select is a zero (write instruction) and every other bit is a one. 252 // Select the desired row by writing a byte for the entire GPIOB bus where only the bit representing the row we want to select is a zero (write instruction) and every other bit is a one.
252 // Note that the row - MATRIX_ROWS_PER_SIDE reflects the fact that being on the right hand, the columns are numbered from MATRIX_ROWS_PER_SIDE to MATRIX_ROWS, but the pins we want to write to are indexed from zero up on the GPIOB bus. 253 // Note that the row - MATRIX_ROWS_PER_SIDE reflects the fact that being on the right hand, the columns are numbered from MATRIX_ROWS_PER_SIDE to MATRIX_ROWS, but the pins we want to write to are indexed from zero up on the GPIOB bus.
253 } 254 }