From 4107856b70eb686d2e151254ca73adf522312c49 Mon Sep 17 00:00:00 2001 From: Jay Greco Date: Tue, 9 Feb 2021 06:50:16 -0800 Subject: Simplify NIBBLE encoder code and clean up keymaps (#11808) * Simplify encoder code and clean up keymaps. -Removed overly complex VIA encoder code. It wasn't adding any value and was confusing users who were trying to customize encoder functionality on VIA keymaps. -Replaced KC_TILDE with KC_HOME in all keymaps, as KC_TILDE sends a left shift, which was confusing some folks as they tested their build. -Move layer names to enum * Change encoder_update_kb to encoder_update_user per PR feedback --- keyboards/nullbitsco/nibble/keymaps/iso/keymap.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'keyboards/nullbitsco/nibble/keymaps/iso/keymap.c') diff --git a/keyboards/nullbitsco/nibble/keymaps/iso/keymap.c b/keyboards/nullbitsco/nibble/keymaps/iso/keymap.c index 7e78b1f63..214034ef8 100644 --- a/keyboards/nullbitsco/nibble/keymaps/iso/keymap.c +++ b/keyboards/nullbitsco/nibble/keymaps/iso/keymap.c @@ -15,8 +15,10 @@ */ #include QMK_KEYBOARD_H -#define _MA 0 -#define _FN 1 +enum layer_names { + _MA, + _FN +}; enum custom_keycodes { KC_CUST = SAFE_RANGE, @@ -103,7 +105,7 @@ void change_RGB(bool clockwise) { } } -void encoder_update_kb(uint8_t index, bool clockwise) { +void encoder_update_user(uint8_t index, bool clockwise) { if (layer_state_is(1)) { //change RGB settings change_RGB(clockwise); -- cgit v1.2.3