From 826ef61338f8cf9c5c71fe2fd5b2ed82e0dabcf9 Mon Sep 17 00:00:00 2001 From: Federico Igne Date: Thu, 15 Apr 2021 12:32:45 +0100 Subject: Prepare code for double-blind submission --- src/main/scala/uk/ac/ox/cs/rsacomb/CanonicalModel.scala | 4 ---- src/main/scala/uk/ac/ox/cs/rsacomb/RSAOntology.scala | 2 -- src/main/scala/uk/ac/ox/cs/rsacomb/converter/RDFoxConverter.scala | 8 -------- 3 files changed, 14 deletions(-) (limited to 'src') diff --git a/src/main/scala/uk/ac/ox/cs/rsacomb/CanonicalModel.scala b/src/main/scala/uk/ac/ox/cs/rsacomb/CanonicalModel.scala index 3da6c8a..6621f59 100644 --- a/src/main/scala/uk/ac/ox/cs/rsacomb/CanonicalModel.scala +++ b/src/main/scala/uk/ac/ox/cs/rsacomb/CanonicalModel.scala @@ -118,10 +118,6 @@ class CanonicalModel(val ontology: RSAOntology) { .getIRI TupleTableAtom.rdf(v0, IRI.RDF_TYPE, cls) } - // TODO: To be consistent with the specifics of the visitor we are - // returning facts as `Rule`s with true body. While this is correct - // there is an easier way to import facts into RDFox. Are we able to - // do that? val facts = unfold map RSA.In val rules = List( Rule.create(roleRf, atomA, RSA.NotIn(varX)), diff --git a/src/main/scala/uk/ac/ox/cs/rsacomb/RSAOntology.scala b/src/main/scala/uk/ac/ox/cs/rsacomb/RSAOntology.scala index 3527da5..c7b3bf0 100644 --- a/src/main/scala/uk/ac/ox/cs/rsacomb/RSAOntology.scala +++ b/src/main/scala/uk/ac/ox/cs/rsacomb/RSAOntology.scala @@ -459,7 +459,6 @@ class RSAOntology(val original: OWLOntology, val datafiles: File*) { Logger.DEBUG ) - // TODO: the following functions needs testing def confl( role: OWLObjectPropertyExpression ): Set[OWLObjectPropertyExpression] = { @@ -655,7 +654,6 @@ class RSAOntology(val original: OWLOntology, val datafiles: File*) { // We just need the TBox to find val terms = for { axiom1 <- tbox - // TODO: is this an optimization or an error? if axiom1.isT5 // We expect only one role coming out of a T5 axiom roleS <- axiom1.objectPropertyExpressionsInSignature diff --git a/src/main/scala/uk/ac/ox/cs/rsacomb/converter/RDFoxConverter.scala b/src/main/scala/uk/ac/ox/cs/rsacomb/converter/RDFoxConverter.scala index c9bed35..3fac46f 100644 --- a/src/main/scala/uk/ac/ox/cs/rsacomb/converter/RDFoxConverter.scala +++ b/src/main/scala/uk/ac/ox/cs/rsacomb/converter/RDFoxConverter.scala @@ -23,13 +23,6 @@ import uk.ac.ox.cs.rsacomb.util.{RSA, RDFoxUtil} * @note the input axioms are assumed to be normalized. Trying to * convert non normalized axioms might result in undefined behavious. * We use the normalization defined in the main paper. - * - * @see [[https://github.com/KRR-Oxford/RSA-combined-approach GitHub repository]] - * for more information on the theoretical aspects of the system. - * - * @todo this is not ideal and it would be more sensible to prepend a - * normalization procedure that will prevent errors or unexpected - * results. */ trait RDFoxConverter { @@ -358,7 +351,6 @@ trait RDFoxConverter { */ case e: OWLDataSomeValuesFrom => { val role = e.getProperty() - // TODO: simplify this: // Computes the result of rule skolemization. Depending on the used // technique it might involve the introduction of additional atoms, // and/or fresh constants and variables. -- cgit v1.2.3