diff options
author | noroadsleft <18669334+noroadsleft@users.noreply.github.com> | 2018-08-17 16:12:22 -0700 |
---|---|---|
committer | Drashna Jaelre <drashna@live.com> | 2018-08-17 16:12:22 -0700 |
commit | 19fdfccca28f923a12351fbee6c8c8282dca004e (patch) | |
tree | cfd4f63a47fbdb4bcfaeb0738956738582c5d4bf | |
parent | 9175eebc8796f31a481ba16b1ca2ba9e4432502e (diff) | |
download | qmk_firmware-19fdfccca28f923a12351fbee6c8c8282dca004e.tar.gz qmk_firmware-19fdfccca28f923a12351fbee6c8c8282dca004e.zip |
Keyboard: Ckeys refactor (#3681)
* Obelus Refactor: LAYOUT to LAYOUT_ortho_4x4
- Keymap also now uses #include QMK_KEYBOARD_H
- Readability and white space changes
- rules.mk now has LAYOUTS = ortho_4x4
- added info.json
* naKey Refactor: LAYOUT to LAYOUT_numpad_5x4
- Matrix LAYOUT renamed to LAYOUT_numpad_5x4
- Now supports community layout numpad_5x4
- White space changes
* naKey Configurator update
Updated order of JSON objects to match new matrix order.
-rw-r--r-- | keyboards/ckeys/nakey/info.json | 6 | ||||
-rw-r--r-- | keyboards/ckeys/nakey/keymaps/default/keymap.c | 35 | ||||
-rw-r--r-- | keyboards/ckeys/nakey/nakey.h | 13 | ||||
-rw-r--r-- | keyboards/ckeys/nakey/rules.mk | 2 | ||||
-rw-r--r-- | keyboards/ckeys/obelus/info.json | 13 | ||||
-rw-r--r-- | keyboards/ckeys/obelus/keymaps/default/keymap.c | 75 | ||||
-rw-r--r-- | keyboards/ckeys/obelus/obelus.h | 2 | ||||
-rw-r--r-- | keyboards/ckeys/obelus/rules.mk | 2 |
8 files changed, 81 insertions, 67 deletions
diff --git a/keyboards/ckeys/nakey/info.json b/keyboards/ckeys/nakey/info.json index b44d0daf7..093e61d0e 100644 --- a/keyboards/ckeys/nakey/info.json +++ b/keyboards/ckeys/nakey/info.json | |||
@@ -5,8 +5,8 @@ | |||
5 | "width": 4, | 5 | "width": 4, |
6 | "height": 5, | 6 | "height": 5, |
7 | "layouts": { | 7 | "layouts": { |
8 | "LAYOUT": { | 8 | "LAYOUT_numpad_5x4": { |
9 | "layout": [{"label":"Num Lock", "x":0, "y":0}, {"label":"/", "x":1, "y":0}, {"label":"*", "x":2, "y":0}, {"label":"-", "x":3, "y":0}, {"label":"7", "x":0, "y":1}, {"label":"8", "x":1, "y":1}, {"label":"9", "x":2, "y":1}, {"label":"+", "x":3, "y":1, "h":2}, {"label":"4", "x":0, "y":2}, {"label":"5", "x":1, "y":2}, {"label":"6", "x":2, "y":2}, {"label":"1", "x":0, "y":3}, {"label":"2", "x":1, "y":3}, {"label":"3", "x":2, "y":3}, {"label":"Enter", "x":3, "y":3, "h":2}, {"label":"0", "x":0, "y":4, "w":2}, {"label":".", "x":2, "y":4}] | 9 | "layout": [{"label":"Num Lock", "x":0, "y":0}, {"label":"/", "x":1, "y":0}, {"label":"*", "x":2, "y":0}, {"label":"-", "x":3, "y":0}, {"label":"7", "x":0, "y":1}, {"label":"8", "x":1, "y":1}, {"label":"9", "x":2, "y":1}, {"label":"4", "x":0, "y":2}, {"label":"5", "x":1, "y":2}, {"label":"6", "x":2, "y":2}, {"label":"+", "x":3, "y":1, "h":2}, {"label":"1", "x":0, "y":3}, {"label":"2", "x":1, "y":3}, {"label":"3", "x":2, "y":3}, {"label":"0", "x":0, "y":4, "w":2}, {"label":".", "x":2, "y":4}, {"label":"Enter", "x":3, "y":3, "h":2}] |
10 | } | 10 | } |
11 | } | 11 | } |
12 | } | 12 | } |
diff --git a/keyboards/ckeys/nakey/keymaps/default/keymap.c b/keyboards/ckeys/nakey/keymaps/default/keymap.c index ebbb128bd..9c3e45b94 100644 --- a/keyboards/ckeys/nakey/keymaps/default/keymap.c +++ b/keyboards/ckeys/nakey/keymaps/default/keymap.c | |||
@@ -16,32 +16,31 @@ | |||
16 | #include QMK_KEYBOARD_H | 16 | #include QMK_KEYBOARD_H |
17 | 17 | ||
18 | const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | 18 | const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { |
19 | [0] = LAYOUT( /* Base */ | 19 | [0] = LAYOUT_numpad_5x4( /* Base */ |
20 | KC_NLCK, KC_PSLS, KC_PAST, KC_PMNS, \ | 20 | KC_NLCK, KC_PSLS, KC_PAST, KC_PMNS, \ |
21 | KC_P7, KC_P8, KC_P9, KC_PPLS, \ | 21 | KC_P7, KC_P8, KC_P9, \ |
22 | KC_P4, KC_P5, KC_P6, \ | 22 | KC_P4, KC_P5, KC_P6, KC_PPLS, \ |
23 | KC_P1, KC_P2, KC_P3, KC_PENT, \ | 23 | KC_P1, KC_P2, KC_P3, \ |
24 | KC_P0, KC_PDOT \ | 24 | KC_P0, KC_PDOT, KC_PENT \ |
25 | ), | 25 | ), |
26 | }; | 26 | }; |
27 | 27 | ||
28 | const uint16_t PROGMEM fn_actions[] = { | 28 | const uint16_t PROGMEM fn_actions[] = { |
29 | 29 | ||
30 | }; | 30 | }; |
31 | 31 | ||
32 | const macro_t *action_get_macro(keyrecord_t *record, uint8_t id, uint8_t opt) | 32 | const macro_t *action_get_macro(keyrecord_t *record, uint8_t id, uint8_t opt) { |
33 | { | ||
34 | // MACRODOWN only works in this function | 33 | // MACRODOWN only works in this function |
35 | switch(id) { | 34 | switch(id) { |
36 | case 0: | 35 | case 0: |
37 | if (record->event.pressed) { | 36 | if (record->event.pressed) { |
38 | register_code(KC_RSFT); | 37 | register_code(KC_RSFT); |
39 | } else { | 38 | } else { |
40 | unregister_code(KC_RSFT); | 39 | unregister_code(KC_RSFT); |
41 | } | ||
42 | break; | ||
43 | } | 40 | } |
44 | return MACRO_NONE; | 41 | break; |
42 | } | ||
43 | return MACRO_NONE; | ||
45 | }; | 44 | }; |
46 | 45 | ||
47 | 46 | ||
diff --git a/keyboards/ckeys/nakey/nakey.h b/keyboards/ckeys/nakey/nakey.h index 3cbfda844..bbf531fb6 100644 --- a/keyboards/ckeys/nakey/nakey.h +++ b/keyboards/ckeys/nakey/nakey.h | |||
@@ -22,14 +22,13 @@ | |||
22 | // The following is an example using the Planck MIT layout | 22 | // The following is an example using the Planck MIT layout |
23 | // The first section contains all of the arguments | 23 | // The first section contains all of the arguments |
24 | // The second converts the arguments into a two-dimensional array | 24 | // The second converts the arguments into a two-dimensional array |
25 | #define LAYOUT( \ | 25 | #define LAYOUT_numpad_5x4( \ |
26 | k00, k01, k02, k03, \ | 26 | k00, k01, k02, k03, \ |
27 | k10, k11, k12, k13, \ | 27 | k10, k11, k12, \ |
28 | k20, k21, k22, \ | 28 | k20, k21, k22, k13, \ |
29 | k30, k31, k32, k33, \ | 29 | k30, k31, k32, \ |
30 | k40, k41 \ | 30 | k40, k41, k33 \ |
31 | ) \ | 31 | ) { \ |
32 | { \ | ||
33 | { k00, k01, k02, k03 }, \ | 32 | { k00, k01, k02, k03 }, \ |
34 | { k10, k11, k12, k13 }, \ | 33 | { k10, k11, k12, k13 }, \ |
35 | { k20, k21, k22, KC_NO }, \ | 34 | { k20, k21, k22, KC_NO }, \ |
diff --git a/keyboards/ckeys/nakey/rules.mk b/keyboards/ckeys/nakey/rules.mk index a3571e8de..36b2193aa 100644 --- a/keyboards/ckeys/nakey/rules.mk +++ b/keyboards/ckeys/nakey/rules.mk | |||
@@ -66,3 +66,5 @@ UNICODE_ENABLE ?= no # Unicode | |||
66 | BLUETOOTH_ENABLE ?= no # Enable Bluetooth with the Adafruit EZ-Key HID | 66 | BLUETOOTH_ENABLE ?= no # Enable Bluetooth with the Adafruit EZ-Key HID |
67 | AUDIO_ENABLE ?= no # Audio output on port C6 | 67 | AUDIO_ENABLE ?= no # Audio output on port C6 |
68 | FAUXCLICKY_ENABLE ?= no # Use buzzer to emulate clicky switches | 68 | FAUXCLICKY_ENABLE ?= no # Use buzzer to emulate clicky switches |
69 | |||
70 | LAYOUTS = numpad_5x4 | ||
diff --git a/keyboards/ckeys/obelus/info.json b/keyboards/ckeys/obelus/info.json new file mode 100644 index 000000000..70d2f7e7e --- /dev/null +++ b/keyboards/ckeys/obelus/info.json | |||
@@ -0,0 +1,13 @@ | |||
1 | { | ||
2 | "keyboard_name": "Obelus", | ||
3 | "url": "", | ||
4 | "maintainer": "qmk", | ||
5 | "width": 4, | ||
6 | "height": 4, | ||
7 | "layouts": { | ||
8 | "LAYOUT_ortho_4x4": { | ||
9 | "key_count": 16, | ||
10 | "layout": [{"x":0, "y":0}, {"x":1, "y":0}, {"x":2, "y":0}, {"x":3, "y":0}, {"x":0, "y":1}, {"x":1, "y":1}, {"x":2, "y":1}, {"x":3, "y":1}, {"x":0, "y":2}, {"x":1, "y":2}, {"x":2, "y":2}, {"x":3, "y":2}, {"x":0, "y":3}, {"x":1, "y":3}, {"x":2, "y":3}, {"x":3, "y":3}] | ||
11 | } | ||
12 | } | ||
13 | } | ||
diff --git a/keyboards/ckeys/obelus/keymaps/default/keymap.c b/keyboards/ckeys/obelus/keymaps/default/keymap.c index c2c8e4a05..bdad1caca 100644 --- a/keyboards/ckeys/obelus/keymaps/default/keymap.c +++ b/keyboards/ckeys/obelus/keymaps/default/keymap.c | |||
@@ -1,5 +1,4 @@ | |||
1 | #include "obelus.h" | 1 | #include QMK_KEYBOARD_H |
2 | #include "action_layer.h" | ||
3 | #ifdef AUDIO_ENABLE | 2 | #ifdef AUDIO_ENABLE |
4 | #include "audio.h" | 3 | #include "audio.h" |
5 | #endif | 4 | #endif |
@@ -18,12 +17,12 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | |||
18 | * | | | | | | 17 | * | | | | | |
19 | * `---------------------- ' | 18 | * `---------------------- ' |
20 | */ | 19 | */ |
21 | [0] = LAYOUT( /* LAYER SELECT */ | 20 | [0] = LAYOUT_ortho_4x4( /* LAYER SELECT */ |
22 | KC_TRNS, KC_TRNS, KC_TRNS, RESET, \ | 21 | _______, _______, _______, RESET, \ |
23 | TO(4), KC_TRNS, KC_TRNS, KC_TRNS, \ | 22 | TO(4), _______, _______, _______, \ |
24 | TO(1), TO(2), TO(3), KC_TRNS, \ | 23 | TO(1), TO(2), TO(3), _______, \ |
25 | KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS \ | 24 | _______, _______, _______, _______ \ |
26 | ), | 25 | ), |
27 | /* NUMPAD | 26 | /* NUMPAD |
28 | * ,-----------------------. | 27 | * ,-----------------------. |
29 | * | 7 | 8 | 9 | * | | 28 | * | 7 | 8 | 9 | * | |
@@ -35,12 +34,12 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | |||
35 | * | 0 | . | / | = | | 34 | * | 0 | . | / | = | |
36 | * `---------------------- ' | 35 | * `---------------------- ' |
37 | */ | 36 | */ |
38 | [1] = LAYOUT( /* NUMPAD */ | 37 | [1] = LAYOUT_ortho_4x4( /* NUMPAD */ |
39 | KC_P7, KC_P8, KC_P9, KC_PAST, \ | 38 | KC_P7, KC_P8, KC_P9, KC_PAST, \ |
40 | KC_P4, KC_P5, KC_P6, KC_PMNS, \ | 39 | KC_P4, KC_P5, KC_P6, KC_PMNS, \ |
41 | KC_P1, KC_P2, KC_P3, KC_PPLS, \ | 40 | KC_P1, KC_P2, KC_P3, KC_PPLS, \ |
42 | KC_P0, KC_PDOT, KC_PSLS, LT(5,KC_PENT) \ | 41 | KC_P0, KC_PDOT, KC_PSLS, LT(5, KC_PENT) \ |
43 | ), | 42 | ), |
44 | /* NUMPAD SUPPLEMENT | 43 | /* NUMPAD SUPPLEMENT |
45 | * ,-----------------------. | 44 | * ,-----------------------. |
46 | * |NUMLK| | | | | 45 | * |NUMLK| | | | |
@@ -52,12 +51,12 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | |||
52 | * | | | | | | 51 | * | | | | | |
53 | * `---------------------- ' | 52 | * `---------------------- ' |
54 | */ | 53 | */ |
55 | [5] = LAYOUT( /* NUMPAD SUPPLEMENT */ | 54 | [5] = LAYOUT_ortho_4x4( /* NUMPAD SUPPLEMENT */ |
56 | KC_NLCK, KC_TRNS, KC_TRNS, TO(0), \ | 55 | KC_NLCK, _______, _______, TO(0), \ |
57 | KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, \ | 56 | _______, _______, _______, _______, \ |
58 | KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, \ | 57 | _______, _______, _______, _______, \ |
59 | KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS \ | 58 | _______, _______, _______, _______ \ |
60 | ), | 59 | ), |
61 | /* NAV | 60 | /* NAV |
62 | * ,-----------------------. | 61 | * ,-----------------------. |
63 | * | INS |PGUP | TAB |PRSCR| | 62 | * | INS |PGUP | TAB |PRSCR| |
@@ -69,12 +68,12 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | |||
69 | * |LEFT |DOWN |RIGHT|ENTER| | 68 | * |LEFT |DOWN |RIGHT|ENTER| |
70 | * `---------------------- ' | 69 | * `---------------------- ' |
71 | */ | 70 | */ |
72 | [2] = LAYOUT( /* NAV CLUSTER */ | 71 | [2] = LAYOUT_ortho_4x4( /* NAV CLUSTER */ |
73 | KC_INS, KC_PGUP, KC_TAB, KC_PSCR, \ | 72 | KC_INS, KC_PGUP, KC_TAB, KC_PSCR, \ |
74 | KC_DEL, KC_PGDN, KC_VOLD, KC_VOLU, \ | 73 | KC_DEL, KC_PGDN, KC_VOLD, KC_VOLU, \ |
75 | KC_HOME, KC_UP, KC_END, TO(0), \ | 74 | KC_HOME, KC_UP, KC_END, TO(0), \ |
76 | KC_LEFT, KC_DOWN, KC_RGHT, KC_ENT \ | 75 | KC_LEFT, KC_DOWN, KC_RGHT, KC_ENT \ |
77 | ), | 76 | ), |
78 | /* GAMING | 77 | /* GAMING |
79 | * ,-----------------------. | 78 | * ,-----------------------. |
80 | * | ESC | 1 | 2 | 3 | | 79 | * | ESC | 1 | 2 | 3 | |
@@ -86,12 +85,12 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | |||
86 | * |CTRL | C | R |SPACE| | 85 | * |CTRL | C | R |SPACE| |
87 | * `---------------------- ' | 86 | * `---------------------- ' |
88 | */ | 87 | */ |
89 | [3] = LAYOUT( /* GAMING */ | 88 | [3] = LAYOUT_ortho_4x4( /* GAMING */ |
90 | LT(4, KC_ESC), KC_1, KC_2, KC_3, \ | 89 | LT(4, KC_ESC), KC_1, KC_2, KC_3, \ |
91 | KC_TAB, KC_Q, KC_W, KC_E, \ | 90 | KC_TAB, KC_Q, KC_W, KC_E, \ |
92 | KC_LSFT, KC_A, KC_S, KC_D, \ | 91 | KC_LSFT, KC_A, KC_S, KC_D, \ |
93 | KC_LCTL, KC_C, KC_R, KC_SPC \ | 92 | KC_LCTL, KC_C, KC_R, KC_SPC \ |
94 | ), | 93 | ), |
95 | /* MUSIC | 94 | /* MUSIC |
96 | * ,-----------------------. | 95 | * ,-----------------------. |
97 | * | | | | | | 96 | * | | | | | |
@@ -103,12 +102,12 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | |||
103 | * |TOGGL|MODE | | | | 102 | * |TOGGL|MODE | | | |
104 | * `---------------------- ' | 103 | * `---------------------- ' |
105 | */ | 104 | */ |
106 | [4] = LAYOUT( /* NUMPAD SUPPLEMENT */ | 105 | [4] = LAYOUT_ortho_4x4( /* NUMPAD SUPPLEMENT */ |
107 | KC_NO, KC_NO, KC_NO, KC_NO, \ | 106 | XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, \ |
108 | KC_NO, KC_NO, KC_NO, KC_NO, \ | 107 | XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, \ |
109 | KC_NO, KC_NO, KC_NO, KC_NO, \ | 108 | XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, \ |
110 | MU_TOG, MU_MOD, KC_NO, TO(0) \ | 109 | MU_TOG, MU_MOD, XXXXXXX, TO(0) \ |
111 | ), | 110 | ), |
112 | }; | 111 | }; |
113 | 112 | ||
114 | bool process_record_user(uint16_t keycode, keyrecord_t *record) { | 113 | bool process_record_user(uint16_t keycode, keyrecord_t *record) { |
diff --git a/keyboards/ckeys/obelus/obelus.h b/keyboards/ckeys/obelus/obelus.h index 21bc4d723..371b79df2 100644 --- a/keyboards/ckeys/obelus/obelus.h +++ b/keyboards/ckeys/obelus/obelus.h | |||
@@ -7,7 +7,7 @@ | |||
7 | // The following is an example using the Planck MIT layout | 7 | // The following is an example using the Planck MIT layout |
8 | // The first section contains all of the arguements | 8 | // The first section contains all of the arguements |
9 | // The second converts the arguments into a two-dimensional array | 9 | // The second converts the arguments into a two-dimensional array |
10 | #define LAYOUT( \ | 10 | #define LAYOUT_ortho_4x4( \ |
11 | k00, k01, k02, k03, \ | 11 | k00, k01, k02, k03, \ |
12 | k10, k11, k12, k13, \ | 12 | k10, k11, k12, k13, \ |
13 | k20, k21, k22, k23, \ | 13 | k20, k21, k22, k23, \ |
diff --git a/keyboards/ckeys/obelus/rules.mk b/keyboards/ckeys/obelus/rules.mk index d999b118c..f40610ee9 100644 --- a/keyboards/ckeys/obelus/rules.mk +++ b/keyboards/ckeys/obelus/rules.mk | |||
@@ -66,3 +66,5 @@ UNICODE_ENABLE = no # Unicode | |||
66 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 66 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
67 | AUDIO_ENABLE = yes # Audio output on port C6 | 67 | AUDIO_ENABLE = yes # Audio output on port C6 |
68 | FAUXCLICKY_ENABLE = no # Use buzzer to emulate clicky switches | 68 | FAUXCLICKY_ENABLE = no # Use buzzer to emulate clicky switches |
69 | |||
70 | LAYOUTS = ortho_4x4 | ||