aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Challis <git@zvecr.com>2020-11-16 03:16:42 +0000
committerGitHub <noreply@github.com>2020-11-16 14:16:42 +1100
commit94e94ffb5bbe61b5da4aad205016923746010b23 (patch)
tree023656aea94e118551bc4e991a3f5dd272db04da
parentcfc9a358c584e65782b2dade05d31700719a18e7 (diff)
downloadqmk_firmware-94e94ffb5bbe61b5da4aad205016923746010b23.tar.gz
qmk_firmware-94e94ffb5bbe61b5da4aad205016923746010b23.zip
Recommend use of LED Indicator config (#10895)
* Recommend use of LED Indicator config * Recommend use of LED Indicator config - update link * Update quantum/template/ps2avrgb/config.h Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
-rw-r--r--docs/pr_checklist.md1
-rw-r--r--quantum/template/avr/config.h6
-rw-r--r--quantum/template/ps2avrgb/config.h6
3 files changed, 12 insertions, 1 deletions
diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md
index 22e8a3fe1..e0dd0770c 100644
--- a/docs/pr_checklist.md
+++ b/docs/pr_checklist.md
@@ -73,6 +73,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard
73 - commented-out functions removed too 73 - commented-out functions removed too
74 - `matrix_init_board()` etc. migrated to `keyboard_pre_init_kb()`, see: [keyboard_pre_init*](https://docs.qmk.fm/#/custom_quantum_functions?id=keyboard_pre_init_-function-documentation) 74 - `matrix_init_board()` etc. migrated to `keyboard_pre_init_kb()`, see: [keyboard_pre_init*](https://docs.qmk.fm/#/custom_quantum_functions?id=keyboard_pre_init_-function-documentation)
75 - prefer `CUSTOM_MATRIX = lite` if custom matrix used, allows for standard debounce, see [custom matrix 'lite'](https://docs.qmk.fm/#/custom_matrix?id=lite) 75 - prefer `CUSTOM_MATRIX = lite` if custom matrix used, allows for standard debounce, see [custom matrix 'lite'](https://docs.qmk.fm/#/custom_matrix?id=lite)
76 - prefer LED indicator [Configuration Options](https://docs.qmk.fm/#/feature_led_indicators?id=configuration-options) to custom `led_update_*()` implementations where possible
76- `keyboard.h` 77- `keyboard.h`
77 - `#include "quantum.h"` appears at the top 78 - `#include "quantum.h"` appears at the top
78 - `LAYOUT` macros should use standard definitions if applicable 79 - `LAYOUT` macros should use standard definitions if applicable
diff --git a/quantum/template/avr/config.h b/quantum/template/avr/config.h
index 5f0bc7363..4192bbcfa 100644
--- a/quantum/template/avr/config.h
+++ b/quantum/template/avr/config.h
@@ -52,6 +52,12 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
52 */ 52 */
53#define SOFT_SERIAL_PIN D0 // or D1, D2, D3, E6 53#define SOFT_SERIAL_PIN D0 // or D1, D2, D3, E6
54 54
55//#define LED_NUM_LOCK_PIN B0
56//#define LED_CAPS_LOCK_PIN B1
57//#define LED_SCROLL_LOCK_PIN B2
58//#define LED_COMPOSE_PIN B3
59//#define LED_KANA_PIN B4
60
55//#define BACKLIGHT_PIN B7 61//#define BACKLIGHT_PIN B7
56//#define BACKLIGHT_LEVELS 3 62//#define BACKLIGHT_LEVELS 3
57//#define BACKLIGHT_BREATHING 63//#define BACKLIGHT_BREATHING
diff --git a/quantum/template/ps2avrgb/config.h b/quantum/template/ps2avrgb/config.h
index ef065c0f1..6150bcce6 100644
--- a/quantum/template/ps2avrgb/config.h
+++ b/quantum/template/ps2avrgb/config.h
@@ -47,8 +47,12 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
47/* COL2ROW, ROW2COL */ 47/* COL2ROW, ROW2COL */
48#define DIODE_DIRECTION COL2ROW 48#define DIODE_DIRECTION COL2ROW
49 49
50//#define LED_NUM_LOCK_PIN D0
51//#define LED_CAPS_LOCK_PIN D1
52//#define LED_SCROLL_LOCK_PIN D6
53
50#define BACKLIGHT_PIN D4 54#define BACKLIGHT_PIN D4
51#define BACKLIGHT_LEVELS 3 55//#define BACKLIGHT_LEVELS 3
52//#define BACKLIGHT_BREATHING 56//#define BACKLIGHT_BREATHING
53 57
54#define RGBLED_NUM 16 58#define RGBLED_NUM 16