diff options
| author | mtei <2170248+mtei@users.noreply.github.com> | 2018-10-19 01:30:48 +0900 |
|---|---|---|
| committer | Drashna Jaelre <drashna@live.com> | 2018-10-18 13:52:41 -0700 |
| commit | db03b76910c486cd27c175ae85efeeaa183b1c98 (patch) | |
| tree | db2f07f78dc69f61a77bc27835272941890c9339 | |
| parent | 14bdd5ed2a808075130bac26fc72dcb9b158ae2c (diff) | |
| download | qmk_firmware-db03b76910c486cd27c175ae85efeeaa183b1c98.tar.gz qmk_firmware-db03b76910c486cd27c175ae85efeeaa183b1c98.zip | |
optimize rgblight_effect_alternating(void)
rgblight_effect_alternating (void) calls rgblight_sethsv_at () RGBLED_NUM times. As a result, rgblight_set () is called RGBLED_NUM + 1 times. This is wasteful processing.
| -rw-r--r-- | quantum/rgblight.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/quantum/rgblight.c b/quantum/rgblight.c index 03f77cc80..94e9c0a3b 100644 --- a/quantum/rgblight.c +++ b/quantum/rgblight.c | |||
| @@ -860,13 +860,13 @@ void rgblight_effect_alternating(void){ | |||
| 860 | last_timer = timer_read(); | 860 | last_timer = timer_read(); |
| 861 | 861 | ||
| 862 | for(int i = 0; i<RGBLED_NUM; i++){ | 862 | for(int i = 0; i<RGBLED_NUM; i++){ |
| 863 | if(i<RGBLED_NUM/2 && pos){ | 863 | if(i<RGBLED_NUM/2 && pos){ |
| 864 | rgblight_sethsv_at(rgblight_config.hue, rgblight_config.sat, rgblight_config.val, i); | 864 | sethsv(rgblight_config.hue, rgblight_config.sat, rgblight_config.val, (LED_TYPE *)&led[i]); |
| 865 | }else if (i>=RGBLED_NUM/2 && !pos){ | 865 | }else if (i>=RGBLED_NUM/2 && !pos){ |
| 866 | rgblight_sethsv_at(rgblight_config.hue, rgblight_config.sat, rgblight_config.val, i); | 866 | sethsv(rgblight_config.hue, rgblight_config.sat, rgblight_config.val, (LED_TYPE *)&led[i]); |
| 867 | }else{ | 867 | }else{ |
| 868 | rgblight_sethsv_at(rgblight_config.hue, rgblight_config.sat, 0, i); | 868 | sethsv(rgblight_config.hue, rgblight_config.sat, 0, (LED_TYPE *)&led[i]); |
| 869 | } | 869 | } |
| 870 | } | 870 | } |
| 871 | rgblight_set(); | 871 | rgblight_set(); |
| 872 | pos = (pos + 1) % 2; | 872 | pos = (pos + 1) % 2; |