Helix: Move definition of LAYOUT_kc to each revision. (#3333)

3 files changed, 109 insertions, 78 deletions

diff --git a/keyboards/helix/helix.h b/keyboards/helix/helix.h
index 46e61c7b8..36d12ef86 100644
--- a/keyboards/helix/helix.h
+++ b/keyboards/helix/helix.h
@@ -8,48 +8,6 @@
     #include "rev2.h"
 #endif
 
-#if HELIX_ROWS == 3
-  #define LAYOUT_kc( \
-      L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, \
-      L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, \
-      L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, \
-      ) \
-      LAYOUT( \
-          KC_##L00, KC_##L01, KC_##L02, KC_##L03, KC_##L04, KC_##L05, KC_##R00, KC_##R01, KC_##R02, KC_##R03, KC_##R04, KC_##R05, \
-          KC_##L10, KC_##L11, KC_##L12, KC_##L13, KC_##L14, KC_##L15, KC_##R10, KC_##R11, KC_##R12, KC_##R13, KC_##R14, KC_##R15, \
-          KC_##L20, KC_##L21, KC_##L22, KC_##L23, KC_##L24, KC_##L25, KC_##R20, KC_##R21, KC_##R22, KC_##R23, KC_##R24, KC_##R25, \
-      )
-#elif HELIX_ROWS == 4
-  // Used to create a keymap using only KC_ prefixed keys
-  #define LAYOUT_kc( \
-      L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, \
-      L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, \
-      L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, \
-      L30, L31, L32, L33, L34, L35, R30, R31, R32, R33, R34, R35 \
-      ) \
-      LAYOUT( \
-          KC_##L00, KC_##L01, KC_##L02, KC_##L03, KC_##L04, KC_##L05, KC_##R00, KC_##R01, KC_##R02, KC_##R03, KC_##R04, KC_##R05, \
-          KC_##L10, KC_##L11, KC_##L12, KC_##L13, KC_##L14, KC_##L15, KC_##R10, KC_##R11, KC_##R12, KC_##R13, KC_##R14, KC_##R15, \
-          KC_##L20, KC_##L21, KC_##L22, KC_##L23, KC_##L24, KC_##L25, KC_##R20, KC_##R21, KC_##R22, KC_##R23, KC_##R24, KC_##R25, \
-          KC_##L30, KC_##L31, KC_##L32, KC_##L33, KC_##L34, KC_##L35, KC_##R30, KC_##R31, KC_##R32, KC_##R33, KC_##R34, KC_##R35 \
-      )
-#else
-  #define LAYOUT_kc( \
-      L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, \
-      L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, \
-      L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, \
-      L30, L31, L32, L33, L34, L35, R30, R31, R32, R33, R34, R35, \
-      L40, L41, L42, L43, L44, L45, R40, R41, R42, R43, R44, R45 \
-      ) \
-      LAYOUT( \
-          KC_##L00, KC_##L01, KC_##L02, KC_##L03, KC_##L04, KC_##L05, KC_##R00, KC_##R01, KC_##R02, KC_##R03, KC_##R04, KC_##R05, \
-          KC_##L10, KC_##L11, KC_##L12, KC_##L13, KC_##L14, KC_##L15, KC_##R10, KC_##R11, KC_##R12, KC_##R13, KC_##R14, KC_##R15, \
-          KC_##L20, KC_##L21, KC_##L22, KC_##L23, KC_##L24, KC_##L25, KC_##R20, KC_##R21, KC_##R22, KC_##R23, KC_##R24, KC_##R25, \
-          KC_##L30, KC_##L31, KC_##L32, KC_##L33, KC_##L34, KC_##L35, KC_##R30, KC_##R31, KC_##R32, KC_##R33, KC_##R34, KC_##R35, \
-          KC_##L40, KC_##L41, KC_##L42, KC_##L43, KC_##L44, KC_##L45, KC_##R40, KC_##R41, KC_##R42, KC_##R43, KC_##R44, KC_##R45 \
-      )
-#endif
-
 #include "quantum.h"
 
 #endif
diff --git a/keyboards/helix/rev1/rev1.h b/keyboards/helix/rev1/rev1.h
index 0245859a2..48300a454 100644
--- a/keyboards/helix/rev1/rev1.h
+++ b/keyboards/helix/rev1/rev1.h
@@ -10,8 +10,8 @@
 #ifdef USE_I2C
 #include <stddef.h>
 #ifdef __AVR__
-        #include <avr/io.h>
-        #include <avr/interrupt.h>
+  #include <avr/io.h>
+  #include <avr/interrupt.h>
 #endif
 #endif
 
@@ -142,4 +142,46 @@
   #error "expected HELIX_ROWS 3 or 4 or 5"
 #endif
 
+// Used to create a keymap using only KC_ prefixed keys
+#if HELIX_ROWS == 3
+  #define LAYOUT_kc( \
+    L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, \
+    L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, \
+    L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, \
+    ) \
+    LAYOUT( \
+      KC_##L00, KC_##L01, KC_##L02, KC_##L03, KC_##L04, KC_##L05, KC_##R00, KC_##R01, KC_##R02, KC_##R03, KC_##R04, KC_##R05, \
+      KC_##L10, KC_##L11, KC_##L12, KC_##L13, KC_##L14, KC_##L15, KC_##R10, KC_##R11, KC_##R12, KC_##R13, KC_##R14, KC_##R15, \
+      KC_##L20, KC_##L21, KC_##L22, KC_##L23, KC_##L24, KC_##L25, KC_##R20, KC_##R21, KC_##R22, KC_##R23, KC_##R24, KC_##R25, \
+    )
+#elif HELIX_ROWS == 4
+  #define LAYOUT_kc( \
+    L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, \
+    L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, \
+    L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, \
+    L30, L31, L32, L33, L34, L35, R30, R31, R32, R33, R34, R35 \
+    ) \
+    LAYOUT( \
+      KC_##L00, KC_##L01, KC_##L02, KC_##L03, KC_##L04, KC_##L05, KC_##R00, KC_##R01, KC_##R02, KC_##R03, KC_##R04, KC_##R05, \
+      KC_##L10, KC_##L11, KC_##L12, KC_##L13, KC_##L14, KC_##L15, KC_##R10, KC_##R11, KC_##R12, KC_##R13, KC_##R14, KC_##R15, \
+      KC_##L20, KC_##L21, KC_##L22, KC_##L23, KC_##L24, KC_##L25, KC_##R20, KC_##R21, KC_##R22, KC_##R23, KC_##R24, KC_##R25, \
+      KC_##L30, KC_##L31, KC_##L32, KC_##L33, KC_##L34, KC_##L35, KC_##R30, KC_##R31, KC_##R32, KC_##R33, KC_##R34, KC_##R35 \
+    )
+#else
+  #define LAYOUT_kc( \
+    L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, \
+    L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, \
+    L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, \
+    L30, L31, L32, L33, L34, L35, R30, R31, R32, R33, R34, R35, \
+    L40, L41, L42, L43, L44, L45, R40, R41, R42, R43, R44, R45 \
+    ) \
+    LAYOUT( \
+      KC_##L00, KC_##L01, KC_##L02, KC_##L03, KC_##L04, KC_##L05, KC_##R00, KC_##R01, KC_##R02, KC_##R03, KC_##R04, KC_##R05, \
+      KC_##L10, KC_##L11, KC_##L12, KC_##L13, KC_##L14, KC_##L15, KC_##R10, KC_##R11, KC_##R12, KC_##R13, KC_##R14, KC_##R15, \
+      KC_##L20, KC_##L21, KC_##L22, KC_##L23, KC_##L24, KC_##L25, KC_##R20, KC_##R21, KC_##R22, KC_##R23, KC_##R24, KC_##R25, \
+      KC_##L30, KC_##L31, KC_##L32, KC_##L33, KC_##L34, KC_##L35, KC_##R30, KC_##R31, KC_##R32, KC_##R33, KC_##R34, KC_##R35, \
+      KC_##L40, KC_##L41, KC_##L42, KC_##L43, KC_##L44, KC_##L45, KC_##R40, KC_##R41, KC_##R42, KC_##R43, KC_##R44, KC_##R45 \
+    )
+#endif
+
 #endif
diff --git a/keyboards/helix/rev2/rev2.h b/keyboards/helix/rev2/rev2.h
index 2a789d66f..a2a1fb746 100644
--- a/keyboards/helix/rev2/rev2.h
+++ b/keyboards/helix/rev2/rev2.h
@@ -14,8 +14,8 @@
 #ifdef USE_I2C
 #include <stddef.h>
 #ifdef __AVR__
-        #include <avr/io.h>
-        #include <avr/interrupt.h>
+  #include <avr/io.h>
+  #include <avr/interrupt.h>
 #endif
 #endif
 
@@ -27,40 +27,40 @@
 // Standard Keymap
 // (TRRS jack on the left half is to the right, TRRS jack on the right half is to the left)
 #define LAYOUT( \
-        L00, L01, L02, L03, L04, L05,           R00, R01, R02, R03, R04, R05, \
-        L10, L11, L12, L13, L14, L15,           R10, R11, R12, R13, R14, R15, \
-        L20, L21, L22, L23, L24, L25,           R20, R21, R22, R23, R24, R25, \
-        L30, L31, L32, L33, L34, L35, L36, R36, R30, R31, R32, R33, R34, R35  \
-        ) \
-        { \
-                { L00, L01, L02, L03, L04, L05, KC_NO }, \
-                { L10, L11, L12, L13, L14, L15, KC_NO }, \
-                { L20, L21, L22, L23, L24, L25, KC_NO }, \
-                { L30, L31, L32, L33, L34, L35, L36 }, \
-                { R05, R04, R03, R02, R01, R00, KC_NO }, \
-                { R15, R14, R13, R12, R11, R10, KC_NO }, \
-                { R25, R24, R23, R22, R21, R20, KC_NO }, \
-                { R35, R34, R33, R32, R31, R30, R36 }, \
-        }
+  L00, L01, L02, L03, L04, L05,           R00, R01, R02, R03, R04, R05, \
+  L10, L11, L12, L13, L14, L15,           R10, R11, R12, R13, R14, R15, \
+  L20, L21, L22, L23, L24, L25,           R20, R21, R22, R23, R24, R25, \
+  L30, L31, L32, L33, L34, L35, L36, R36, R30, R31, R32, R33, R34, R35  \
+  ) \
+  { \
+    { L00, L01, L02, L03, L04, L05, KC_NO }, \
+    { L10, L11, L12, L13, L14, L15, KC_NO }, \
+    { L20, L21, L22, L23, L24, L25, KC_NO }, \
+    { L30, L31, L32, L33, L34, L35, L36 }, \
+    { R05, R04, R03, R02, R01, R00, KC_NO }, \
+    { R15, R14, R13, R12, R11, R10, KC_NO }, \
+    { R25, R24, R23, R22, R21, R20, KC_NO }, \
+    { R35, R34, R33, R32, R31, R30, R36 }, \
+  }
 #else
 // Keymap with right side flipped
 // (TRRS jack on both halves are to the right)
 #define LAYOUT( \
-        L00, L01, L02, L03, L04, L05,           R00, R01, R02, R03, R04, R05, \
-        L10, L11, L12, L13, L14, L15,           R10, R11, R12, R13, R14, R15, \
-        L20, L21, L22, L23, L24, L25,           R20, R21, R22, R23, R24, R25, \
-        L30, L31, L32, L33, L34, L35, L36, R36, R30, R31, R32, R33, R34, R35  \
-        ) \
-        { \
-                { L00, L01, L02, L03, L04, L05, KC_NO }, \
-                { L10, L11, L12, L13, L14, L15, KC_NO }, \
-                { L20, L21, L22, L23, L24, L25, KC_NO }, \
-                { L30, L31, L32, L33, L34, L35, L36 }, \
-                { KC_NO, R00, R01, R02, R03, R04, R05 }, \
-                { KC_NO, R10, R11, R12, R13, R14, R15 }, \
-                { KC_NO, R20, R21, R22, R23, R24, R25 }, \
-                { R36, R30, R31, R32, R33, R34, R35 }, \
-        }
+  L00, L01, L02, L03, L04, L05,           R00, R01, R02, R03, R04, R05, \
+  L10, L11, L12, L13, L14, L15,           R10, R11, R12, R13, R14, R15, \
+  L20, L21, L22, L23, L24, L25,           R20, R21, R22, R23, R24, R25, \
+  L30, L31, L32, L33, L34, L35, L36, R36, R30, R31, R32, R33, R34, R35  \
+  ) \
+  { \
+    { L00, L01, L02, L03, L04, L05, KC_NO }, \
+    { L10, L11, L12, L13, L14, L15, KC_NO }, \
+    { L20, L21, L22, L23, L24, L25, KC_NO }, \
+    { L30, L31, L32, L33, L34, L35, L36 }, \
+    { KC_NO, R00, R01, R02, R03, R04, R05 }, \
+    { KC_NO, R10, R11, R12, R13, R14, R15 }, \
+    { KC_NO, R20, R21, R22, R23, R24, R25 }, \
+    { R36, R30, R31, R32, R33, R34, R35 }, \
+  }
 #endif
 #else
   #ifndef FLIP_HALF
@@ -89,14 +89,14 @@
   // Keymap with right side flipped
   // (TRRS jack on both halves are to the right)
   #define LAYOUT( \
-                L00, L01, L02, L03, L04, L05,           R00, R01, R02, R03, R04, R05, \
+    L00, L01, L02, L03, L04, L05,           R00, R01, R02, R03, R04, R05, \
     L10, L11, L12, L13, L14, L15,           R10, R11, R12, R13, R14, R15, \
     L20, L21, L22, L23, L24, L25,           R20, R21, R22, R23, R24, R25, \
     L30, L31, L32, L33, L34, L35, L36, R36, R30, R31, R32, R33, R34, R35, \
     L40, L41, L42, L43, L44, L45, L46, R46, R40, R41, R42, R43, R44, R45  \
     ) \
     { \
-                        { L00, L01, L02, L03, L04, L05, KC_NO }, \
+      { L00, L01, L02, L03, L04, L05, KC_NO }, \
       { L10, L11, L12, L13, L14, L15, KC_NO }, \
       { L20, L21, L22, L23, L24, L25, KC_NO }, \
       { L30, L31, L32, L33, L34, L35, L36 }, \
@@ -110,4 +110,35 @@
   #endif
 #endif
 
+// Used to create a keymap using only KC_ prefixed keys
+#if HELIX_ROWS == 4
+  #define LAYOUT_kc( \
+    L00, L01, L02, L03, L04, L05,           R00, R01, R02, R03, R04, R05, \
+    L10, L11, L12, L13, L14, L15,           R10, R11, R12, R13, R14, R15, \
+    L20, L21, L22, L23, L24, L25,           R20, R21, R22, R23, R24, R25, \
+    L30, L31, L32, L33, L34, L35, L36, R36, R30, R31, R32, R33, R34, R35 \
+    ) \
+    LAYOUT( \
+      KC_##L00, KC_##L01, KC_##L02, KC_##L03, KC_##L04, KC_##L05, KC_##R00, KC_##R01, KC_##R02, KC_##R03, KC_##R04, KC_##R05, \
+      KC_##L10, KC_##L11, KC_##L12, KC_##L13, KC_##L14, KC_##L15, KC_##R10, KC_##R11, KC_##R12, KC_##R13, KC_##R14, KC_##R15, \
+      KC_##L20, KC_##L21, KC_##L22, KC_##L23, KC_##L24, KC_##L25, KC_##R20, KC_##R21, KC_##R22, KC_##R23, KC_##R24, KC_##R25, \
+      KC_##L30, KC_##L31, KC_##L32, KC_##L33, KC_##L34, KC_##L35, KC_##L36, KC_##R36, KC_##R30, KC_##R31, KC_##R32, KC_##R33, KC_##R34, KC_##R35 \
+    )
+#else
+  #define LAYOUT_kc( \
+    L00, L01, L02, L03, L04, L05,           R00, R01, R02, R03, R04, R05, \
+    L10, L11, L12, L13, L14, L15,           R10, R11, R12, R13, R14, R15, \
+    L20, L21, L22, L23, L24, L25,           R20, R21, R22, R23, R24, R25, \
+    L30, L31, L32, L33, L34, L35, L36, R36, R30, R31, R32, R33, R34, R35, \
+    L40, L41, L42, L43, L44, L45, L46, R46, R40, R41, R42, R43, R44, R45 \
+    ) \
+    LAYOUT( \
+      KC_##L00, KC_##L01, KC_##L02, KC_##L03, KC_##L04, KC_##L05, KC_##R00, KC_##R01, KC_##R02, KC_##R03, KC_##R04, KC_##R05, \
+      KC_##L10, KC_##L11, KC_##L12, KC_##L13, KC_##L14, KC_##L15, KC_##R10, KC_##R11, KC_##R12, KC_##R13, KC_##R14, KC_##R15, \
+      KC_##L20, KC_##L21, KC_##L22, KC_##L23, KC_##L24, KC_##L25, KC_##R20, KC_##R21, KC_##R22, KC_##R23, KC_##R24, KC_##R25, \
+      KC_##L30, KC_##L31, KC_##L32, KC_##L33, KC_##L34, KC_##L35, KC_##L36, KC_##R36, KC_##R30, KC_##R31, KC_##R32, KC_##R33, KC_##R34, KC_##R35, \
+      KC_##L40, KC_##L41, KC_##L42, KC_##L43, KC_##L44, KC_##L45, KC_##L46, KC_##R46, KC_##R40, KC_##R41, KC_##R42, KC_##R43, KC_##R44, KC_##R45 \
+    )
+#endif
+
 #endif