diff options
| author | Josef Adamčík <josef.adamcik@gmail.com> | 2020-05-18 12:56:08 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-18 12:56:08 +0200 |
| commit | f6cec668c7ad623043b0c7796fb599602b41eb75 (patch) | |
| tree | 821b1809f14c007edb12cd72f004c3582b64e792 | |
| parent | 2651edc24347c52093f15a83603515c3d215dca1 (diff) | |
| download | qmk_firmware-f6cec668c7ad623043b0c7796fb599602b41eb75.tar.gz qmk_firmware-f6cec668c7ad623043b0c7796fb599602b41eb75.zip | |
Apply suggestions from code review
Co-authored-by: Drashna Jaelre <drashna@live.com>
| -rw-r--r-- | keyboards/sofle/keymaps/default/config.h | 1 | ||||
| -rw-r--r-- | keyboards/sofle/keymaps/default/keymap.c | 6 |
2 files changed, 3 insertions, 4 deletions
diff --git a/keyboards/sofle/keymaps/default/config.h b/keyboards/sofle/keymaps/default/config.h index 8133e12fc..0b1e2a11c 100644 --- a/keyboards/sofle/keymaps/default/config.h +++ b/keyboards/sofle/keymaps/default/config.h | |||
| @@ -4,6 +4,5 @@ | |||
| 4 | see https://docs.qmk.fm/#/feature_split_keyboard?id=setting-handedness | 4 | see https://docs.qmk.fm/#/feature_split_keyboard?id=setting-handedness |
| 5 | for more options. | 5 | for more options. |
| 6 | */ | 6 | */ |
| 7 | #define MASTER_LEFT | ||
| 8 | 7 | ||
| 9 | #define TAPPING_FORCE_HOLD | 8 | #define TAPPING_FORCE_HOLD |
diff --git a/keyboards/sofle/keymaps/default/keymap.c b/keyboards/sofle/keymaps/default/keymap.c index 5c52de713..aa8fd15f8 100644 --- a/keyboards/sofle/keymaps/default/keymap.c +++ b/keyboards/sofle/keymaps/default/keymap.c | |||
| @@ -166,7 +166,7 @@ static void print_status_narrow(void) { | |||
| 166 | oled_write_ln_P(PSTR("Clmk"), false); | 166 | oled_write_ln_P(PSTR("Clmk"), false); |
| 167 | break; | 167 | break; |
| 168 | default: | 168 | default: |
| 169 | oled_write_P(PSTR("Undefined\n"), false); | 169 | oled_write_P(PSTR("Undef"), false); |
| 170 | } | 170 | } |
| 171 | oled_write_P(PSTR("\n\n"), false); | 171 | oled_write_P(PSTR("\n\n"), false); |
| 172 | // Print current layer | 172 | // Print current layer |
| @@ -189,8 +189,8 @@ static void print_status_narrow(void) { | |||
| 189 | oled_write_ln_P(PSTR("Undef"), false); | 189 | oled_write_ln_P(PSTR("Undef"), false); |
| 190 | } | 190 | } |
| 191 | oled_write_P(PSTR("\n\n"), false); | 191 | oled_write_P(PSTR("\n\n"), false); |
| 192 | uint8_t led_usb_state = host_keyboard_leds(); | 192 | led_t led_usb_state = host_keyboard_led_state()(); |
| 193 | oled_write_ln_P(led_usb_state & (1 << USB_LED_CAPS_LOCK) ? PSTR("CPSLK") : PSTR(" "), false); | 193 | oled_write_ln_P(PSTR("CPSLK"), led_usb_state.caps_lock); |
| 194 | } | 194 | } |
| 195 | 195 | ||
| 196 | oled_rotation_t oled_init_user(oled_rotation_t rotation) { | 196 | oled_rotation_t oled_init_user(oled_rotation_t rotation) { |
