diff options
author | Sergey Vlasov <sigprof@gmail.com> | 2021-10-14 16:41:30 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-14 14:41:30 +0100 |
commit | f9f3a11c2076f6fc378beb8ccbc8500fb060fcf3 (patch) | |
tree | 2067edaed5ac621195e69b3d3b9bbb11c4726ca7 | |
parent | 04cf161aa01fd433b5dae69d9fd31569ed5dca59 (diff) | |
download | qmk_firmware-f9f3a11c2076f6fc378beb8ccbc8500fb060fcf3.tar.gz qmk_firmware-f9f3a11c2076f6fc378beb8ccbc8500fb060fcf3.zip |
contra, fractal: Remove wrongly copypasted pin E6 manipulation code (#14818)
Apparently the default keymaps for `contra` and `fractal` were derived
from some `planck` keymap which contained code to control the status LED
in the implementation of the `BACKLIT` custom keycode. Unfortunately,
the code to control the LED manipulated the `E6` pin directly, and it
was copied without changes, but the `contra` and `fractal` boards use
the `E6` pin in the matrix, therefore pressing the key mapped to
`BACKLIT` resulted in phantom keypresses for all keys in the
corresponding column.
-rw-r--r-- | keyboards/contra/keymaps/default/keymap.c | 2 | ||||
-rw-r--r-- | keyboards/fractal/keymaps/default/keymap.c | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/keyboards/contra/keymaps/default/keymap.c b/keyboards/contra/keymaps/default/keymap.c index 31e90ed26..6a653d9ce 100644 --- a/keyboards/contra/keymaps/default/keymap.c +++ b/keyboards/contra/keymaps/default/keymap.c | |||
@@ -222,10 +222,8 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) { | |||
222 | #ifdef BACKLIGHT_ENABLE | 222 | #ifdef BACKLIGHT_ENABLE |
223 | backlight_step(); | 223 | backlight_step(); |
224 | #endif | 224 | #endif |
225 | PORTE &= ~(1<<6); | ||
226 | } else { | 225 | } else { |
227 | unregister_code(KC_RSFT); | 226 | unregister_code(KC_RSFT); |
228 | PORTE |= (1<<6); | ||
229 | } | 227 | } |
230 | return false; | 228 | return false; |
231 | break; | 229 | break; |
diff --git a/keyboards/fractal/keymaps/default/keymap.c b/keyboards/fractal/keymaps/default/keymap.c index 8bb1f9831..553dad034 100644 --- a/keyboards/fractal/keymaps/default/keymap.c +++ b/keyboards/fractal/keymaps/default/keymap.c | |||
@@ -213,10 +213,8 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) { | |||
213 | #ifdef BACKLIGHT_ENABLE | 213 | #ifdef BACKLIGHT_ENABLE |
214 | backlight_step(); | 214 | backlight_step(); |
215 | #endif | 215 | #endif |
216 | PORTE &= ~(1<<6); | ||
217 | } else { | 216 | } else { |
218 | unregister_code(KC_RSFT); | 217 | unregister_code(KC_RSFT); |
219 | PORTE |= (1<<6); | ||
220 | } | 218 | } |
221 | return false; | 219 | return false; |
222 | break; | 220 | break; |