diff options
| author | QMK Bot <hello@qmk.fm> | 2021-08-20 22:32:01 +0000 |
|---|---|---|
| committer | QMK Bot <hello@qmk.fm> | 2021-08-20 22:32:01 +0000 |
| commit | ce379ef458fd9092543fb4022aab6e455865f514 (patch) | |
| tree | 2bc1b37b47d1fd2536082116a843f61e032e8a31 /docs/contributing.md | |
| parent | a7d48b063ec9d551396eadeb02a924d2ee3ea515 (diff) | |
| parent | c71d67ba3f4bdedbd5ec1e931e6ea9568fcd0d98 (diff) | |
| download | qmk_firmware-ce379ef458fd9092543fb4022aab6e455865f514.tar.gz qmk_firmware-ce379ef458fd9092543fb4022aab6e455865f514.zip | |
Merge remote-tracking branch 'origin/master' into develop
Diffstat (limited to 'docs/contributing.md')
| -rw-r--r-- | docs/contributing.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/contributing.md b/docs/contributing.md index fe48619e4..1d68d22d9 100644 --- a/docs/contributing.md +++ b/docs/contributing.md | |||
| @@ -148,7 +148,7 @@ Feature and Bug Fix PR's affect all keyboards. We are also in the process of res | |||
| 148 | Here are some things to keep in mind when working on your feature or bug fix. | 148 | Here are some things to keep in mind when working on your feature or bug fix. |
| 149 | 149 | ||
| 150 | * **Disabled by default** - memory is a pretty limited on most chips QMK supports, and it's important that current keymaps aren't broken, so please allow your feature to be turned **on**, rather than being turned off. If you think it should be on by default, or reduces the size of the code, please talk with us about it. | 150 | * **Disabled by default** - memory is a pretty limited on most chips QMK supports, and it's important that current keymaps aren't broken, so please allow your feature to be turned **on**, rather than being turned off. If you think it should be on by default, or reduces the size of the code, please talk with us about it. |
| 151 | * **Compile locally before submitting** - hopefully this one is obvious, but things need to compile! Our Travis system will catch any issues, but it's generally faster for you to compile a few keyboards locally instead of waiting for the results to come back. | 151 | * **Compile locally before submitting** - hopefully this one is obvious, but things need to compile! You should always make sure your changes compile before opening a pull request. |
| 152 | * **Consider revisions and different chip-bases** - there are several keyboards that have revisions that allow for slightly different configurations, and even different chip-bases. Try to make a feature supported in ARM and AVR, or automatically disabled on platforms it doesn't work on. | 152 | * **Consider revisions and different chip-bases** - there are several keyboards that have revisions that allow for slightly different configurations, and even different chip-bases. Try to make a feature supported in ARM and AVR, or automatically disabled on platforms it doesn't work on. |
| 153 | * **Explain your feature** - Document it in `docs/`, either as a new file or as part of an existing file. If you don't document it other people won't be able to benefit from your hard work. | 153 | * **Explain your feature** - Document it in `docs/`, either as a new file or as part of an existing file. If you don't document it other people won't be able to benefit from your hard work. |
| 154 | 154 | ||
