diff options
| author | Drashna Jaelre <drashna@live.com> | 2019-11-15 14:27:46 -0800 |
|---|---|---|
| committer | Joel Challis <git@zvecr.com> | 2019-11-15 22:27:46 +0000 |
| commit | f6b5f6db7665512cece0223ce4d19c5b17455ef4 (patch) | |
| tree | 0eb1313ba5d706819321b32effd9f5dc6d9fee62 /drivers/haptic/solenoid.h | |
| parent | 381b73fcac169338a1dcf433694108a29870a57e (diff) | |
| download | qmk_firmware-f6b5f6db7665512cece0223ce4d19c5b17455ef4.tar.gz qmk_firmware-f6b5f6db7665512cece0223ce4d19c5b17455ef4.zip | |
Improvements to Solenoid feature (#7369)
* Error out when Solenid pin is not defined
Instead of defaulting to a (literally) random pin, error out instead. Because this pin may be used, or because that pin may not be exposed, or may not exist.
* Remove 'SOLENOID_ACTIVE' setting since it's not used
* Update documentation
Diffstat (limited to 'drivers/haptic/solenoid.h')
| -rw-r--r-- | drivers/haptic/solenoid.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/haptic/solenoid.h b/drivers/haptic/solenoid.h index 53dc626e3..dd6ececa6 100644 --- a/drivers/haptic/solenoid.h +++ b/drivers/haptic/solenoid.h | |||
| @@ -29,12 +29,8 @@ | |||
| 29 | # define SOLENOID_MIN_DWELL 4 | 29 | # define SOLENOID_MIN_DWELL 4 |
| 30 | #endif | 30 | #endif |
| 31 | 31 | ||
| 32 | #ifndef SOLENOID_ACTIVE | ||
| 33 | # define SOLENOID_ACTIVE false | ||
| 34 | #endif | ||
| 35 | |||
| 36 | #ifndef SOLENOID_PIN | 32 | #ifndef SOLENOID_PIN |
| 37 | # define SOLENOID_PIN F6 | 33 | # error SOLENOID_PIN not defined |
| 38 | #endif | 34 | #endif |
| 39 | 35 | ||
| 40 | void solenoid_buzz_on(void); | 36 | void solenoid_buzz_on(void); |
