diff options
| author | Drashna Jaelre <drashna@live.com> | 2019-01-26 15:49:45 -0800 |
|---|---|---|
| committer | MechMerlin <30334081+mechmerlin@users.noreply.github.com> | 2019-01-26 15:49:45 -0800 |
| commit | b05c0e46c6c62972b68518635104fb58927d1a13 (patch) | |
| tree | 4037e0ff8b7d52aee235e9a7e31083984b453777 /keyboards/clueboard | |
| parent | 478538e0d9938952568c62d135166d2cba15a70c (diff) | |
| download | qmk_firmware-b05c0e46c6c62972b68518635104fb58927d1a13.tar.gz qmk_firmware-b05c0e46c6c62972b68518635104fb58927d1a13.zip | |
Adds a default value for IS_COMMAND for COMMAND feature (#4301)
* Add default value for IS_COMMAND for COMMAND feature
* Cleanup and consistency
* Update Templates to reflect change
* Fix IS_COMMAND in template
* Fix IS_COMMAND define
* Use consistent IS_COMMAND block in templates
* Remove unnecessary `#undef IS_COMMAND` directives
* Fix compile issue on orthodox
* Reomve IS_COMMAND option for newer boards
* Remove all existing definitions of IS_COMMAND if they use default LSHIFT and RSHIFT setting
* Remove a couple of additional IS_COMMAND defines
* Remove remaining redundant IS_COMMAND definitions
* Remove #undef IS_COMMAND from orthodox:drashna and whitefox:konstantin
* Remove multiple empty lines in modified config.h files
* Update additional boards
* Reomve IS_COMMAND from newer boards
* Update Alice keyboard
* Remove IS_COMMAND from additional boards
Jan 24th edition
Diffstat (limited to 'keyboards/clueboard')
| -rw-r--r-- | keyboards/clueboard/17/config.h | 5 | ||||
| -rw-r--r-- | keyboards/clueboard/2x1800/config.h | 5 | ||||
| -rw-r--r-- | keyboards/clueboard/60/config.h | 5 | ||||
| -rw-r--r-- | keyboards/clueboard/66/rev1/config.h | 5 | ||||
| -rw-r--r-- | keyboards/clueboard/66/rev2/config.h | 5 | ||||
| -rw-r--r-- | keyboards/clueboard/66/rev3/config.h | 5 | ||||
| -rw-r--r-- | keyboards/clueboard/66_hotswap/config.h | 5 | ||||
| -rw-r--r-- | keyboards/clueboard/card/config.h | 7 |
8 files changed, 1 insertions, 41 deletions
diff --git a/keyboards/clueboard/17/config.h b/keyboards/clueboard/17/config.h index bd64dfd27..21728348d 100644 --- a/keyboards/clueboard/17/config.h +++ b/keyboards/clueboard/17/config.h | |||
| @@ -62,11 +62,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 62 | /* Locking resynchronize hack */ | 62 | /* Locking resynchronize hack */ |
| 63 | #define LOCKING_RESYNC_ENABLE | 63 | #define LOCKING_RESYNC_ENABLE |
| 64 | 64 | ||
| 65 | /* key combination for command */ | ||
| 66 | #define IS_COMMAND() ( \ | ||
| 67 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 68 | ) | ||
| 69 | |||
| 70 | /* Underlight configuration | 65 | /* Underlight configuration |
| 71 | */ | 66 | */ |
| 72 | #define RGB_DI_PIN F6 | 67 | #define RGB_DI_PIN F6 |
diff --git a/keyboards/clueboard/2x1800/config.h b/keyboards/clueboard/2x1800/config.h index cddcd1ce7..1b47a9d65 100644 --- a/keyboards/clueboard/2x1800/config.h +++ b/keyboards/clueboard/2x1800/config.h | |||
| @@ -115,11 +115,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 115 | * | 115 | * |
| 116 | */ | 116 | */ |
| 117 | 117 | ||
| 118 | /* key combination for magic key command */ | ||
| 119 | #define IS_COMMAND() ( \ | ||
| 120 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 121 | ) | ||
| 122 | |||
| 123 | /* control how magic key switches layers */ | 118 | /* control how magic key switches layers */ |
| 124 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true | 119 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true |
| 125 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true | 120 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true |
diff --git a/keyboards/clueboard/60/config.h b/keyboards/clueboard/60/config.h index c7dbf8ad0..aa544c70b 100644 --- a/keyboards/clueboard/60/config.h +++ b/keyboards/clueboard/60/config.h | |||
| @@ -80,11 +80,6 @@ | |||
| 80 | */ | 80 | */ |
| 81 | //#define FORCE_NKRO | 81 | //#define FORCE_NKRO |
| 82 | 82 | ||
| 83 | /* key combination for magic key command */ | ||
| 84 | #define IS_COMMAND() ( \ | ||
| 85 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 86 | ) | ||
| 87 | |||
| 88 | /* | 83 | /* |
| 89 | * Feature disable options | 84 | * Feature disable options |
| 90 | * These options are also useful to firmware size reduction. | 85 | * These options are also useful to firmware size reduction. |
diff --git a/keyboards/clueboard/66/rev1/config.h b/keyboards/clueboard/66/rev1/config.h index a35c0d0f6..f8fb4bd35 100644 --- a/keyboards/clueboard/66/rev1/config.h +++ b/keyboards/clueboard/66/rev1/config.h | |||
| @@ -32,11 +32,6 @@ | |||
| 32 | /* Locking resynchronize hack */ | 32 | /* Locking resynchronize hack */ |
| 33 | #define LOCKING_RESYNC_ENABLE | 33 | #define LOCKING_RESYNC_ENABLE |
| 34 | 34 | ||
| 35 | /* key combination for command */ | ||
| 36 | #define IS_COMMAND() ( \ | ||
| 37 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 38 | ) | ||
| 39 | |||
| 40 | /* | 35 | /* |
| 41 | * Feature disable options | 36 | * Feature disable options |
| 42 | * These options are also useful to firmware size reduction. | 37 | * These options are also useful to firmware size reduction. |
diff --git a/keyboards/clueboard/66/rev2/config.h b/keyboards/clueboard/66/rev2/config.h index 0216b5e1f..9227cd2df 100644 --- a/keyboards/clueboard/66/rev2/config.h +++ b/keyboards/clueboard/66/rev2/config.h | |||
| @@ -31,11 +31,6 @@ | |||
| 31 | /* Locking resynchronize hack */ | 31 | /* Locking resynchronize hack */ |
| 32 | #define LOCKING_RESYNC_ENABLE | 32 | #define LOCKING_RESYNC_ENABLE |
| 33 | 33 | ||
| 34 | /* key combination for command */ | ||
| 35 | #define IS_COMMAND() ( \ | ||
| 36 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 37 | ) | ||
| 38 | |||
| 39 | /* | 34 | /* |
| 40 | * Feature disable options | 35 | * Feature disable options |
| 41 | * These options are also useful to firmware size reduction. | 36 | * These options are also useful to firmware size reduction. |
diff --git a/keyboards/clueboard/66/rev3/config.h b/keyboards/clueboard/66/rev3/config.h index e7cda4ccf..ba646f157 100644 --- a/keyboards/clueboard/66/rev3/config.h +++ b/keyboards/clueboard/66/rev3/config.h | |||
| @@ -31,11 +31,6 @@ | |||
| 31 | /* Locking resynchronize hack */ | 31 | /* Locking resynchronize hack */ |
| 32 | #define LOCKING_RESYNC_ENABLE | 32 | #define LOCKING_RESYNC_ENABLE |
| 33 | 33 | ||
| 34 | /* key combination for command */ | ||
| 35 | #define IS_COMMAND() ( \ | ||
| 36 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 37 | ) | ||
| 38 | |||
| 39 | /* | 34 | /* |
| 40 | * Feature disable options | 35 | * Feature disable options |
| 41 | * These options are also useful to firmware size reduction. | 36 | * These options are also useful to firmware size reduction. |
diff --git a/keyboards/clueboard/66_hotswap/config.h b/keyboards/clueboard/66_hotswap/config.h index d676af0ca..88adb5737 100644 --- a/keyboards/clueboard/66_hotswap/config.h +++ b/keyboards/clueboard/66_hotswap/config.h | |||
| @@ -36,11 +36,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 36 | /* Locking resynchronize hack */ | 36 | /* Locking resynchronize hack */ |
| 37 | #define LOCKING_RESYNC_ENABLE | 37 | #define LOCKING_RESYNC_ENABLE |
| 38 | 38 | ||
| 39 | /* key combination for command */ | ||
| 40 | #define IS_COMMAND() ( \ | ||
| 41 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 42 | ) | ||
| 43 | |||
| 44 | /* | 39 | /* |
| 45 | * Feature disable options | 40 | * Feature disable options |
| 46 | * These options are also useful to firmware size reduction. | 41 | * These options are also useful to firmware size reduction. |
diff --git a/keyboards/clueboard/card/config.h b/keyboards/clueboard/card/config.h index 805982121..9520c31a6 100644 --- a/keyboards/clueboard/card/config.h +++ b/keyboards/clueboard/card/config.h | |||
| @@ -39,7 +39,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 39 | 39 | ||
| 40 | /* COL2ROW or ROW2COL */ | 40 | /* COL2ROW or ROW2COL */ |
| 41 | #define DIODE_DIRECTION ROW2COL | 41 | #define DIODE_DIRECTION ROW2COL |
| 42 | 42 | ||
| 43 | /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ | 43 | /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ |
| 44 | #define DEBOUNCING_DELAY 20 | 44 | #define DEBOUNCING_DELAY 20 |
| 45 | 45 | ||
| @@ -87,11 +87,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 87 | * | 87 | * |
| 88 | */ | 88 | */ |
| 89 | 89 | ||
| 90 | /* key combination for magic key command */ | ||
| 91 | #define IS_COMMAND() ( \ | ||
| 92 | keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ | ||
| 93 | ) | ||
| 94 | |||
| 95 | /* control how magic key switches layers */ | 90 | /* control how magic key switches layers */ |
| 96 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true | 91 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true |
| 97 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true | 92 | //#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true |
