diff options
| author | Drashna Jaelre <drashna@live.com> | 2021-05-21 23:17:32 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-21 23:17:32 -0700 |
| commit | a0fed0ea176d1c986e40fc4981b900509c90d66e (patch) | |
| tree | ee12f5943046015ea0dce8e2a30a68bc8eb99dbe /keyboards/helix/rev3_4rows | |
| parent | 76c23b15abc824f867b48d8d5100dced2417d336 (diff) | |
| download | qmk_firmware-a0fed0ea176d1c986e40fc4981b900509c90d66e.tar.gz qmk_firmware-a0fed0ea176d1c986e40fc4981b900509c90d66e.zip | |
Convert Encoder callbacks to be boolean functions (#12805)
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Diffstat (limited to 'keyboards/helix/rev3_4rows')
| -rw-r--r-- | keyboards/helix/rev3_4rows/keymaps/default/keymap.c | 3 | ||||
| -rw-r--r-- | keyboards/helix/rev3_4rows/keymaps/via/keymap.c | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/keyboards/helix/rev3_4rows/keymaps/default/keymap.c b/keyboards/helix/rev3_4rows/keymaps/default/keymap.c index a9a2c4acc..1544a4fff 100644 --- a/keyboards/helix/rev3_4rows/keymaps/default/keymap.c +++ b/keyboards/helix/rev3_4rows/keymaps/default/keymap.c | |||
| @@ -111,7 +111,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | |||
| 111 | 111 | ||
| 112 | }; | 112 | }; |
| 113 | 113 | ||
| 114 | void encoder_update_user(uint8_t index, bool clockwise) { | 114 | bool encoder_update_user(uint8_t index, bool clockwise) { |
| 115 | if (index == 0) { /* Left side encoder */ | 115 | if (index == 0) { /* Left side encoder */ |
| 116 | if (clockwise) { | 116 | if (clockwise) { |
| 117 | tap_code(KC_PGDN); | 117 | tap_code(KC_PGDN); |
| @@ -125,6 +125,7 @@ void encoder_update_user(uint8_t index, bool clockwise) { | |||
| 125 | tap_code(KC_UP); | 125 | tap_code(KC_UP); |
| 126 | } | 126 | } |
| 127 | } | 127 | } |
| 128 | return true; | ||
| 128 | } | 129 | } |
| 129 | 130 | ||
| 130 | layer_state_t layer_state_set_user(layer_state_t state) { | 131 | layer_state_t layer_state_set_user(layer_state_t state) { |
diff --git a/keyboards/helix/rev3_4rows/keymaps/via/keymap.c b/keyboards/helix/rev3_4rows/keymaps/via/keymap.c index 5611c96b3..2cfb1152c 100644 --- a/keyboards/helix/rev3_4rows/keymaps/via/keymap.c +++ b/keyboards/helix/rev3_4rows/keymaps/via/keymap.c | |||
| @@ -111,7 +111,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | |||
| 111 | 111 | ||
| 112 | }; | 112 | }; |
| 113 | 113 | ||
| 114 | void encoder_update_user(uint8_t index, bool clockwise) { | 114 | bool encoder_update_user(uint8_t index, bool clockwise) { |
| 115 | if (index == 0) { /* Left side encoder */ | 115 | if (index == 0) { /* Left side encoder */ |
| 116 | if (clockwise) { | 116 | if (clockwise) { |
| 117 | tap_code(KC_PGDN); | 117 | tap_code(KC_PGDN); |
| @@ -125,6 +125,7 @@ void encoder_update_user(uint8_t index, bool clockwise) { | |||
| 125 | tap_code(KC_UP); | 125 | tap_code(KC_UP); |
| 126 | } | 126 | } |
| 127 | } | 127 | } |
| 128 | return true; | ||
| 128 | } | 129 | } |
| 129 | 130 | ||
| 130 | bool process_record_user(uint16_t keycode, keyrecord_t *record) { | 131 | bool process_record_user(uint16_t keycode, keyrecord_t *record) { |