diff options
| author | James Young <18669334+noroadsleft@users.noreply.github.com> | 2021-08-15 20:51:13 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-16 06:51:13 +1000 |
| commit | 4b453dca92f87899d98b5340b16677bd78a52beb (patch) | |
| tree | a40b8e53964520762946e0c63bfc0a83cb2a3428 /keyboards/meira | |
| parent | fd340f8957055d74b26a5ddc490253fcc8a3a2f7 (diff) | |
| download | qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.tar.gz qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.zip | |
Remove MIDI Configuration boilerplate (#11151)
* remove keyboard-level instances of `MIDI_ENABLE = no`
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} +
```
Co-Authored-By: Nick Brassel <nick@tzarc.org>
* fix case-sensitivity issues on MIDI_ENABLE
Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} +
```
* replace `# MIDI controls` with `# MIDI support`
Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} +
```
* align inline comments
Aligns the inline comments to the length used by the QMK AVR rules.mk template.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} +
```
* remove commented instances of `MIDI_ENABLE` from keyboard `rules.mk` files
Commands:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} +
```
* remove MIDI configuration boilerplate from keyboard config.h files
Co-authored-by: Nick Brassel <nick@tzarc.org>
Diffstat (limited to 'keyboards/meira')
| -rw-r--r-- | keyboards/meira/featherble/config.h | 20 | ||||
| -rw-r--r-- | keyboards/meira/promicro/config.h | 20 | ||||
| -rw-r--r-- | keyboards/meira/rules.mk | 1 |
3 files changed, 0 insertions, 41 deletions
diff --git a/keyboards/meira/featherble/config.h b/keyboards/meira/featherble/config.h index 7abe2b1d6..b3ee95474 100644 --- a/keyboards/meira/featherble/config.h +++ b/keyboards/meira/featherble/config.h | |||
| @@ -145,24 +145,4 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 145 | //#define NO_ACTION_MACRO | 145 | //#define NO_ACTION_MACRO |
| 146 | //#define NO_ACTION_FUNCTION | 146 | //#define NO_ACTION_FUNCTION |
| 147 | 147 | ||
| 148 | /* | ||
| 149 | * MIDI options | ||
| 150 | */ | ||
| 151 | |||
| 152 | /* enable basic MIDI features: | ||
| 153 | - MIDI notes can be sent when in Music mode is on | ||
| 154 | */ | ||
| 155 | //#define MIDI_BASIC | ||
| 156 | |||
| 157 | /* enable advanced MIDI features: | ||
| 158 | - MIDI notes can be added to the keymap | ||
| 159 | - Octave shift and transpose | ||
| 160 | - Virtual sustain, portamento, and modulation wheel | ||
| 161 | - etc. | ||
| 162 | */ | ||
| 163 | //#define MIDI_ADVANCED | ||
| 164 | |||
| 165 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
| 166 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
| 167 | |||
| 168 | #endif | 148 | #endif |
diff --git a/keyboards/meira/promicro/config.h b/keyboards/meira/promicro/config.h index edd8a954f..53844745b 100644 --- a/keyboards/meira/promicro/config.h +++ b/keyboards/meira/promicro/config.h | |||
| @@ -136,24 +136,4 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 136 | //#define NO_ACTION_MACRO | 136 | //#define NO_ACTION_MACRO |
| 137 | //#define NO_ACTION_FUNCTION | 137 | //#define NO_ACTION_FUNCTION |
| 138 | 138 | ||
| 139 | /* | ||
| 140 | * MIDI options | ||
| 141 | */ | ||
| 142 | |||
| 143 | /* enable basic MIDI features: | ||
| 144 | - MIDI notes can be sent when in Music mode is on | ||
| 145 | */ | ||
| 146 | //#define MIDI_BASIC | ||
| 147 | |||
| 148 | /* enable advanced MIDI features: | ||
| 149 | - MIDI notes can be added to the keymap | ||
| 150 | - Octave shift and transpose | ||
| 151 | - Virtual sustain, portamento, and modulation wheel | ||
| 152 | - etc. | ||
| 153 | */ | ||
| 154 | //#define MIDI_ADVANCED | ||
| 155 | |||
| 156 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
| 157 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
| 158 | |||
| 159 | #endif | 139 | #endif |
diff --git a/keyboards/meira/rules.mk b/keyboards/meira/rules.mk index 8f18875a7..0c7c33c0f 100644 --- a/keyboards/meira/rules.mk +++ b/keyboards/meira/rules.mk | |||
| @@ -23,7 +23,6 @@ COMMAND_ENABLE = no # Commands for debug and configuration | |||
| 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | 23 | SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend |
| 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 24 | # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
| 25 | NKRO_ENABLE = no # USB Nkey Rollover | 25 | NKRO_ENABLE = no # USB Nkey Rollover |
| 26 | MIDI_ENABLE = no # MIDI support | ||
| 27 | UNICODE_ENABLE = no # Unicode | 26 | UNICODE_ENABLE = no # Unicode |
| 28 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 27 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
| 29 | AUDIO_ENABLE = no # Audio output on port C6 | 28 | AUDIO_ENABLE = no # Audio output on port C6 |
