diff options
author | James Young <18669334+noroadsleft@users.noreply.github.com> | 2021-08-15 20:51:13 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-08-16 06:51:13 +1000 |
commit | 4b453dca92f87899d98b5340b16677bd78a52beb (patch) | |
tree | a40b8e53964520762946e0c63bfc0a83cb2a3428 /keyboards/preonic | |
parent | fd340f8957055d74b26a5ddc490253fcc8a3a2f7 (diff) | |
download | qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.tar.gz qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.zip |
Remove MIDI Configuration boilerplate (#11151)
* remove keyboard-level instances of `MIDI_ENABLE = no`
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} +
```
Co-Authored-By: Nick Brassel <nick@tzarc.org>
* fix case-sensitivity issues on MIDI_ENABLE
Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} +
```
* replace `# MIDI controls` with `# MIDI support`
Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} +
```
* align inline comments
Aligns the inline comments to the length used by the QMK AVR rules.mk template.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} +
```
* remove commented instances of `MIDI_ENABLE` from keyboard `rules.mk` files
Commands:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} +
```
* remove MIDI configuration boilerplate from keyboard config.h files
Co-authored-by: Nick Brassel <nick@tzarc.org>
Diffstat (limited to 'keyboards/preonic')
-rw-r--r-- | keyboards/preonic/rev1/rules.mk | 1 | ||||
-rw-r--r-- | keyboards/preonic/rev2/rules.mk | 1 | ||||
-rw-r--r-- | keyboards/preonic/rev3/config.h | 20 | ||||
-rw-r--r-- | keyboards/preonic/rev3/rules.mk | 1 |
4 files changed, 0 insertions, 23 deletions
diff --git a/keyboards/preonic/rev1/rules.mk b/keyboards/preonic/rev1/rules.mk index 2458f3c54..5f9cd5200 100644 --- a/keyboards/preonic/rev1/rules.mk +++ b/keyboards/preonic/rev1/rules.mk | |||
@@ -22,7 +22,6 @@ CONSOLE_ENABLE = no # Console for debug | |||
22 | COMMAND_ENABLE = no # Commands for debug and configuration | 22 | COMMAND_ENABLE = no # Commands for debug and configuration |
23 | NKRO_ENABLE = no # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 23 | NKRO_ENABLE = no # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
24 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 24 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
25 | MIDI_ENABLE = no # MIDI controls | ||
26 | AUDIO_ENABLE = yes # Audio output | 25 | AUDIO_ENABLE = yes # Audio output |
27 | UNICODE_ENABLE = no # Unicode | 26 | UNICODE_ENABLE = no # Unicode |
28 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 27 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
diff --git a/keyboards/preonic/rev2/rules.mk b/keyboards/preonic/rev2/rules.mk index b2567f915..00db8cc39 100644 --- a/keyboards/preonic/rev2/rules.mk +++ b/keyboards/preonic/rev2/rules.mk | |||
@@ -22,7 +22,6 @@ CONSOLE_ENABLE = yes # Console for debug | |||
22 | COMMAND_ENABLE = no # Commands for debug and configuration | 22 | COMMAND_ENABLE = no # Commands for debug and configuration |
23 | NKRO_ENABLE = no # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 23 | NKRO_ENABLE = no # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
24 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality | 24 | BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality |
25 | MIDI_ENABLE = no # MIDI controls | ||
26 | AUDIO_ENABLE = yes # Audio output | 25 | AUDIO_ENABLE = yes # Audio output |
27 | UNICODE_ENABLE = no # Unicode | 26 | UNICODE_ENABLE = no # Unicode |
28 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 27 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
diff --git a/keyboards/preonic/rev3/config.h b/keyboards/preonic/rev3/config.h index 0e8312445..420e7e541 100644 --- a/keyboards/preonic/rev3/config.h +++ b/keyboards/preonic/rev3/config.h | |||
@@ -94,26 +94,6 @@ | |||
94 | //#define NO_ACTION_FUNCTION | 94 | //#define NO_ACTION_FUNCTION |
95 | 95 | ||
96 | /* | 96 | /* |
97 | * MIDI options | ||
98 | */ | ||
99 | |||
100 | /* enable basic MIDI features: | ||
101 | - MIDI notes can be sent when in Music mode is on | ||
102 | */ | ||
103 | //#define MIDI_BASIC | ||
104 | |||
105 | /* enable advanced MIDI features: | ||
106 | - MIDI notes can be added to the keymap | ||
107 | - Octave shift and transpose | ||
108 | - Virtual sustain, portamento, and modulation wheel | ||
109 | - etc. | ||
110 | */ | ||
111 | //#define MIDI_ADVANCED | ||
112 | |||
113 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
114 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
115 | |||
116 | /* | ||
117 | * WS2812 Underglow Matrix options | 97 | * WS2812 Underglow Matrix options |
118 | */ | 98 | */ |
119 | #define RGB_DI_PIN A1 | 99 | #define RGB_DI_PIN A1 |
diff --git a/keyboards/preonic/rev3/rules.mk b/keyboards/preonic/rev3/rules.mk index 9e89fec8f..04760b4d2 100644 --- a/keyboards/preonic/rev3/rules.mk +++ b/keyboards/preonic/rev3/rules.mk | |||
@@ -16,7 +16,6 @@ CONSOLE_ENABLE = yes # Console for debug | |||
16 | COMMAND_ENABLE = yes # Commands for debug and configuration | 16 | COMMAND_ENABLE = yes # Commands for debug and configuration |
17 | NKRO_ENABLE = yes # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | 17 | NKRO_ENABLE = yes # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work |
18 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality | 18 | BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality |
19 | MIDI_ENABLE = no # MIDI controls | ||
20 | AUDIO_ENABLE = yes # Audio output | 19 | AUDIO_ENABLE = yes # Audio output |
21 | UNICODE_ENABLE = no # Unicode | 20 | UNICODE_ENABLE = no # Unicode |
22 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 21 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |