diff options
| author | James Young <18669334+noroadsleft@users.noreply.github.com> | 2021-08-15 20:51:13 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-16 06:51:13 +1000 |
| commit | 4b453dca92f87899d98b5340b16677bd78a52beb (patch) | |
| tree | a40b8e53964520762946e0c63bfc0a83cb2a3428 /keyboards/silverbullet44 | |
| parent | fd340f8957055d74b26a5ddc490253fcc8a3a2f7 (diff) | |
| download | qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.tar.gz qmk_firmware-4b453dca92f87899d98b5340b16677bd78a52beb.zip | |
Remove MIDI Configuration boilerplate (#11151)
* remove keyboard-level instances of `MIDI_ENABLE = no`
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]*MIDI_ENABLE[ \t]*=[ \t]*no/d' {} +
```
Co-Authored-By: Nick Brassel <nick@tzarc.org>
* fix case-sensitivity issues on MIDI_ENABLE
Change instances of `MIDI_ENABLE = YES` to `MIDI_ENABLE = yes`.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE[ \t]*=[ \t]*[Yy][Ee][Ss];MIDI_ENABLE = yes;g' {} +
```
* replace `# MIDI controls` with `# MIDI support`
Replace `# MIDI controls` with `# MIDI support` in keyboard-level `rules.mk` files.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#[ \t]*MIDI[ \t]*\(controls\|support\).*;# MIDI support;g' {} +
```
* align inline comments
Aligns the inline comments to the length used by the QMK AVR rules.mk template.
Command:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;MIDI_ENABLE *= *yes.*;MIDI_ENABLE = yes # MIDI support;g' {} +
```
* remove commented instances of `MIDI_ENABLE` from keyboard `rules.mk` files
Commands:
```
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;#\([ \t]*MIDI_ENABLE\) = yes; \1 = no ;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e 's;^\([ \t]*\)\(MIDI_ENABLE = no\);\2\1;' {} +
find keyboards/ -type f -name 'rules.mk' -and -not -path '*/keymaps/*' -exec sed -i -e '/^[ #]\+MIDI_ENABLE *= *no/d' {} +
```
* remove MIDI configuration boilerplate from keyboard config.h files
Co-authored-by: Nick Brassel <nick@tzarc.org>
Diffstat (limited to 'keyboards/silverbullet44')
| -rw-r--r-- | keyboards/silverbullet44/config.h | 20 | ||||
| -rw-r--r-- | keyboards/silverbullet44/rules.mk | 1 |
2 files changed, 0 insertions, 21 deletions
diff --git a/keyboards/silverbullet44/config.h b/keyboards/silverbullet44/config.h index cd78ef341..2bd9c834b 100644 --- a/keyboards/silverbullet44/config.h +++ b/keyboards/silverbullet44/config.h | |||
| @@ -237,26 +237,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| 237 | #define NO_ACTION_MACRO | 237 | #define NO_ACTION_MACRO |
| 238 | #define NO_ACTION_FUNCTION | 238 | #define NO_ACTION_FUNCTION |
| 239 | 239 | ||
| 240 | /* | ||
| 241 | * MIDI options | ||
| 242 | */ | ||
| 243 | |||
| 244 | /* enable basic MIDI features: | ||
| 245 | - MIDI notes can be sent when in Music mode is on | ||
| 246 | */ | ||
| 247 | //#define MIDI_BASIC | ||
| 248 | |||
| 249 | /* enable advanced MIDI features: | ||
| 250 | - MIDI notes can be added to the keymap | ||
| 251 | - Octave shift and transpose | ||
| 252 | - Virtual sustain, portamento, and modulation wheel | ||
| 253 | - etc. | ||
| 254 | */ | ||
| 255 | //#define MIDI_ADVANCED | ||
| 256 | |||
| 257 | /* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */ | ||
| 258 | //#define MIDI_TONE_KEYCODE_OCTAVES 1 | ||
| 259 | |||
| 260 | /* Bootmagic Lite key configuration */ | 240 | /* Bootmagic Lite key configuration */ |
| 261 | // #define BOOTMAGIC_LITE_ROW 0 | 241 | // #define BOOTMAGIC_LITE_ROW 0 |
| 262 | // #define BOOTMAGIC_LITE_COLUMN 0 | 242 | // #define BOOTMAGIC_LITE_COLUMN 0 |
diff --git a/keyboards/silverbullet44/rules.mk b/keyboards/silverbullet44/rules.mk index 06f5e7fec..357a16c33 100644 --- a/keyboards/silverbullet44/rules.mk +++ b/keyboards/silverbullet44/rules.mk | |||
| @@ -27,7 +27,6 @@ BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality on B7 by d | |||
| 27 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow | 27 | RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow |
| 28 | RGB_MATRIX_ENABLE = no | 28 | RGB_MATRIX_ENABLE = no |
| 29 | RGB_MATRIX_DRIVER = WS2812 | 29 | RGB_MATRIX_DRIVER = WS2812 |
| 30 | MIDI_ENABLE = no # MIDI support | ||
| 31 | UNICODE_ENABLE = no # Unicode | 30 | UNICODE_ENABLE = no # Unicode |
| 32 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID | 31 | BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID |
| 33 | AUDIO_ENABLE = yes # Audio output on port B6 | 32 | AUDIO_ENABLE = yes # Audio output on port B6 |
