aboutsummaryrefslogtreecommitdiff
path: root/lib/python/qmk/cli/doctor.py
diff options
context:
space:
mode:
authorZach White <skullydazed@gmail.com>2021-05-19 15:24:46 -0700
committerGitHub <noreply@github.com>2021-05-19 15:24:46 -0700
commitdb1eacdaacb9c8f6889f46bc1c6af155b81ad72a (patch)
treecd32a69a04c7ff93a11941d82aef3ce31c2b7523 /lib/python/qmk/cli/doctor.py
parenta9aec546c873fa5a2cb1d9a10878aca71818b609 (diff)
downloadqmk_firmware-db1eacdaacb9c8f6889f46bc1c6af155b81ad72a.tar.gz
qmk_firmware-db1eacdaacb9c8f6889f46bc1c6af155b81ad72a.zip
Align our subprocess usage with current best practices. (#12940)
* Align our subprocess usage with current best practices. * remove unused import * Apply suggestions from code review Co-authored-by: Ryan <fauxpark@gmail.com> * fix the cpp invocation for older python * allow for unprompted installation * make sure qmk new-keyboard works on windows Co-authored-by: Ryan <fauxpark@gmail.com>
Diffstat (limited to 'lib/python/qmk/cli/doctor.py')
-rwxr-xr-xlib/python/qmk/cli/doctor.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/python/qmk/cli/doctor.py b/lib/python/qmk/cli/doctor.py
index 4a2e2010f..9e1057062 100755
--- a/lib/python/qmk/cli/doctor.py
+++ b/lib/python/qmk/cli/doctor.py
@@ -3,12 +3,12 @@
3Check out the user's QMK environment and make sure it's ready to compile. 3Check out the user's QMK environment and make sure it's ready to compile.
4""" 4"""
5import platform 5import platform
6from subprocess import DEVNULL
6 7
7from milc import cli 8from milc import cli
8from milc.questions import yesno 9from milc.questions import yesno
9from qmk import submodules 10from qmk import submodules
10from qmk.constants import QMK_FIRMWARE 11from qmk.constants import QMK_FIRMWARE
11from qmk.commands import run
12from qmk.os_helpers import CheckStatus, check_binaries, check_binary_versions, check_submodules, check_git_repo 12from qmk.os_helpers import CheckStatus, check_binaries, check_binary_versions, check_submodules, check_git_repo
13 13
14 14
@@ -93,7 +93,7 @@ def doctor(cli):
93 93
94 if not bin_ok: 94 if not bin_ok:
95 if yesno('Would you like to install dependencies?', default=True): 95 if yesno('Would you like to install dependencies?', default=True):
96 run(['util/qmk_install.sh']) 96 cli.run(['util/qmk_install.sh', '-y'], stdin=DEVNULL, capture_output=False)
97 bin_ok = check_binaries() 97 bin_ok = check_binaries()
98 98
99 if bin_ok: 99 if bin_ok: