diff options
| author | Takeshi ISHII <2170248+mtei@users.noreply.github.com> | 2020-03-10 17:46:03 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-10 01:46:03 -0700 |
| commit | dbbab409812ea7c579760e2973399245c21ff843 (patch) | |
| tree | b19d9baf161435f61abd48b0ba00f5907cd61ecc /tmk_core/common/chibios | |
| parent | 20a0fa9209756288b014f65671bcaab12a028229 (diff) | |
| download | qmk_firmware-dbbab409812ea7c579760e2973399245c21ff843.tar.gz qmk_firmware-dbbab409812ea7c579760e2973399245c21ff843.zip | |
Refactor rgblight_reconfig.h (#7773)
* Moved contents of rgblight_reconfig.h to rgblight_post_config.h.
In #3582, rgblight_reconfig.h had to be newly created. Now, the build system of qmk_firmware has a post_cofig feature, so that what was done in rgblight_reconfig.h can now be realized in rgblight_post_config.h.
**This commit does not change the build result.**
Testing script
```shell
# build on master
git checkout master
echo master > /tmp/master_md5.txt
# RGBLIGHT_ENABLE = no
make HELIX=verbose helix/rev2:default:clean
make HELIX=verbose helix/rev2:default
md5 helix_rev2_default.hex >> /tmp/master_md5.txt
# RGBLIGHT_ENABLE = yes, with animations
make HELIX=verbose helix/rev2/back:default:clean
make HELIX=verbose helix/rev2/back:default
md5 helix_rev2_back_default.hex >> /tmp/master_md5.txt
# RGBLIGHT_ENABLE = yes, without animations
make HELIX=verbose,no_ani helix/rev2/back:default:clean
make HELIX=verbose,no_ani helix/rev2/back:default
md5 helix_rev2_back_default.hex >> /tmp/master_md5.txt
# build on refactor_rgblight_reconfig.h
git checkout refactor_rgblight_reconfig.h
echo refactor_rgblight_reconfig.h > /tmp/branch_md5.txt
# RGBLIGHT_ENABLE = no
make HELIX=verbose helix/rev2:default:clean
make HELIX=verbose helix/rev2:default
md5 helix_rev2_default.hex >> /tmp/branch_md5.txt
# RGBLIGHT_ENABLE = yes, with animations
make HELIX=verbose helix/rev2/back:default:clean
make HELIX=verbose helix/rev2/back:default
md5 helix_rev2_back_default.hex >> /tmp/branch_md5.txt
# RGBLIGHT_ENABLE = yes, without animations
make HELIX=verbose,no_ani helix/rev2/back:default:clean
make HELIX=verbose,no_ani helix/rev2/back:default
md5 helix_rev2_back_default.hex >> /tmp/branch_md5.txt
diff -u /tmp/master_md5.txt /tmp/branch_md5.txt
```
Test result:
```
--- /tmp/master_md5.txt 2020-01-03 15:42:22.000000000 +0900
+++ /tmp/branch_md5.txt 2020-01-03 15:42:42.000000000 +0900
@@ -1,4 +1,4 @@
-master
+refactor_rgblight_reconfig.h
MD5 (helix_rev2_default.hex) = f360032edd522448366d471d8f4f8181
MD5 (helix_rev2_back_default.hex) = 0c663acc6cccc44476b3b969ad22a48f
MD5 (helix_rev2_back_default.hex) = e66b1195ff6d38e6e22c975b8ae42fd3
```
* Expressions that are too long are difficult to read, so wrap them.
* Edit the expression again
* remove `defined(RGBLIGHT_ANIMATIONS)` in `tmk_core/common/*/suspend.c`, `tmk_core/protocol/*/main.c`
move contents of rgblight_reconfig.h to rgblight.h.
The following changes were made to rgblight.h.
```diff
+#ifdef RGBLIGHT_USE_TIMER
void rgblight_task(void);
void rgblight_timer_init(void);
void rgblight_timer_enable(void);
void rgblight_timer_disable(void);
void rgblight_timer_toggle(void);
+#else
+#define rgblight_task()
+#define rgblight_timer_init()
+#define rgblight_timer_enable()
+#define rgblight_timer_disable()
+#define rgblight_timer_toggle()
+#endif
```
The following changes were made to tmk_core/common/avr/suspend.c, tmk_core/common/chibios/suspend.c, tmk_core/protocol/chibios/main.c, tmk_core/protocol/lufa/lufa.c, tmk_core/protocol/vusb/main.c.
```diff
-# ifdef RGBLIGHT_ANIMATIONS
rgblight_timer_enable();
-# endif
```
```diff
-#if defined(RGBLIGHT_ANIMATIONS) && defined(RGBLIGHT_ENABLE)
+#if defined(RGBLIGHT_ENABLE)
rgblight_task();
#endif
```
* remove 'defined(RGBLIGHT_ANIMATIONS)' in tmk_core/common/keyboard.c
Co-authored-by: Joel Challis <git@zvecr.com>
Diffstat (limited to 'tmk_core/common/chibios')
| -rw-r--r-- | tmk_core/common/chibios/suspend.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/tmk_core/common/chibios/suspend.c b/tmk_core/common/chibios/suspend.c index 5be1b7677..8c071e7a0 100644 --- a/tmk_core/common/chibios/suspend.c +++ b/tmk_core/common/chibios/suspend.c | |||
| @@ -51,9 +51,7 @@ void suspend_power_down(void) { | |||
| 51 | // shouldn't power down TPM/FTM if we want a breathing LED | 51 | // shouldn't power down TPM/FTM if we want a breathing LED |
| 52 | // also shouldn't power down USB | 52 | // also shouldn't power down USB |
| 53 | #if defined(RGBLIGHT_SLEEP) && defined(RGBLIGHT_ENABLE) | 53 | #if defined(RGBLIGHT_SLEEP) && defined(RGBLIGHT_ENABLE) |
| 54 | # ifdef RGBLIGHT_ANIMATIONS | ||
| 55 | rgblight_timer_disable(); | 54 | rgblight_timer_disable(); |
| 56 | # endif | ||
| 57 | if (!is_suspended) { | 55 | if (!is_suspended) { |
| 58 | is_suspended = true; | 56 | is_suspended = true; |
| 59 | rgblight_enabled = rgblight_config.enable; | 57 | rgblight_enabled = rgblight_config.enable; |
| @@ -126,9 +124,7 @@ void suspend_wakeup_init(void) { | |||
| 126 | if (rgblight_enabled) { | 124 | if (rgblight_enabled) { |
| 127 | rgblight_enable_noeeprom(); | 125 | rgblight_enable_noeeprom(); |
| 128 | } | 126 | } |
| 129 | # ifdef RGBLIGHT_ANIMATIONS | ||
| 130 | rgblight_timer_enable(); | 127 | rgblight_timer_enable(); |
| 131 | # endif | ||
| 132 | #endif | 128 | #endif |
| 133 | suspend_wakeup_init_kb(); | 129 | suspend_wakeup_init_kb(); |
| 134 | } | 130 | } |
