aboutsummaryrefslogtreecommitdiff
path: root/tmk_core
diff options
context:
space:
mode:
authorDanny Nguyen <danny@keeb.io>2018-11-02 15:28:16 -0400
committerDrashna Jaelre <drashna@live.com>2018-11-02 14:31:29 -0700
commita5fa75fcb3de822f4e43dcf29cee6eb9f945a992 (patch)
tree38e37e3e83e34f611293a266b59be0cee906de34 /tmk_core
parent5779ffb59a2e36fd45c3d4000d41ad73ad140de3 (diff)
downloadqmk_firmware-a5fa75fcb3de822f4e43dcf29cee6eb9f945a992.tar.gz
qmk_firmware-a5fa75fcb3de822f4e43dcf29cee6eb9f945a992.zip
Move disable JTAG code from `keyboard_init` to `keyboard_setup`
This way all split keyboards are using that code instead of just those using split_common with the fix
Diffstat (limited to 'tmk_core')
-rw-r--r--tmk_core/common/keyboard.c14
-rw-r--r--tmk_core/common/keyboard.h2
2 files changed, 11 insertions, 5 deletions
diff --git a/tmk_core/common/keyboard.c b/tmk_core/common/keyboard.c
index 13b3cb4c0..a6a5fb56b 100644
--- a/tmk_core/common/keyboard.c
+++ b/tmk_core/common/keyboard.c
@@ -120,6 +120,14 @@ static inline bool has_ghost_in_row(uint8_t row, matrix_row_t rowdata)
120 120
121#endif 121#endif
122 122
123void disable_jtag(void) {
124// To use PORTF disable JTAG with writing JTD bit twice within four cycles.
125#if (defined(__AVR_AT90USB1286__) || defined(__AVR_AT90USB1287__) || defined(__AVR_ATmega32U4__))
126 MCUCR |= _BV(JTD);
127 MCUCR |= _BV(JTD);
128#endif
129}
130
123/** \brief matrix_setup 131/** \brief matrix_setup
124 * 132 *
125 * FIXME: needs doc 133 * FIXME: needs doc
@@ -133,6 +141,7 @@ void matrix_setup(void) {
133 * FIXME: needs doc 141 * FIXME: needs doc
134 */ 142 */
135void keyboard_setup(void) { 143void keyboard_setup(void) {
144 disable_jtag();
136 matrix_setup(); 145 matrix_setup();
137} 146}
138 147
@@ -151,11 +160,6 @@ bool is_keyboard_master(void) {
151 */ 160 */
152void keyboard_init(void) { 161void keyboard_init(void) {
153 timer_init(); 162 timer_init();
154// To use PORTF disable JTAG with writing JTD bit twice within four cycles.
155#if (defined(__AVR_AT90USB1286__) || defined(__AVR_AT90USB1287__) || defined(__AVR_ATmega32U4__))
156 MCUCR |= _BV(JTD);
157 MCUCR |= _BV(JTD);
158#endif
159 matrix_init(); 163 matrix_init();
160#ifdef PS2_MOUSE_ENABLE 164#ifdef PS2_MOUSE_ENABLE
161 ps2_mouse_init(); 165 ps2_mouse_init();
diff --git a/tmk_core/common/keyboard.h b/tmk_core/common/keyboard.h
index f17003c2f..71e594a89 100644
--- a/tmk_core/common/keyboard.h
+++ b/tmk_core/common/keyboard.h
@@ -57,6 +57,8 @@ static inline bool IS_RELEASED(keyevent_t event) { return (!IS_NOEVENT(event) &&
57 .time = (timer_read() | 1) \ 57 .time = (timer_read() | 1) \
58} 58}
59 59
60void disable_jtag(void);
61
60/* it runs once at early stage of startup before keyboard_init. */ 62/* it runs once at early stage of startup before keyboard_init. */
61void keyboard_setup(void); 63void keyboard_setup(void);
62/* it runs once after initializing host side protocol, debug and MCU peripherals. */ 64/* it runs once after initializing host side protocol, debug and MCU peripherals. */