aboutsummaryrefslogtreecommitdiff
path: root/common
diff options
context:
space:
mode:
Diffstat (limited to 'common')
-rw-r--r--common/keyboard.c25
-rw-r--r--common/matrix.h2
2 files changed, 24 insertions, 3 deletions
diff --git a/common/keyboard.c b/common/keyboard.c
index 432ea8934..91f321d9c 100644
--- a/common/keyboard.c
+++ b/common/keyboard.c
@@ -34,6 +34,24 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
34#endif 34#endif
35 35
36 36
37#ifdef MATRIX_HAS_GHOST
38static bool has_ghost_in_row(uint8_t row)
39{
40 matrix_row_t matrix_row = matrix_get_row(row);
41 // No ghost exists when less than 2 keys are down on the row
42 if (((matrix_row - 1) & matrix_row) == 0)
43 return false;
44
45 // Ghost occurs when the row shares column line with other row
46 for (uint8_t i=0; i < MATRIX_ROWS; i++) {
47 if (i != row && (matrix_get_row(i) & matrix_row))
48 return true;
49 }
50 return false;
51}
52#endif
53
54
37void keyboard_init(void) 55void keyboard_init(void)
38{ 56{
39 // TODO: configuration of sendchar impl 57 // TODO: configuration of sendchar impl
@@ -81,7 +99,12 @@ void keyboard_task(void)
81 matrix_change = matrix_row ^ matrix_prev[r]; 99 matrix_change = matrix_row ^ matrix_prev[r];
82 if (matrix_change) { 100 if (matrix_change) {
83 if (debug_matrix) matrix_print(); 101 if (debug_matrix) matrix_print();
84 102#ifdef MATRIX_HAS_GHOST
103 if (has_ghost_in_row(r)) {
104 matrix_prev[r] = matrix_row;
105 continue;
106 }
107#endif
85 for (uint8_t c = 0; c < MATRIX_COLS; c++) { 108 for (uint8_t c = 0; c < MATRIX_COLS; c++) {
86 if (matrix_change & ((matrix_row_t)1<<c)) { 109 if (matrix_change & ((matrix_row_t)1<<c)) {
87 action_exec((keyevent_t){ 110 action_exec((keyevent_t){
diff --git a/common/matrix.h b/common/matrix.h
index b3332d5ff..48203c71d 100644
--- a/common/matrix.h
+++ b/common/matrix.h
@@ -45,8 +45,6 @@ void matrix_init(void);
45uint8_t matrix_scan(void); 45uint8_t matrix_scan(void);
46/* whether modified from previous scan. used after matrix_scan. */ 46/* whether modified from previous scan. used after matrix_scan. */
47bool matrix_is_modified(void); 47bool matrix_is_modified(void);
48/* whether ghosting occur on matrix. */
49bool matrix_has_ghost(void);
50/* whether a swtich is on */ 48/* whether a swtich is on */
51bool matrix_is_on(uint8_t row, uint8_t col); 49bool matrix_is_on(uint8_t row, uint8_t col);
52/* matrix state on row */ 50/* matrix state on row */