aboutsummaryrefslogtreecommitdiff
path: root/lib/python/qmk/cli/doctor
diff options
context:
space:
mode:
Diffstat (limited to 'lib/python/qmk/cli/doctor')
-rw-r--r--lib/python/qmk/cli/doctor/linux.py8
-rwxr-xr-xlib/python/qmk/cli/doctor/main.py9
2 files changed, 8 insertions, 9 deletions
diff --git a/lib/python/qmk/cli/doctor/linux.py b/lib/python/qmk/cli/doctor/linux.py
index 6ce00f6ef..94683d330 100644
--- a/lib/python/qmk/cli/doctor/linux.py
+++ b/lib/python/qmk/cli/doctor/linux.py
@@ -118,10 +118,9 @@ def check_udev_rules():
118 cli.log.warning("{fg_yellow}Found old, deprecated udev rules for '%s' boards. The new rules on https://docs.qmk.fm/#/faq_build?id=linux-udev-rules offer better security with the same functionality.", bootloader) 118 cli.log.warning("{fg_yellow}Found old, deprecated udev rules for '%s' boards. The new rules on https://docs.qmk.fm/#/faq_build?id=linux-udev-rules offer better security with the same functionality.", bootloader)
119 else: 119 else:
120 # For caterina, check if ModemManager is running 120 # For caterina, check if ModemManager is running
121 if bootloader == "caterina": 121 if bootloader == "caterina" and check_modem_manager():
122 if check_modem_manager(): 122 cli.log.warning("{fg_yellow}Detected ModemManager without the necessary udev rules. Please either disable it or set the appropriate udev rules if you are using a Pro Micro.")
123 rc = CheckStatus.WARNING 123
124 cli.log.warning("{fg_yellow}Detected ModemManager without the necessary udev rules. Please either disable it or set the appropriate udev rules if you are using a Pro Micro.")
125 rc = CheckStatus.WARNING 124 rc = CheckStatus.WARNING
126 cli.log.warning("{fg_yellow}Missing or outdated udev rules for '%s' boards. Run 'sudo cp %s/util/udev/50-qmk.rules /etc/udev/rules.d/'.", bootloader, QMK_FIRMWARE) 125 cli.log.warning("{fg_yellow}Missing or outdated udev rules for '%s' boards. Run 'sudo cp %s/util/udev/50-qmk.rules /etc/udev/rules.d/'.", bootloader, QMK_FIRMWARE)
127 126
@@ -167,6 +166,5 @@ def os_test_linux():
167 return CheckStatus.OK 166 return CheckStatus.OK
168 else: 167 else:
169 cli.log.info("Detected {fg_cyan}Linux{fg_reset}.") 168 cli.log.info("Detected {fg_cyan}Linux{fg_reset}.")
170 from .linux import check_udev_rules
171 169
172 return check_udev_rules() 170 return check_udev_rules()
diff --git a/lib/python/qmk/cli/doctor/main.py b/lib/python/qmk/cli/doctor/main.py
index 6a31ccdfd..ed20f46d3 100755
--- a/lib/python/qmk/cli/doctor/main.py
+++ b/lib/python/qmk/cli/doctor/main.py
@@ -79,12 +79,13 @@ def doctor(cli):
79 cli.log.info('CLI version: %s', cli.version) 79 cli.log.info('CLI version: %s', cli.version)
80 cli.log.info('QMK home: {fg_cyan}%s', QMK_FIRMWARE) 80 cli.log.info('QMK home: {fg_cyan}%s', QMK_FIRMWARE)
81 81
82 status = os_tests() 82 status = os_status = os_tests()
83 git_status = git_tests()
83 84
84 status = git_tests() 85 if git_status == CheckStatus.ERROR or (os_status == CheckStatus.OK and git_status == CheckStatus.WARNING):
86 status = git_status
85 87
86 venv = in_virtualenv() 88 if in_virtualenv():
87 if venv:
88 cli.log.info('CLI installed in virtualenv.') 89 cli.log.info('CLI installed in virtualenv.')
89 90
90 # Make sure the basic CLI tools we need are available and can be executed. 91 # Make sure the basic CLI tools we need are available and can be executed.