diff options
| author | Federico Igne <federico.igne@cs.ox.ac.uk> | 2021-04-15 12:32:45 +0100 |
|---|---|---|
| committer | Federico Igne <federico.igne@cs.ox.ac.uk> | 2021-04-15 12:32:45 +0100 |
| commit | 826ef61338f8cf9c5c71fe2fd5b2ed82e0dabcf9 (patch) | |
| tree | 1936a71db16fd9221389daf9d4454353754ac4d9 /src | |
| parent | c6a63f565b8311348a800366c05dc3a6e964872c (diff) | |
| download | RSAComb-826ef61338f8cf9c5c71fe2fd5b2ed82e0dabcf9.tar.gz RSAComb-826ef61338f8cf9c5c71fe2fd5b2ed82e0dabcf9.zip | |
Prepare code for double-blind submissionv0.1.0
Diffstat (limited to 'src')
3 files changed, 0 insertions, 14 deletions
diff --git a/src/main/scala/uk/ac/ox/cs/rsacomb/CanonicalModel.scala b/src/main/scala/uk/ac/ox/cs/rsacomb/CanonicalModel.scala index 3da6c8a..6621f59 100644 --- a/src/main/scala/uk/ac/ox/cs/rsacomb/CanonicalModel.scala +++ b/src/main/scala/uk/ac/ox/cs/rsacomb/CanonicalModel.scala | |||
| @@ -118,10 +118,6 @@ class CanonicalModel(val ontology: RSAOntology) { | |||
| 118 | .getIRI | 118 | .getIRI |
| 119 | TupleTableAtom.rdf(v0, IRI.RDF_TYPE, cls) | 119 | TupleTableAtom.rdf(v0, IRI.RDF_TYPE, cls) |
| 120 | } | 120 | } |
| 121 | // TODO: To be consistent with the specifics of the visitor we are | ||
| 122 | // returning facts as `Rule`s with true body. While this is correct | ||
| 123 | // there is an easier way to import facts into RDFox. Are we able to | ||
| 124 | // do that? | ||
| 125 | val facts = unfold map RSA.In | 121 | val facts = unfold map RSA.In |
| 126 | val rules = List( | 122 | val rules = List( |
| 127 | Rule.create(roleRf, atomA, RSA.NotIn(varX)), | 123 | Rule.create(roleRf, atomA, RSA.NotIn(varX)), |
diff --git a/src/main/scala/uk/ac/ox/cs/rsacomb/RSAOntology.scala b/src/main/scala/uk/ac/ox/cs/rsacomb/RSAOntology.scala index 3527da5..c7b3bf0 100644 --- a/src/main/scala/uk/ac/ox/cs/rsacomb/RSAOntology.scala +++ b/src/main/scala/uk/ac/ox/cs/rsacomb/RSAOntology.scala | |||
| @@ -459,7 +459,6 @@ class RSAOntology(val original: OWLOntology, val datafiles: File*) { | |||
| 459 | Logger.DEBUG | 459 | Logger.DEBUG |
| 460 | ) | 460 | ) |
| 461 | 461 | ||
| 462 | // TODO: the following functions needs testing | ||
| 463 | def confl( | 462 | def confl( |
| 464 | role: OWLObjectPropertyExpression | 463 | role: OWLObjectPropertyExpression |
| 465 | ): Set[OWLObjectPropertyExpression] = { | 464 | ): Set[OWLObjectPropertyExpression] = { |
| @@ -655,7 +654,6 @@ class RSAOntology(val original: OWLOntology, val datafiles: File*) { | |||
| 655 | // We just need the TBox to find | 654 | // We just need the TBox to find |
| 656 | val terms = for { | 655 | val terms = for { |
| 657 | axiom1 <- tbox | 656 | axiom1 <- tbox |
| 658 | // TODO: is this an optimization or an error? | ||
| 659 | if axiom1.isT5 | 657 | if axiom1.isT5 |
| 660 | // We expect only one role coming out of a T5 axiom | 658 | // We expect only one role coming out of a T5 axiom |
| 661 | roleS <- axiom1.objectPropertyExpressionsInSignature | 659 | roleS <- axiom1.objectPropertyExpressionsInSignature |
diff --git a/src/main/scala/uk/ac/ox/cs/rsacomb/converter/RDFoxConverter.scala b/src/main/scala/uk/ac/ox/cs/rsacomb/converter/RDFoxConverter.scala index c9bed35..3fac46f 100644 --- a/src/main/scala/uk/ac/ox/cs/rsacomb/converter/RDFoxConverter.scala +++ b/src/main/scala/uk/ac/ox/cs/rsacomb/converter/RDFoxConverter.scala | |||
| @@ -23,13 +23,6 @@ import uk.ac.ox.cs.rsacomb.util.{RSA, RDFoxUtil} | |||
| 23 | * @note the input axioms are assumed to be normalized. Trying to | 23 | * @note the input axioms are assumed to be normalized. Trying to |
| 24 | * convert non normalized axioms might result in undefined behavious. | 24 | * convert non normalized axioms might result in undefined behavious. |
| 25 | * We use the normalization defined in the main paper. | 25 | * We use the normalization defined in the main paper. |
| 26 | * | ||
| 27 | * @see [[https://github.com/KRR-Oxford/RSA-combined-approach GitHub repository]] | ||
| 28 | * for more information on the theoretical aspects of the system. | ||
| 29 | * | ||
| 30 | * @todo this is not ideal and it would be more sensible to prepend a | ||
| 31 | * normalization procedure that will prevent errors or unexpected | ||
| 32 | * results. | ||
| 33 | */ | 26 | */ |
| 34 | trait RDFoxConverter { | 27 | trait RDFoxConverter { |
| 35 | 28 | ||
| @@ -358,7 +351,6 @@ trait RDFoxConverter { | |||
| 358 | */ | 351 | */ |
| 359 | case e: OWLDataSomeValuesFrom => { | 352 | case e: OWLDataSomeValuesFrom => { |
| 360 | val role = e.getProperty() | 353 | val role = e.getProperty() |
| 361 | // TODO: simplify this: | ||
| 362 | // Computes the result of rule skolemization. Depending on the used | 354 | // Computes the result of rule skolemization. Depending on the used |
| 363 | // technique it might involve the introduction of additional atoms, | 355 | // technique it might involve the introduction of additional atoms, |
| 364 | // and/or fresh constants and variables. | 356 | // and/or fresh constants and variables. |
